mbox series

[0/5] blank lines at EOF fixes

Message ID 20190731145742.10776-1-stephen@networkplumber.org (mailing list archive)
Headers
Series blank lines at EOF fixes |

Message

Stephen Hemminger July 31, 2019, 2:57 p.m. UTC
  Using a simple shell script which cleans up trailing whitespace
found several places with extra lines at end of file.

More in base drivers but they are known to be problematic.

Stephen Hemminger (5):
  examples: remove extra blank lines at eof
  test: remove blank lines at eof
  pmdinfogen: remove blank line at eof
  net/ipn3ke: cleanup blank line at eof
  net/mlx5: remove blank lines at eof

 app/test/test_cryptodev_asym_util.h   | 4 ----
 app/test/test_table_combined.c        | 1 -
 app/test/test_table_tables.c          | 3 +--
 buildtools/pmdinfogen/pmdinfogen.h    | 1 -
 drivers/net/ipn3ke/ipn3ke_flow.c      | 1 -
 drivers/net/ipn3ke/ipn3ke_tm.c        | 1 -
 drivers/net/mlx5/mlx5_rxtx.c          | 2 --
 examples/flow_filtering/flow_blocks.c | 1 -
 examples/l3fwd-power/perf_core.c      | 1 -
 examples/vhost_scsi/vhost_scsi.c      | 1 -
 10 files changed, 1 insertion(+), 15 deletions(-)
  

Comments

Bruce Richardson July 31, 2019, 3:38 p.m. UTC | #1
On Wed, Jul 31, 2019 at 07:57:37AM -0700, Stephen Hemminger wrote:
> Using a simple shell script which cleans up trailing whitespace
> found several places with extra lines at end of file.
> 
> More in base drivers but they are known to be problematic.
> 
> Stephen Hemminger (5):
>   examples: remove extra blank lines at eof
>   test: remove blank lines at eof
>   pmdinfogen: remove blank line at eof
>   net/ipn3ke: cleanup blank line at eof
>   net/mlx5: remove blank lines at eof
> 
>  app/test/test_cryptodev_asym_util.h   | 4 ----
>  app/test/test_table_combined.c        | 1 -
>  app/test/test_table_tables.c          | 3 +--
>  buildtools/pmdinfogen/pmdinfogen.h    | 1 -
>  drivers/net/ipn3ke/ipn3ke_flow.c      | 1 -
>  drivers/net/ipn3ke/ipn3ke_tm.c        | 1 -
>  drivers/net/mlx5/mlx5_rxtx.c          | 2 --
>  examples/flow_filtering/flow_blocks.c | 1 -
>  examples/l3fwd-power/perf_core.c      | 1 -
>  examples/vhost_scsi/vhost_scsi.c      | 1 -
>  10 files changed, 1 insertion(+), 15 deletions(-)
> 
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>

I really wonder if removing blank lines at EOF would really be a problem
for base drivers? Seems like it should not be a major issue, but perhaps
maintainers best comment first.
  
Thomas Monjalon Aug. 5, 2019, 1:20 p.m. UTC | #2
31/07/2019 17:38, Bruce Richardson:
> On Wed, Jul 31, 2019 at 07:57:37AM -0700, Stephen Hemminger wrote:
> > Using a simple shell script which cleans up trailing whitespace
> > found several places with extra lines at end of file.
> > 
> > More in base drivers but they are known to be problematic.
> > 
> > Stephen Hemminger (5):
> >   examples: remove extra blank lines at eof
> >   test: remove blank lines at eof
> >   pmdinfogen: remove blank line at eof
> >   net/ipn3ke: cleanup blank line at eof
> >   net/mlx5: remove blank lines at eof
> > 
> >  app/test/test_cryptodev_asym_util.h   | 4 ----
> >  app/test/test_table_combined.c        | 1 -
> >  app/test/test_table_tables.c          | 3 +--
> >  buildtools/pmdinfogen/pmdinfogen.h    | 1 -
> >  drivers/net/ipn3ke/ipn3ke_flow.c      | 1 -
> >  drivers/net/ipn3ke/ipn3ke_tm.c        | 1 -
> >  drivers/net/mlx5/mlx5_rxtx.c          | 2 --
> >  examples/flow_filtering/flow_blocks.c | 1 -
> >  examples/l3fwd-power/perf_core.c      | 1 -
> >  examples/vhost_scsi/vhost_scsi.c      | 1 -
> >  10 files changed, 1 insertion(+), 15 deletions(-)
> > 
> Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied and squashed, thanks