mbox series

[v6,0/6] examples/ioat: sample app on ioat driver usage

Message ID 20190930075034.2000-1-marcinx.baran@intel.com (mailing list archive)
Headers
Series examples/ioat: sample app on ioat driver usage |

Message

Marcin Baran Sept. 30, 2019, 7:50 a.m. UTC
  A new sample app demonstrating use of driver for CBDMA.
The app receives packets, performs software or hardware
copy, changes packets' MAC addresses (if enabled) and
forwards them. The patch includes sample application as
well as it's guide.

v6:
 - rearrange 'ioat_tx_port()' to remove unnecessary code
 - improve documentation
 - format patches for better readability

v5:
 - change dependency name from 'pmd_ioat' to 'rawdev_ioat'
   fixing build errors (branch diverged from master)

v4:
 - fix meson build support check

v3:
 - add check for meson build whether IOAT is supported

v2:
 - change printing total stats to be deltas
 - update documentation
 - fix 1 thread/sw copy/multiple Rx queues packet dropping
 - divide patch into several presenting functional change


Marcin Baran (4):
  examples/ioat: add software copy support
  examples/ioat: add rawdev copy mode support
  examples/ioat: add stats printing for each port
  doc/guides/: provide IOAT sample app guide

Pawel Modrak (2):
  examples/ioat: create sample app on ioat driver usage
  examples/ioat: add two threads configuration

 doc/guides/sample_app_ug/index.rst |    1 +
 doc/guides/sample_app_ug/intro.rst |    4 +
 doc/guides/sample_app_ug/ioat.rst  |  581 ++++++++++++++++
 examples/Makefile                  |    3 +
 examples/ioat/Makefile             |   54 ++
 examples/ioat/ioatfwd.c            | 1003 ++++++++++++++++++++++++++++
 examples/ioat/meson.build          |   15 +
 examples/meson.build               |    1 +
 8 files changed, 1662 insertions(+)
 create mode 100644 doc/guides/sample_app_ug/ioat.rst
 create mode 100644 examples/ioat/Makefile
 create mode 100644 examples/ioat/ioatfwd.c
 create mode 100644 examples/ioat/meson.build
  

Comments

Bruce Richardson Oct. 3, 2019, 9:48 a.m. UTC | #1
On Mon, Sep 30, 2019 at 09:50:28AM +0200, Marcin Baran wrote:
> A new sample app demonstrating use of driver for CBDMA.
> The app receives packets, performs software or hardware
> copy, changes packets' MAC addresses (if enabled) and
> forwards them. The patch includes sample application as
> well as it's guide.
> 
> v6:
>  - rearrange 'ioat_tx_port()' to remove unnecessary code
>  - improve documentation
>  - format patches for better readability
> 
> v5:
>  - change dependency name from 'pmd_ioat' to 'rawdev_ioat'
>    fixing build errors (branch diverged from master)
> 
> v4:
>  - fix meson build support check
> 
> v3:
>  - add check for meson build whether IOAT is supported
> 
> v2:
>  - change printing total stats to be deltas
>  - update documentation
>  - fix 1 thread/sw copy/multiple Rx queues packet dropping
>  - divide patch into several presenting functional change
> 
> 
> Marcin Baran (4):
>   examples/ioat: add software copy support
>   examples/ioat: add rawdev copy mode support
>   examples/ioat: add stats printing for each port
>   doc/guides/: provide IOAT sample app guide
> 
> Pawel Modrak (2):
>   examples/ioat: create sample app on ioat driver usage
>   examples/ioat: add two threads configuration
> 
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
  
Kevin Traynor Oct. 4, 2019, 5:16 p.m. UTC | #2
On 30/09/2019 08:50, Marcin Baran wrote:
> A new sample app demonstrating use of driver for CBDMA.
> The app receives packets, performs software or hardware
> copy, changes packets' MAC addresses (if enabled) and
> forwards them. The patch includes sample application as
> well as it's guide.
> 
> v6:
>  - rearrange 'ioat_tx_port()' to remove unnecessary code
>  - improve documentation
>  - format patches for better readability
> 
> v5:
>  - change dependency name from 'pmd_ioat' to 'rawdev_ioat'
>    fixing build errors (branch diverged from master)
> 
> v4:
>  - fix meson build support check
> 
> v3:
>  - add check for meson build whether IOAT is supported
> 
> v2:
>  - change printing total stats to be deltas
>  - update documentation
>  - fix 1 thread/sw copy/multiple Rx queues packet dropping
>  - divide patch into several presenting functional change
> 
> 
> Marcin Baran (4):
>   examples/ioat: add software copy support
>   examples/ioat: add rawdev copy mode support
>   examples/ioat: add stats printing for each port
>   doc/guides/: provide IOAT sample app guide
> 
> Pawel Modrak (2):
>   examples/ioat: create sample app on ioat driver usage
>   examples/ioat: add two threads configuration
> 
>  doc/guides/sample_app_ug/index.rst |    1 +
>  doc/guides/sample_app_ug/intro.rst |    4 +
>  doc/guides/sample_app_ug/ioat.rst  |  581 ++++++++++++++++
>  examples/Makefile                  |    3 +
>  examples/ioat/Makefile             |   54 ++
>  examples/ioat/ioatfwd.c            | 1003 ++++++++++++++++++++++++++++
>  examples/ioat/meson.build          |   15 +
>  examples/meson.build               |    1 +
>  8 files changed, 1662 insertions(+)
>  create mode 100644 doc/guides/sample_app_ug/ioat.rst
>  create mode 100644 examples/ioat/Makefile
>  create mode 100644 examples/ioat/ioatfwd.c
>  create mode 100644 examples/ioat/meson.build
> 

Just a nit, but I think you need to add something to the MAINTAINERS
file for this example app, maybe it can be a follow up patch if it's the
only rework
  
Bruce Richardson Oct. 7, 2019, 11:10 a.m. UTC | #3
On Fri, Oct 04, 2019 at 06:16:55PM +0100, Kevin Traynor wrote:
> On 30/09/2019 08:50, Marcin Baran wrote:
> > A new sample app demonstrating use of driver for CBDMA.
> > The app receives packets, performs software or hardware
> > copy, changes packets' MAC addresses (if enabled) and
> > forwards them. The patch includes sample application as
> > well as it's guide.
> > 
> > v6:
> >  - rearrange 'ioat_tx_port()' to remove unnecessary code
> >  - improve documentation
> >  - format patches for better readability
> > 
> > v5:
> >  - change dependency name from 'pmd_ioat' to 'rawdev_ioat'
> >    fixing build errors (branch diverged from master)
> > 
> > v4:
> >  - fix meson build support check
> > 
> > v3:
> >  - add check for meson build whether IOAT is supported
> > 
> > v2:
> >  - change printing total stats to be deltas
> >  - update documentation
> >  - fix 1 thread/sw copy/multiple Rx queues packet dropping
> >  - divide patch into several presenting functional change
> > 
> > 
> > Marcin Baran (4):
> >   examples/ioat: add software copy support
> >   examples/ioat: add rawdev copy mode support
> >   examples/ioat: add stats printing for each port
> >   doc/guides/: provide IOAT sample app guide
> > 
> > Pawel Modrak (2):
> >   examples/ioat: create sample app on ioat driver usage
> >   examples/ioat: add two threads configuration
> > 
> >  doc/guides/sample_app_ug/index.rst |    1 +
> >  doc/guides/sample_app_ug/intro.rst |    4 +
> >  doc/guides/sample_app_ug/ioat.rst  |  581 ++++++++++++++++
> >  examples/Makefile                  |    3 +
> >  examples/ioat/Makefile             |   54 ++
> >  examples/ioat/ioatfwd.c            | 1003 ++++++++++++++++++++++++++++
> >  examples/ioat/meson.build          |   15 +
> >  examples/meson.build               |    1 +
> >  8 files changed, 1662 insertions(+)
> >  create mode 100644 doc/guides/sample_app_ug/ioat.rst
> >  create mode 100644 examples/ioat/Makefile
> >  create mode 100644 examples/ioat/ioatfwd.c
> >  create mode 100644 examples/ioat/meson.build
> > 
> 
> Just a nit, but I think you need to add something to the MAINTAINERS
> file for this example app, maybe it can be a follow up patch if it's the
> only rework

Good catch. For completeness I've sent up a V7 of this set, adding this
example under the existing ioat section in MAINTAINERS.

/Bruce