| Message ID | 20191002191456.28488-1-rmody@marvell.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A02401BF50; Wed, 2 Oct 2019 21:15:21 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 546991BED4 for <dev@dpdk.org>; Wed, 2 Oct 2019 21:15:20 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x92J0BcO002446; Wed, 2 Oct 2019 12:15:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0818; bh=2SPReiD+nBl7n3wUGC35oG3aj8kTMgIz8FecjjGnTCY=; b=l52laJ5wX/rZV+81NaZ8Rsd4ofKHIGMkecfivtWemXnwGUBDkwmH8QcoMSIuxkN21Vxt Ilsv/FDv9KtpZvROScZUeRo8bnXQTc3SfXF1fbOusMDKt+7qcinFwQJ1SMCN8gL9D3Jc 8AUmPjRaM51ef4gJ7p0Y6mlud8suJmAWkn8R+uN4X+mrn07AnQKHRgfpASCJZ+cn4bLr XT3Q/mvw3+p+S7waJDebhNja0UJsiO68cm0VRss1acBGB38hu6eyOHDHW9XvzGHMrHj7 FkCedapa9EIYhTFVc12sbDsS6mEHS0RbMkthv+t3ts3ImXRz1y6BBoJNwL/NbBooLZXV vg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2vd0ya086p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 02 Oct 2019 12:15:17 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 2 Oct 2019 12:15:15 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Wed, 2 Oct 2019 12:15:15 -0700 Received: from irv1user08.caveonetworks.com (unknown [10.104.116.105]) by maili.marvell.com (Postfix) with ESMTP id 54DA93F7043; Wed, 2 Oct 2019 12:15:15 -0700 (PDT) Received: (from rmody@localhost) by irv1user08.caveonetworks.com (8.14.4/8.14.4/Submit) id x92JFCJY028560; Wed, 2 Oct 2019 12:15:12 -0700 X-Authentication-Warning: irv1user08.caveonetworks.com: rmody set sender to rmody@marvell.com using -f From: Rasesh Mody <rmody@marvell.com> To: <dev@dpdk.org>, <jerinj@marvell.com>, <ferruh.yigit@intel.com> CC: Rasesh Mody <rmody@marvell.com>, <GR-Everest-DPDK-Dev@marvell.com> Date: Wed, 2 Oct 2019 12:14:53 -0700 Message-ID: <20191002191456.28488-1-rmody@marvell.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20190906072548.12304-1-rmody@marvell.com> References: <20190906072548.12304-1-rmody@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-02_08:2019-10-01,2019-10-02 signatures=0 Subject: [dpdk-dev] [PATCH v3 0/3] net/bnx2x: update to latest FW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
net/bnx2x: update to latest FW
|
|
Message
Rasesh Mody
Oct. 2, 2019, 7:14 p.m. UTC
Hi, Currently, BNX2X PMD uses a very old firmware 7.2.51. This patch series updated the base driver to use to latest firmware 7.13.11. The latest firmware comprises of enhancements and fixes. v3: - Addressed gcc 9.2 build issues v2: - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11" - Addressed most of checkpatch issues Thanks! -Rasesh Rasesh Mody (3): net/bnx2x: update and reorganize HW registers net/bnx2x: update HSI code net/bnx2x: update to latest FW 7.13.11 doc/guides/nics/bnx2x.rst | 4 +- drivers/net/bnx2x/bnx2x.c | 63 +- drivers/net/bnx2x/bnx2x.h | 95 +- drivers/net/bnx2x/bnx2x_osal.h | 29 + drivers/net/bnx2x/bnx2x_rxtx.c | 10 +- drivers/net/bnx2x/ecore_fw_defs.h | 252 +- drivers/net/bnx2x/ecore_hsi.h | 3508 ++++++++------- drivers/net/bnx2x/ecore_init.h | 214 +- drivers/net/bnx2x/ecore_init_ops.h | 192 +- drivers/net/bnx2x/ecore_mfw_req.h | 11 +- drivers/net/bnx2x/ecore_reg.h | 6617 +++++++++++++++++++--------- drivers/net/bnx2x/ecore_sp.c | 48 +- drivers/net/bnx2x/ecore_sp.h | 308 +- 13 files changed, 7185 insertions(+), 4166 deletions(-) create mode 100644 drivers/net/bnx2x/bnx2x_osal.h
Comments
On Thu, Oct 3, 2019 at 12:45 AM Rasesh Mody <rmody@marvell.com> wrote: > > Hi, > > Currently, BNX2X PMD uses a very old firmware 7.2.51. > This patch series updated the base driver to use to latest > firmware 7.13.11. The latest firmware comprises of enhancements > and fixes. > > v3: > - Addressed gcc 9.2 build issues > v2: > - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11" > - Addressed most of checkpatch issues > > Thanks! > -Rasesh > > Rasesh Mody (3): > net/bnx2x: update and reorganize HW registers > net/bnx2x: update HSI code > net/bnx2x: update to latest FW 7.13.11 I don't think this patch comes as _base_ code, Please fix the trivial and genuine check path errors. [master][dpdk-next-net-mrvl] $ ./devtools/checkpatches.sh ### net/bnx2x: update HSI code WARNING:TYPO_SPELLING: 'entires' may be misspelled - perhaps 'entries'? #863: FILE: drivers/net/bnx2x/ecore_hsi.h:2844: + /* 9 entires for the C2S PCP map for each inner VLAN PCP + 1 default */ total: 0 errors, 1 warnings, 0 checks, 5425 lines checked ### net/bnx2x: update to latest FW 7.13.11 CHECK:CAMELCASE: Avoid CamelCase: <assertListEntry> #174: FILE: drivers/net/bnx2x/ecore_fw_defs.h:18: + (IRO[151].base + ((assertListEntry) * IRO[151].m1)) CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: + (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: + (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ ^ CHECK:CAMELCASE: Avoid CamelCase: <pfId> #178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: + (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #189: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23: + (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #189: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23: + (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \ ^ CHECK:CAMELCASE: Avoid CamelCase: <funcId> #193: FILE: drivers/net/bnx2x/ecore_fw_defs.h:26: + (IRO[163].base + ((funcId) * IRO[163].m1)) CHECK:CAMELCASE: Avoid CamelCase: <hcIndex> #199: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30: + (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2)) CHECK:CAMELCASE: Avoid CamelCase: <sbId> #199: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30: + (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2)) CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #204: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32: + (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #204: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32: + (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \ CHECK:CAMELCASE: Avoid CamelCase: <iscsiEqId> [65/1889] #215: FILE: drivers/net/bnx2x/ecore_fw_defs.h:40: + (IRO[316].base + ((pfId) * IRO[316].m1) + ((iscsiEqId) * IRO[316].m2)) CHECK:CAMELCASE: Avoid CamelCase: <vfId> #287: FILE: drivers/net/bnx2x/ecore_fw_defs.h:87: +#define CSTORM_VF_PF_CHANNEL_STATE_OFFSET(vfId) \ CHECK:CAMELCASE: Avoid CamelCase: <portId> #368: FILE: drivers/net/bnx2x/ecore_fw_defs.h:142: + (IRO[187].base + ((portId) * IRO[187].m1)) CHECK:CAMELCASE: Avoid CamelCase: <clientId> #414: FILE: drivers/net/bnx2x/ecore_fw_defs.h:172: + (IRO[215].base + ((portId) * IRO[215].m1) + ((clientId) * \ CHECK:CAMELCASE: Avoid CamelCase: <qzoneId> #420: FILE: drivers/net/bnx2x/ecore_fw_defs.h:175: + (IRO[216].base + ((qzoneId) * IRO[216].m1)) CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #498: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241: + (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #498: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241: + (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: + (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: + (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: + (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: +#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: +#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #534: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276: +#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1) [16/1889] CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: +#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #534: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276: +#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #577: FILE: drivers/net/bnx2x/ecore_fw_defs.h:378: +#define TSDM_TIMER_TICK_RESUL_CHIP (1 * (1e-6)) ^ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r_order == MAX_RD_ORD' #1119: FILE: drivers/net/bnx2x/ecore_init_ops.h:499: + if ((CHIP_IS_E1(sc) || CHIP_IS_E1H(sc)) && (r_order == MAX_RD_ORD)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #1537: FILE: drivers/net/bnx2x/ecore_sp.h:138: +#define ECORE_ILT_ZALLOC(x, y, size) \ do { \ x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \ if (x) { \ if (bnx2x_dma_alloc((struct bnx2x_softc *)sc, \ size, (struct bnx2x_dma *)x, \ + "ILT", RTE_CACHE_LINE_SIZE) != 0) { \ rte_free(x); \ x = NULL; \ + *(y) = 0; \ } else { \ *y = ((struct bnx2x_dma *)x)->paddr; \ } \ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects? #1537: FILE: drivers/net/bnx2x/ecore_sp.h:138: +#define ECORE_ILT_ZALLOC(x, y, size) \ do { \ x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \ if (x) { \ if (bnx2x_dma_alloc((struct bnx2x_softc *)sc, \ size, (struct bnx2x_dma *)x, \ + "ILT", RTE_CACHE_LINE_SIZE) != 0) { \ rte_free(x); \ x = NULL; \ + *(y) = 0; \ } else { \ *y = ((struct bnx2x_dma *)x)->paddr; \ } \ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects? #2191: FILE: drivers/net/bnx2x/ecore_sp.h:1967: +#define PF_MAC_CREDIT_E2(sc, func_num) \ + ((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * VF_MAC_CREDIT_CNT) / \ + (func_num) + GET_NUM_VFS_PER_PF(sc) * VF_MAC_CREDIT_CNT) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects? > > doc/guides/nics/bnx2x.rst | 4 +- > drivers/net/bnx2x/bnx2x.c | 63 +- > drivers/net/bnx2x/bnx2x.h | 95 +- > drivers/net/bnx2x/bnx2x_osal.h | 29 + > drivers/net/bnx2x/bnx2x_rxtx.c | 10 +- > drivers/net/bnx2x/ecore_fw_defs.h | 252 +- > drivers/net/bnx2x/ecore_hsi.h | 3508 ++++++++------- > drivers/net/bnx2x/ecore_init.h | 214 +- > drivers/net/bnx2x/ecore_init_ops.h | 192 +- > drivers/net/bnx2x/ecore_mfw_req.h | 11 +- > drivers/net/bnx2x/ecore_reg.h | 6617 +++++++++++++++++++--------- > drivers/net/bnx2x/ecore_sp.c | 48 +- > drivers/net/bnx2x/ecore_sp.h | 308 +- > 13 files changed, 7185 insertions(+), 4166 deletions(-) > create mode 100644 drivers/net/bnx2x/bnx2x_osal.h > > -- > 2.18.0 >
>From: Jerin Jacob <jerinjacobk@gmail.com> >Sent: Wednesday, October 02, 2019 10:57 PM > >On Thu, Oct 3, 2019 at 12:45 AM Rasesh Mody <rmody@marvell.com> wrote: >> >> Hi, >> >> Currently, BNX2X PMD uses a very old firmware 7.2.51. >> This patch series updated the base driver to use to latest firmware >> 7.13.11. The latest firmware comprises of enhancements and fixes. >> >> v3: >> - Addressed gcc 9.2 build issues >> v2: >> - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11" >> - Addressed most of checkpatch issues >> >> Thanks! >> -Rasesh >> >> Rasesh Mody (3): >> net/bnx2x: update and reorganize HW registers >> net/bnx2x: update HSI code >> net/bnx2x: update to latest FW 7.13.11 > >I don't think this patch comes as _base_ code, Please fix the trivial and >genuine check path errors. These are base driver changes for updating the FW to latest. The remaining checkpatch issues in this patch set are to keep uniformity and readability of the base code. Cleaning up base code to remove these and other checkpatch issues in same context would be a separate activity(as it would result in lot more changes), independent of this patch set. Next when there is such a checkpatch code cleanup, we'll try to address the issues. Please apply these changes or let me know if v4 is needed. Thanks! -Rasesh > >[master][dpdk-next-net-mrvl] $ ./devtools/checkpatches.sh > >### net/bnx2x: update HSI code > >WARNING:TYPO_SPELLING: 'entires' may be misspelled - perhaps 'entries'? >#863: FILE: drivers/net/bnx2x/ecore_hsi.h:2844: >+ /* 9 entires for the C2S PCP map for each inner VLAN PCP + 1 >+ default */ > >total: 0 errors, 1 warnings, 0 checks, 5425 lines checked > >### net/bnx2x: update to latest FW 7.13.11 > >CHECK:CAMELCASE: Avoid CamelCase: <assertListEntry> >#174: FILE: drivers/net/bnx2x/ecore_fw_defs.h:18: >+ (IRO[151].base + ((assertListEntry) * IRO[151].m1)) > >CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) >#178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: >+ (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ > ^ > >CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) >#178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: >+ (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ > ^ > >CHECK:CAMELCASE: Avoid CamelCase: <pfId> >#178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: >+ (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ > >CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) >#189: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23: >+ (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \ > ^ > >CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) >#189: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23: >+ (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \ > ^ > >CHECK:CAMELCASE: Avoid CamelCase: <funcId> >#193: FILE: drivers/net/bnx2x/ecore_fw_defs.h:26: >+ (IRO[163].base + ((funcId) * IRO[163].m1)) > >CHECK:CAMELCASE: Avoid CamelCase: <hcIndex> >#199: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30: >+ (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * >+ IRO[143].m2)) > >CHECK:CAMELCASE: Avoid CamelCase: <sbId> >#199: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30: >+ (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * >+ IRO[143].m2)) > >CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) >#204: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32: >+ (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) >+ \ > ^ > >CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) >#204: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32: >+ (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) >+ \ > >CHECK:CAMELCASE: Avoid CamelCase: <iscsiEqId> > > > [65/1889] >#215: FILE: drivers/net/bnx2x/ecore_fw_defs.h:40: >+ (IRO[316].base + ((pfId) * IRO[316].m1) + ((iscsiEqId) * >+ IRO[316].m2)) > >CHECK:CAMELCASE: Avoid CamelCase: <vfId> >#287: FILE: drivers/net/bnx2x/ecore_fw_defs.h:87: >+#define CSTORM_VF_PF_CHANNEL_STATE_OFFSET(vfId) \ > >CHECK:CAMELCASE: Avoid CamelCase: <portId> >#368: FILE: drivers/net/bnx2x/ecore_fw_defs.h:142: >+ (IRO[187].base + ((portId) * IRO[187].m1)) > >CHECK:CAMELCASE: Avoid CamelCase: <clientId> >#414: FILE: drivers/net/bnx2x/ecore_fw_defs.h:172: >+ (IRO[215].base + ((portId) * IRO[215].m1) + ((clientId) * \ > >CHECK:CAMELCASE: Avoid CamelCase: <qzoneId> >#420: FILE: drivers/net/bnx2x/ecore_fw_defs.h:175: >+ (IRO[216].base + ((qzoneId) * IRO[216].m1)) > >CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) >#498: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241: >+ (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \ > ^ > >CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) >#498: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241: >+ (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \ > ^ > >CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) >#526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: >+ (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) > ^ > >CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) >#526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: >+ (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) > ^ > >CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) >#526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: >+ (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) > ^ > >CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) >#530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: >+#define U_ETH_SGES_PER_PAGE >(PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) > ^ > >CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) >#530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: >+#define U_ETH_SGES_PER_PAGE >(PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) > ^ > >CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) >#534: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276: >+#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1) > > > > > [16/1889] >CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) >#530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: >+#define U_ETH_SGES_PER_PAGE >(PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) > ^ > >CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) >#534: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276: >+#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1) > ^ > >CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) >#577: FILE: drivers/net/bnx2x/ecore_fw_defs.h:378: >+#define TSDM_TIMER_TICK_RESUL_CHIP (1 * (1e-6)) > ^ > >CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around >'r_order == MAX_RD_ORD' >#1119: FILE: drivers/net/bnx2x/ecore_init_ops.h:499: >+ if ((CHIP_IS_E1(sc) || CHIP_IS_E1H(sc)) && (r_order == >+ MAX_RD_ORD)) > >CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side- >effects? >#1537: FILE: drivers/net/bnx2x/ecore_sp.h:138: >+#define ECORE_ILT_ZALLOC(x, y, size) \ > do { \ > x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); >\ > if (x) { \ > if (bnx2x_dma_alloc((struct bnx2x_softc *)sc, \ > size, (struct bnx2x_dma *)x, \ >+ "ILT", RTE_CACHE_LINE_SIZE) != >+ 0) { \ > rte_free(x); \ > x = NULL; \ >+ *(y) = 0; \ > } else { \ > *y = ((struct bnx2x_dma *)x)->paddr; \ > } \ > >CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side- >effects? >#1537: FILE: drivers/net/bnx2x/ecore_sp.h:138: >+#define ECORE_ILT_ZALLOC(x, y, size) \ > do { \ > x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); >\ > if (x) { \ > if (bnx2x_dma_alloc((struct bnx2x_softc *)sc, \ > size, (struct bnx2x_dma *)x, \ >+ "ILT", RTE_CACHE_LINE_SIZE) != >+ 0) { \ > rte_free(x); \ > x = NULL; \ >+ *(y) = 0; \ > } else { \ > *y = ((struct bnx2x_dma *)x)->paddr; \ > } \ > >CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side- >effects? >#2191: FILE: drivers/net/bnx2x/ecore_sp.h:1967: >+#define PF_MAC_CREDIT_E2(sc, func_num) \ >+ ((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * >VF_MAC_CREDIT_CNT) / \ >+ (func_num) + GET_NUM_VFS_PER_PF(sc) * VF_MAC_CREDIT_CNT) > >CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side- >effects? > > >> >> doc/guides/nics/bnx2x.rst | 4 +- >> drivers/net/bnx2x/bnx2x.c | 63 +- >> drivers/net/bnx2x/bnx2x.h | 95 +- >> drivers/net/bnx2x/bnx2x_osal.h | 29 + >> drivers/net/bnx2x/bnx2x_rxtx.c | 10 +- >> drivers/net/bnx2x/ecore_fw_defs.h | 252 +- >> drivers/net/bnx2x/ecore_hsi.h | 3508 ++++++++------- >> drivers/net/bnx2x/ecore_init.h | 214 +- >> drivers/net/bnx2x/ecore_init_ops.h | 192 +- >> drivers/net/bnx2x/ecore_mfw_req.h | 11 +- >> drivers/net/bnx2x/ecore_reg.h | 6617 +++++++++++++++++++--------- >> drivers/net/bnx2x/ecore_sp.c | 48 +- >> drivers/net/bnx2x/ecore_sp.h | 308 +- >> 13 files changed, 7185 insertions(+), 4166 deletions(-) create mode >> 100644 drivers/net/bnx2x/bnx2x_osal.h >> >> -- >> 2.18.0 >>
On Thu, Oct 3, 2019 at 12:18 PM Rasesh Mody <rmody@marvell.com> wrote: > > >From: Jerin Jacob <jerinjacobk@gmail.com> > >Sent: Wednesday, October 02, 2019 10:57 PM > > > >On Thu, Oct 3, 2019 at 12:45 AM Rasesh Mody <rmody@marvell.com> wrote: > >> > >> Hi, > >> > >> Currently, BNX2X PMD uses a very old firmware 7.2.51. > >> This patch series updated the base driver to use to latest firmware > >> 7.13.11. The latest firmware comprises of enhancements and fixes. > >> > >> v3: > >> - Addressed gcc 9.2 build issues > >> v2: > >> - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11" > >> - Addressed most of checkpatch issues > >> > >> Thanks! > >> -Rasesh > >> > >> Rasesh Mody (3): > >> net/bnx2x: update and reorganize HW registers > >> net/bnx2x: update HSI code > >> net/bnx2x: update to latest FW 7.13.11 > > > >I don't think this patch comes as _base_ code, Please fix the trivial and > >genuine check path errors. > > These are base driver changes for updating the FW to latest. The remaining checkpatch issues in this patch set are to keep uniformity and readability of the base code. > Cleaning up base code to remove these and other checkpatch issues in same context would be a separate activity(as it would result in lot more changes), independent of this patch set. Next when there is such a checkpatch code cleanup, we'll try to address the issues. > > Please apply these changes or let me know if v4 is needed. Fixed WARNING:TYPO_SPELLING warning. Series applied to dpdk-next-net-mrvl/master. Thanks.