Message ID | 20200210103216.1168439-1-thomas@monjalon.net (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 326C0A052F; Mon, 10 Feb 2020 11:32:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 743B61BDF8; Mon, 10 Feb 2020 11:32:24 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 88A322BD5 for <dev@dpdk.org>; Mon, 10 Feb 2020 11:32:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1ECA821F4C; Mon, 10 Feb 2020 05:32:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 10 Feb 2020 05:32:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=cAbXfshREHepPqgHQwYXTX5 5BmXBZfbf6UrWxH5kxSA=; b=SP4NehLTtH+SQMuIx/8gLycPPMMf0RJ1HBn83cx QZ9PDvzcFctxltfctcCeITx+GoOEn91TEUYZkMyBizjbfQfNd+fEICEwrTLUuiJ/ ORcydaEpAB75muyaHlYFnzFkumnQzN/rXk5Q3K1zNRC6NTix4uQ/E3QfNovs4CaS qK34= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=cAbXfshREHepPqgHQ wYXTX55BmXBZfbf6UrWxH5kxSA=; b=GSG3TlI0zs9dFMmLM2EDYzMv4LlAgC/t0 MMIFa+G0LN88mbmF6TIp1sIIeOxPaHUxL2llTUnT2v1O95uM9wHDAmuAh4IkUeWq VI9wB3rGuJEO1GdF1j9xtd5y3hE2uq4UHlXedFm5CNLnB/fP/+D/i2a5DSDQx1WS Y1rWxSY7gB3x/Reir3trN+k9HA17ItaVQhrpdkCjoFSRDktOxnvEHjvoy6KpvYiy HDg7Q7P1CjFW1BwWyKgw7jk4wvCxRKSZFSAkdVTCfjWe8ERwLlS665CtwwAucli+ 1uzC7Vl1pMyzL0Nogy3FhEA3HudGs4eHRTVhsOozcDvuL7NCL1Kkw== X-ME-Sender: <xms:NjFBXt-aKXQ343IjF7jjet_ROtKno7TVtPrcjgYL-KSEkls7CCf83g> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedriedugdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertdertd dtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhn jhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhho nhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:NjFBXk9yGisMNcAJAjiBMsHk_O0XRszAx4k0qwEWM1nEAguTKBlzOw> <xmx:NjFBXvERWQlipGxtCWcIEu1mwYaMbSBOEIHFVIu3taKGYIulc4x9RQ> <xmx:NjFBXrdkwlEqytuxHuzOcRB-kPYABoEN5NtpL2Kop5TTPyQPweteUg> <xmx:NzFBXqjCi-g645E7S42KFar896ibMT-PqU1JJlNTAPzVOSlQQsA1qQ> Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3C5BF328005A for <dev@dpdk.org>; Mon, 10 Feb 2020 05:32:22 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Date: Mon, 10 Feb 2020 11:32:13 +0100 Message-Id: <20200210103216.1168439-1-thomas@monjalon.net> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/3] mlx: fix build with -fno-common (gcc 10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
mlx: fix build with -fno-common (gcc 10)
|
|
Message
Thomas Monjalon
Feb. 10, 2020, 10:32 a.m. UTC
In GCC 10, -fno-common will be the default. There are 2 ways of solving issues: - add -fcommon - stop allocating variables in .h files In this patchset, the variables are declared extern, because it is cleaner anyway. Thomas Monjalon (3): common/mlx5: split glue initialization common/mlx5: fix build with -fno-common net/mlx4: fix build with -fno-common drivers/common/mlx5/mlx5_common.c | 80 +++++++++++++++++++------------ drivers/common/mlx5/mlx5_glue.h | 2 +- drivers/net/mlx4/mlx4.c | 4 ++ drivers/net/mlx4/mlx4_glue.h | 2 +- drivers/net/mlx4/mlx4_rxtx.h | 2 +- 5 files changed, 57 insertions(+), 33 deletions(-)
Comments
From: Thomas Monjalon > In GCC 10, -fno-common will be the default. > There are 2 ways of solving issues: > - add -fcommon > - stop allocating variables in .h files > > In this patchset, the variables are declared extern, because it is cleaner > anyway. > > Series-acked-by: Matan Azrad <matan@mellanox.com> > Thomas Monjalon (3): > common/mlx5: split glue initialization > common/mlx5: fix build with -fno-common > net/mlx4: fix build with -fno-common > > drivers/common/mlx5/mlx5_common.c | 80 +++++++++++++++++++-------- > ---- > drivers/common/mlx5/mlx5_glue.h | 2 +- > drivers/net/mlx4/mlx4.c | 4 ++ > drivers/net/mlx4/mlx4_glue.h | 2 +- > drivers/net/mlx4/mlx4_rxtx.h | 2 +- > 5 files changed, 57 insertions(+), 33 deletions(-) > > -- > 2.25.0
17/03/2020 09:34, Matan Azrad: > From: Thomas Monjalon > > In GCC 10, -fno-common will be the default. > > There are 2 ways of solving issues: > > - add -fcommon > > - stop allocating variables in .h files > > > > In this patchset, the variables are declared extern, because it is cleaner > > anyway. > > Series-acked-by: Matan Azrad <matan@mellanox.com> > > > Thomas Monjalon (3): > > common/mlx5: split glue initialization > > common/mlx5: fix build with -fno-common > > net/mlx4: fix build with -fno-common It seems these patches are also fixing usage of glue dlopen with PMD as shared library. We should add Cc: stable@dpdk.org and identify a root cause.