From patchwork Thu Feb 18 21:11:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Renata Saiakhova X-Patchwork-Id: 87993 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03E63A054A; Thu, 18 Feb 2021 22:11:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EFA840040; Thu, 18 Feb 2021 22:11:56 +0100 (CET) Received: from FRA01-PR2-obe.outbound.protection.outlook.com (mail-eopbgr120118.outbound.protection.outlook.com [40.107.12.118]) by mails.dpdk.org (Postfix) with ESMTP id D68A44003D for ; Thu, 18 Feb 2021 22:11:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SaHfx0kWeQ2S1lvhPDYOjTZ/eQVA9m7amRu93jINRpvSDQtwdhwnCTMTbH/VkCAfexRl2XoHHcWJE0EfSlDYIzZktzpGiS12s2D5LMu6220kZMnN8mwvve2CXEmJbxI/0DPJdvRN4tagIzjJbM5zz36jZCU2mnP517vCvAKOf47e4TMnq4Ovrnf4Tv/m2spsL2YCQuHNlXrrPFmSGO9kSdMkBsEIa3RKMtSKj3TjhdDTDq+r7agL+YzJVzI8ufYQS+38SZk/MMO+ULSyrQZ6+IaBwGH+pTCxZd10ZWq61XbCO0P+HMzfHQmM820Ypx8DBk56OnecL9+anVxHicqjGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5WCqDRgBvhZhypQz25iV5MFf07n409sbig2x5cT8lNE=; b=dY5ugat3VTyJGAUIh4UNiqtukF/lQflrTdK1g9/+JHl7EoLlxs6Ay3g0Fx+QrrOuicJzmE0q1rkdfSyf5KY4/6hf0+dgJduhqYuABCqJzl2BhsfjlFjvDLsshi+hHkg8tVz8ieXyBF/LzT5aa39sdDaXzeqcV4zgkcoquTEsm9ZKkz7BiBR+GfheJjvUn4fMkXlvIobGbrdKmLiRMzLqZP8WF6SCSK7OMY6t/CjFo294OjNTmJh/5PvUl2jk3gl12fAs95fjmxG5a4JO+YDMLxL48lUKLV2UsoGuOSz+EajxP/SC7GOeG0NvcAH8ctx9G9SAC5+/UmhSXTHmKebN3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ekinops.com; dmarc=pass action=none header.from=ekinops.com; dkim=pass header.d=ekinops.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ekinops.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5WCqDRgBvhZhypQz25iV5MFf07n409sbig2x5cT8lNE=; b=B6X0MygAnNSZlQK4mIdJc2IgAHaa2Mz26MG2amLmTRgld3lzABHzINDe4MYHIH52w/s0LFIeWjDeQOrwcblK8+QZ9Q72/omr69BZ332pKk6mhQNW59NOwit3aBREg36VXUxPIM7cgiHybgMxTpFs0YQCPjlr4X95VKGfePeAL8M= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=ekinops.com; Received: from PAZP264MB1413.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:188::5) by PAZP264MB1142.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:189::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.36; Thu, 18 Feb 2021 21:11:54 +0000 Received: from PAZP264MB1413.FRAP264.PROD.OUTLOOK.COM ([fe80::88bd:6160:5403:acdf]) by PAZP264MB1413.FRAP264.PROD.OUTLOOK.COM ([fe80::88bd:6160:5403:acdf%6]) with mapi id 15.20.3846.042; Thu, 18 Feb 2021 21:11:54 +0000 From: Renata Saiakhova To: Cc: dev@dpdk.org, Renata Saiakhova Date: Thu, 18 Feb 2021 22:11:36 +0100 Message-Id: <20210218211137.32154-1-Renata.Saiakhova@ekinops.com> X-Mailer: git-send-email 2.17.2 X-Originating-IP: [91.183.184.98] X-ClientProxiedBy: AM0PR04CA0098.eurprd04.prod.outlook.com (2603:10a6:208:be::39) To PAZP264MB1413.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:188::5) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from renataOAB.oneaccess.intra (91.183.184.98) by AM0PR04CA0098.eurprd04.prod.outlook.com (2603:10a6:208:be::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27 via Frontend Transport; Thu, 18 Feb 2021 21:11:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 943e334d-632e-4ffc-683a-08d8d451d12a X-MS-TrafficTypeDiagnostic: PAZP264MB1142: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3oEhJlTFSgeGURdDiame2YbKc9qszw9nz+w5GYjJICPveOKRZtkOGg4pTw/xGCf0CsioRTjq0hOahOQ8CJZzdulWknGyebF7wAPSSnIHQz8j72n7cU1dlv1FcTSaG+EFeEbDvdIVfFcPUhtCv0Qh7T4ZxNetq51HLmwVwmOcE0Co/W4m0QtsII04YxutgjX8U5tIW3wTnojkumL9Ig8wfDU8XlFwD4pBSKCozSx2GunW7Eofd0tki7WqeTl9psUBJAWwxSFcjbRCkTjo77LfdfgBEmrbu5ZGSw4Lr1lX79iILTi6p0PjGH6Obd67TAZqUbU6Kq1fYSQNPmmsvPkzPQsJk8fLzcFDkr9UvBDp73HTh2NRGOGCDuiqzMK7pgzXyZAhtKAhFqeNmn0a2/8fVaG+EiPYstSeoLzkSnmykPIbqu1pSXHD4UEZa0IrFP6kd7Mjnk7f5sn2Y4QXDLGv/g7Ph+49AsJRxIR9rpTB+12C6yWqu5r5T1Q9DWN85E8dWVLvQjBBqQY4r/FOSSLWD7PO/9Ug0ox1wKdzPbnReKHg7AYBKkRFAUNubmf3X4lO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAZP264MB1413.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(376002)(39850400004)(366004)(346002)(136003)(396003)(6666004)(8676002)(956004)(8936002)(2906002)(83380400001)(4326008)(52116002)(2616005)(5660300002)(6512007)(316002)(1076003)(107886003)(109986005)(36756003)(86362001)(478600001)(26005)(66476007)(66556008)(66946007)(6506007)(16526019)(6486002)(186003)(266003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: f6MNOUZg5iDvP5Z/K6fJ1zlut+bArplpBK7eos//kuQ9vI98CjY1t9gqcwoG0Wca7ysAT10+5CD5V8uIiQNC8v2E1mnTPs7Uey3ri4BTw8nBmO9vmGRds503d2mX/pUBCCH5pjJTTQpchmZhUAXSmgAnVeSr2BJ7C2GSUMghB+LWVCC3BlkDVwfPEhqONeOXwgN5O4YLopc+vAVU8N78C6Z/QdOcD7UCee1LRpNa1fKVZaAGDiu8hQU67T60sVIFyPlCXrGTWUz7d1i0qb76tG6Ps70fYWOYawKpe/Rmi2e7gR7yPZ1qYyboR4C/6s+skeZB6o/+4QnSqRUAh5GLhGIGlCO73EmjriR0lJ0rKvbkuk4CyVl21BlpbLsLnOyINj6mBYBjnzOr614HFX9tUadaB9Z5opJVa+EgAp88eqND+EuAfZuXjRrh1kL83uD6eNiOuAWPT0GLqk17KphRyNfdbfUSEDXe9AkriJtI7FRAyUNsC6YrNUWn9NB7iMmYW4H5thGAf5DgFeNU240n5t3uuM6rbY+CJxf41riEcl2qw2YfI87L8AsLsk0IctbUcEj7WYizCN2muwmUYIhxyNVeZjYBjuChBDfsAFDcKs9kfQYJHTC5LeMdi4BN1QaCYp5gDfh6NrYbu8v/DMxrgg0y4SMIEnpiwTitkAEZhzniOk49FOMhnL91WOsF79Moo09g2UkyKQ8yLIpnKO0EB245pqrfGwXDEpiE2Lt3hDVmt6mRv1zOGCZ+x1W5DHIT X-OriginatorOrg: ekinops.com X-MS-Exchange-CrossTenant-Network-Message-Id: 943e334d-632e-4ffc-683a-08d8d451d12a X-MS-Exchange-CrossTenant-AuthSource: PAZP264MB1413.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2021 21:11:54.0886 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f57b78a6-c654-4771-a72f-837275f46179 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z99ay1bsRAo0oplWpj1ydVtOUXUuW/4AG/e8vQB2INrCxpS/L730OgMAzgod3sJLGkKmFQifQFpNecggmJ53oGWRzTwBkGfXOvxZeLasbII= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAZP264MB1142 Subject: [dpdk-dev] [PATCH v3 0/1] eal/interrupts: add synchronous wrapper around unregister X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For pci_vfio, while removing the device by rte_dev_remove(), pci_vfio_disable_notifier() will call rte_intr_callback_unregister(), which may return -EAGAIN, if an interrupt source (kernel) has some active callbacks right now. As a result, the callback (req notifier) can be never unregistered, and the corresponding descriptor (vfio_req_intr_handle.fd) can be never closed. The kernel will continuously try to notify the user space using req notifier, but as the device is already removed, in this case it even cannot find a bus for that device, the log is full of messages "EAL: Cannot find bus for device (XX:XX.X)" v3: * Subject line reworded v2: * Use only for pci-vfio in pci_vfio_disable_notifier() Renata Saiakhova (1): eal/interrupts: add synchronous wrapper around unregister drivers/bus/pci/linux/pci_vfio.c | 2 +- lib/librte_eal/freebsd/eal_interrupts.c | 12 ++++++++++++ lib/librte_eal/include/rte_interrupts.h | 25 +++++++++++++++++++++++++ lib/librte_eal/linux/eal_interrupts.c | 12 ++++++++++++ lib/librte_eal/version.map | 1 + 5 files changed, 51 insertions(+), 1 deletion(-)