[0/4] telemetry logging improvements and cleanup

  This set adds support for using the regular rte_log functions from the telemetry
library; avoiding circular dependencies by having EAL register the telemetry
library itself and then passing the required handles to that library as part of
the telemetry_init call.

Beyond this change, the other three patches are cleanups to ensure that all
internal functions are clearly separate from the public APIs. (Patches 3 & 4 may
be merged into a single one on apply, for I've kept them separate for now for
clarity).

Bruce Richardson (4):
  telemetry: use rte_log for logging
  telemetry: make the legacy registration function internal
  telemetry: create internal-only header file
  telemetry: move init function to internal header

 doc/guides/rel_notes/release_21_05.rst        |  5 ++
 lib/librte_eal/freebsd/eal.c                  | 12 +--
 lib/librte_eal/linux/eal.c                    | 12 +--
 lib/librte_metrics/rte_metrics_telemetry.c    |  2 +-
 lib/librte_telemetry/rte_telemetry.h          | 22 ------
 lib/librte_telemetry/telemetry.c              | 74 +++++++++----------
 ...elemetry_legacy.h => telemetry_internal.h} | 37 +++++++++-
 lib/librte_telemetry/telemetry_legacy.c       |  2 +-
 lib/librte_telemetry/version.map              |  2 +-
 9 files changed, 82 insertions(+), 86 deletions(-)
 rename lib/librte_telemetry/{rte_telemetry_legacy.h => telemetry_internal.h} (67%)

--
2.27.0
  

10/03/2021 18:24, Bruce Richardson:
> This set adds support for using the regular rte_log functions from the telemetry
> library; avoiding circular dependencies by having EAL register the telemetry
> library itself and then passing the required handles to that library as part of
> the telemetry_init call.
> 
> Beyond this change, the other three patches are cleanups to ensure that all
> internal functions are clearly separate from the public APIs. (Patches 3 & 4 may
> be merged into a single one on apply, for I've kept them separate for now for
> clarity).
> 
> Bruce Richardson (4):
>   telemetry: use rte_log for logging
>   telemetry: make the legacy registration function internal
>   telemetry: create internal-only header file
>   telemetry: move init function to internal header

Now that your patch "eal: fix querying DPDK version at runtime"
is in main branch, please could you rebase this series?
  

On Wed, Mar 24, 2021 at 10:11:55PM +0100, Thomas Monjalon wrote:
> 10/03/2021 18:24, Bruce Richardson:
> > This set adds support for using the regular rte_log functions from the telemetry
> > library; avoiding circular dependencies by having EAL register the telemetry
> > library itself and then passing the required handles to that library as part of
> > the telemetry_init call.
> > 
> > Beyond this change, the other three patches are cleanups to ensure that all
> > internal functions are clearly separate from the public APIs. (Patches 3 & 4 may
> > be merged into a single one on apply, for I've kept them separate for now for
> > clarity).
> > 
> > Bruce Richardson (4):
> >   telemetry: use rte_log for logging
> >   telemetry: make the legacy registration function internal
> >   telemetry: create internal-only header file
> >   telemetry: move init function to internal header
> 
> Now that your patch "eal: fix querying DPDK version at runtime"
> is in main branch, please could you rebase this series?
> 
Sure, will do.