Message ID | 20210313222217.18271-1-dmitry.kozliuk@gmail.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C1B9A00C2; Sat, 13 Mar 2021 23:22:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B09AC16087E; Sat, 13 Mar 2021 23:22:25 +0100 (CET) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id D576B16087A for <dev@dpdk.org>; Sat, 13 Mar 2021 23:22:24 +0100 (CET) Received: by mail-lf1-f44.google.com with SMTP id u4so51157294lfs.0 for <dev@dpdk.org>; Sat, 13 Mar 2021 14:22:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IC+qClROILUsfSdrGwqiXZbDHOtot5Tjf3Lz/HMGe0k=; b=LOa9PAjHXnmTIyju7fLFNfpx/uRZ/S+ZuLeqTg3+HwP0rTOgRL9jWgj0mNYpm42kJn LgCIkbQMuMNawmP5g6Bqo8ugxgXDqubwKvOdCGkjpzm4G+Dt03T88gefKqz3FkWh0A5W lCZf0ejBmfdcV4an2yoQW0eepTD6Jn4k+PXKuVSiuHtek8MJsQeejlZJr1lwHMMmgFvn KhBNl10/WFkimfjJs6bISAhPPCbvBkk7bENAxBnNn+aymXqMnGGWbE9L5iK5E0fGLbOn 4tA8H9Wm1Jp4fOJ2OneHGUO8LnDWZQlbv5pNELYCy1iqNlm1QRiQwdV6vfcBRX3WGIAv kn+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IC+qClROILUsfSdrGwqiXZbDHOtot5Tjf3Lz/HMGe0k=; b=q3Qb9c9zKAvw6LXNBySLooXlbCsGqCQ3+9WbMVVXaD0dQNv2eDE4e9dsJLybWqYB6J GbKDp65cqtN5A++IhXjRDRYtf/U16P6dNZ82LelfPMYrqeSCPDqrZewf9KC8CC4yHdxw KtaExMT9pgVhPI14VZDuwk5I/eqO0tl1vxpegD4BycDamXKZISUSpAQPscmTkc9iOoxL WbDN6zRv60fF6p6+UsX+rvFtUDVgEJKafpWl3gl337rk7XHVPoxxzORe1ydodY2VAsbv yLAm4i5iGzmeNYxBgf+lYB5AZUQsRLWA48qFnWUsHm9X+IH/BUWz1p27gI/PWGSnS+o2 HNYA== X-Gm-Message-State: AOAM530wjfBMkdCfl4XPu75Ss2ZDRIMfVnWWJS5l7XSRp0Ktxw+zk9vg 05IheWrozk7xXZmN/ILAwDkjmS0e3eDQqn9/ X-Google-Smtp-Source: ABdhPJxsvNMLtXQkygWOD7t2TsTJzlLp5mFYOn96MPVAidl4kS9pd+vVP62qFyrJzYbRqE4UN5ritA== X-Received: by 2002:a05:6512:1192:: with SMTP id g18mr3737844lfr.102.1615674144070; Sat, 13 Mar 2021 14:22:24 -0800 (PST) Received: from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id t200sm2176685lff.280.2021.03.13.14.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Mar 2021 14:22:23 -0800 (PST) From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> To: dev@dpdk.org Cc: Pallavi Kadam <pallavi.kadam@intel.com>, Dmitry Malloy <dmitrym@microsoft.com>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Tyler Retzlaff <roretzla@linux.microsoft.com>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> Date: Sun, 14 Mar 2021 01:22:12 +0300 Message-Id: <20210313222217.18271-1-dmitry.kozliuk@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210313025645.6034-1-dmitry.kozliuk@gmail.com> References: <20210313025645.6034-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 0/4] net: replace Windows networking shim X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
net: replace Windows networking shim
|
|
Message
Dmitry Kozlyuk
March 13, 2021, 10:22 p.m. UTC
Networking header shim in Windows EAL conflicts with system headers and tries to provide POSIX compatibility out of scope for DPDK. Remove dependency on POSIX headers from libraries supported on Windows, then replace shim with librte_net with workarounds. A proposed deprecation notice is assumed: http://patchwork.dpdk.org/project/dpdk/list/?series=15595 v3: Fix build on FreeBSD for real (CI). v2: Fix build on FreeBSD (CI). Depends-on: series-15513 ("eal/windows: do not expose POSIX symbols") Dmitry Kozlyuk (4): cmdline: remove POSIX dependency ethdev: remove POSIX dependency net/mlx5: remove POSIX dependency net: replace Windows networking shim drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_flow.c | 4 +-- drivers/net/mlx5/mlx5_flow.h | 4 +-- drivers/net/mlx5/mlx5_mac.c | 1 - examples/cmdline/commands.c | 1 - examples/cmdline/parse_obj_list.c | 2 -- lib/librte_cmdline/cmdline.c | 1 - lib/librte_cmdline/cmdline_parse.c | 2 -- lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 ---- lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 ---- lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +- lib/librte_eal/windows/include/arpa/inet.h | 30 ---------------- lib/librte_eal/windows/include/netinet/in.h | 38 -------------------- lib/librte_eal/windows/include/netinet/ip.h | 10 ------ lib/librte_eal/windows/include/sys/socket.h | 24 ------------- lib/librte_ethdev/rte_ethdev.c | 13 +++---- lib/librte_ethdev/rte_ethdev_core.h | 1 - lib/librte_net/rte_ether.h | 26 ++++++++++---- lib/librte_net/rte_ip.h | 18 ++++++++++ 19 files changed, 49 insertions(+), 142 deletions(-) delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h delete mode 100644 lib/librte_eal/windows/include/netinet/in.h delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h delete mode 100644 lib/librte_eal/windows/include/sys/socket.h
Comments
On 3/13/2021 10:22 PM, Dmitry Kozlyuk wrote: > Networking header shim in Windows EAL conflicts with system headers and > tries to provide POSIX compatibility out of scope for DPDK. > Remove dependency on POSIX headers from libraries supported on Windows, > then replace shim with librte_net with workarounds. > > A proposed deprecation notice is assumed: > http://patchwork.dpdk.org/project/dpdk/list/?series=15595 > > v3: Fix build on FreeBSD for real (CI). > v2: Fix build on FreeBSD (CI). > > Depends-on: series-15513 ("eal/windows: do not expose POSIX symbols") > > Dmitry Kozlyuk (4): > cmdline: remove POSIX dependency > ethdev: remove POSIX dependency > net/mlx5: remove POSIX dependency > net: replace Windows networking shim > Hi Dmitry, Have you seen the CI reported build errors: http://mails.dpdk.org/archives/test-report/2021-March/182361.html Briefly: ./lib/librte_net/rte_net.c:132:7: error: 'IPPROTO_GRE' undeclared ./lib/librte_net/rte_net.c:163:7: error: 'IPPROTO_IPIP' undeclared
> > > Hi Ferruh, > Have you seen the CI reported build errors: > http://mails.dpdk.org/archives/test-report/2021-March/182361.html > > Briefly: > ./lib/librte_net/rte_net.c:132:7: error: 'IPPROTO_GRE' undeclared > ./lib/librte_net/rte_net.c:163:7: error: 'IPPROTO_IPIP' undeclared > This is because CI doesn't apply patches in Depends-on. In this case, missing constants would be defined when RTE_BUILD_INTERNAL is defined (so that symbols are only visible to DPDK), and it is introduced by dependency series. >
On 3/13/2021 2:22 PM, Dmitry Kozlyuk wrote: > Networking header shim in Windows EAL conflicts with system headers and > tries to provide POSIX compatibility out of scope for DPDK. > Remove dependency on POSIX headers from libraries supported on Windows, > then replace shim with librte_net with workarounds. > > A proposed deprecation notice is assumed: > http://patchwork.dpdk.org/project/dpdk/list/?series=15595 > > v3: Fix build on FreeBSD for real (CI). > v2: Fix build on FreeBSD (CI). > > Depends-on: series-15513 ("eal/windows: do not expose POSIX symbols") > > Dmitry Kozlyuk (4): > cmdline: remove POSIX dependency > ethdev: remove POSIX dependency > net/mlx5: remove POSIX dependency > net: replace Windows networking shim > > drivers/net/mlx5/mlx5.h | 2 +- > drivers/net/mlx5/mlx5_flow.c | 4 +-- > drivers/net/mlx5/mlx5_flow.h | 4 +-- > drivers/net/mlx5/mlx5_mac.c | 1 - > examples/cmdline/commands.c | 1 - > examples/cmdline/parse_obj_list.c | 2 -- > lib/librte_cmdline/cmdline.c | 1 - > lib/librte_cmdline/cmdline_parse.c | 2 -- > lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 ---- > lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 ---- > lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +- > lib/librte_eal/windows/include/arpa/inet.h | 30 ---------------- > lib/librte_eal/windows/include/netinet/in.h | 38 -------------------- > lib/librte_eal/windows/include/netinet/ip.h | 10 ------ > lib/librte_eal/windows/include/sys/socket.h | 24 ------------- > lib/librte_ethdev/rte_ethdev.c | 13 +++---- > lib/librte_ethdev/rte_ethdev_core.h | 1 - > lib/librte_net/rte_ether.h | 26 ++++++++++---- > lib/librte_net/rte_ip.h | 18 ++++++++++ > 19 files changed, 49 insertions(+), 142 deletions(-) > delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h > delete mode 100644 lib/librte_eal/windows/include/netinet/in.h > delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h > delete mode 100644 lib/librte_eal/windows/include/sys/socket.h > Acked-by: Ranjit Menon <ranjit.menon@intel.com>