mbox series

[v2,0/4] telemetry logging improvements and cleanup

Message ID 20210325135707.325536-1-bruce.richardson@intel.com (mailing list archive)
Headers
Series telemetry logging improvements and cleanup |

Message

Bruce Richardson March 25, 2021, 1:57 p.m. UTC 
  This set adds support for using the regular rte_log functions from the telemetry
library; avoiding circular dependencies by having EAL register the telemetry
library itself and then passing the required handles to that library as part of
the telemetry_init call.

Beyond this change, the other three patches are cleanups to ensure that all
internal functions are clearly separate from the public APIs. (Patches 3 & 4 may
be merged into a single one on apply, for I've kept them separate for now for
clarity).

V2: Rebased on latest main branch.

Bruce Richardson (4):
  telemetry: use rte_log for logging
  telemetry: make the legacy registration function internal
  telemetry: rename internal-only header file
  telemetry: move init function to internal header

 doc/guides/rel_notes/release_21_05.rst        |  5 ++
 lib/librte_eal/freebsd/eal.c                  | 12 +--
 lib/librte_eal/linux/eal.c                    | 12 +--
 lib/librte_metrics/rte_metrics_telemetry.c    |  2 +-
 lib/librte_telemetry/rte_telemetry.h          | 25 ------
 lib/librte_telemetry/telemetry.c              | 76 +++++++++----------
 ...elemetry_legacy.h => telemetry_internal.h} | 41 +++++++++-
 lib/librte_telemetry/telemetry_legacy.c       |  2 +-
 lib/librte_telemetry/version.map              |  2 +-
 9 files changed, 87 insertions(+), 90 deletions(-)
 rename lib/librte_telemetry/{rte_telemetry_legacy.h => telemetry_internal.h} (65%)

--
2.27.0

Comments

Thomas Monjalon March 25, 2021, 4:36 p.m. UTC | #1 
25/03/2021 14:57, Bruce Richardson:
> This set adds support for using the regular rte_log functions from the telemetry
> library; avoiding circular dependencies by having EAL register the telemetry
> library itself and then passing the required handles to that library as part of
> the telemetry_init call.
> 
> Beyond this change, the other three patches are cleanups to ensure that all
> internal functions are clearly separate from the public APIs. (Patches 3 & 4 may
> be merged into a single one on apply, for I've kept them separate for now for
> clarity).
> 
> V2: Rebased on latest main branch.
> 
> Bruce Richardson (4):
>   telemetry: use rte_log for logging
>   telemetry: make the legacy registration function internal
>   telemetry: rename internal-only header file
>   telemetry: move init function to internal header

Applied, thanks.