mbox series

[v5,0/4] improve options help

Message ID 20210405193954.1115838-1-thomas@monjalon.net (mailing list archive)
Headers
Series improve options help |

Message

Thomas Monjalon April 5, 2021, 7:39 p.m. UTC 
  After v4, this series is split in several parts.
The remaining 4 patches of this series are low priority.

Patches 1 and 3 are simple improvements.

Patches 2 and 4 lead to a new formatting of the usage text.
It is a matter of taste and should be discussed more.

v5: no change

Thomas Monjalon (4):
  eal: explain argv behaviour during init
  eal: improve options usage text
  eal: use macros for help option
  app: hook in EAL usage help

 app/pdump/main.c                                 |  2 ++
 app/proc-info/main.c                             |  2 ++
 app/test-acl/main.c                              |  2 ++
 app/test-bbdev/main.c                            |  3 ++-
 app/test-compress-perf/comp_perf_options.h       |  2 ++
 app/test-compress-perf/comp_perf_options_parse.c |  8 ++++----
 app/test-compress-perf/main.c                    |  3 ++-
 app/test-crypto-perf/cperf_options.h             |  2 ++
 app/test-crypto-perf/cperf_options_parsing.c     |  8 ++++----
 app/test-crypto-perf/main.c                      |  3 ++-
 app/test-fib/main.c                              |  8 ++++++++
 app/test-flow-perf/main.c                        |  4 +++-
 app/test-pmd/parameters.c                        |  4 ++--
 app/test-pmd/testpmd.c                           |  2 ++
 app/test-pmd/testpmd.h                           |  1 +
 app/test-regex/main.c                            |  3 ++-
 app/test-sad/main.c                              |  7 +++++++
 lib/librte_eal/common/eal_common_options.c       | 13 ++++++-------
 lib/librte_eal/freebsd/eal.c                     | 10 +++++-----
 lib/librte_eal/include/rte_eal.h                 |  2 ++
 lib/librte_eal/linux/eal.c                       | 14 +++++++-------
 lib/librte_eal/windows/eal.c                     | 12 +++++-------
 22 files changed, 74 insertions(+), 41 deletions(-)

Comments

Stephen Hemminger June 29, 2023, 4:27 p.m. UTC | #1 
On Mon,  5 Apr 2021 21:39:50 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> After v4, this series is split in several parts.
> The remaining 4 patches of this series are low priority.
> 
> Patches 1 and 3 are simple improvements.
> 
> Patches 2 and 4 lead to a new formatting of the usage text.
> It is a matter of taste and should be discussed more.
> 
> v5: no change
> 
> Thomas Monjalon (4):
>   eal: explain argv behaviour during init
>   eal: improve options usage text
>   eal: use macros for help option
>   app: hook in EAL usage help
> 
>  app/pdump/main.c                                 |  2 ++
>  app/proc-info/main.c                             |  2 ++
>  app/test-acl/main.c                              |  2 ++
>  app/test-bbdev/main.c                            |  3 ++-
>  app/test-compress-perf/comp_perf_options.h       |  2 ++
>  app/test-compress-perf/comp_perf_options_parse.c |  8 ++++----
>  app/test-compress-perf/main.c                    |  3 ++-
>  app/test-crypto-perf/cperf_options.h             |  2 ++
>  app/test-crypto-perf/cperf_options_parsing.c     |  8 ++++----
>  app/test-crypto-perf/main.c                      |  3 ++-
>  app/test-fib/main.c                              |  8 ++++++++
>  app/test-flow-perf/main.c                        |  4 +++-
>  app/test-pmd/parameters.c                        |  4 ++--
>  app/test-pmd/testpmd.c                           |  2 ++
>  app/test-pmd/testpmd.h                           |  1 +
>  app/test-regex/main.c                            |  3 ++-
>  app/test-sad/main.c                              |  7 +++++++
>  lib/librte_eal/common/eal_common_options.c       | 13 ++++++-------
>  lib/librte_eal/freebsd/eal.c                     | 10 +++++-----
>  lib/librte_eal/include/rte_eal.h                 |  2 ++
>  lib/librte_eal/linux/eal.c                       | 14 +++++++-------
>  lib/librte_eal/windows/eal.c                     | 12 +++++-------
>  22 files changed, 74 insertions(+), 41 deletions(-)
> 

Thomas, this patchset seems ready but never made it in.
What is best disposition for it:
  1. Rebase and resubmit?
  2. I could add it to the log patch series WIP?
  3. Drop it since old?
Thomas Monjalon July 6, 2023, 8:29 a.m. UTC | #2 
29/06/2023 18:27, Stephen Hemminger:
> On Mon,  5 Apr 2021 21:39:50 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > After v4, this series is split in several parts.
> > The remaining 4 patches of this series are low priority.
> > 
> > Patches 1 and 3 are simple improvements.
> > 
> > Patches 2 and 4 lead to a new formatting of the usage text.
> > It is a matter of taste and should be discussed more.
> > 
> > v5: no change
> > 
> > Thomas Monjalon (4):
> >   eal: explain argv behaviour during init
> >   eal: improve options usage text
> >   eal: use macros for help option
> >   app: hook in EAL usage help
> 
> Thomas, this patchset seems ready but never made it in.
> What is best disposition for it:
>   1. Rebase and resubmit?
>   2. I could add it to the log patch series WIP?
>   3. Drop it since old?

I've applied the patches 1 and 3 that you acked.

I let you revisit the patches 2 and 4 if you wish.
Stephen Hemminger July 6, 2023, 2:44 p.m. UTC | #3 
On Thu, 06 Jul 2023 10:29:04 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 29/06/2023 18:27, Stephen Hemminger:
> > On Mon,  5 Apr 2021 21:39:50 +0200
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> >   
> > > After v4, this series is split in several parts.
> > > The remaining 4 patches of this series are low priority.
> > > 
> > > Patches 1 and 3 are simple improvements.
> > > 
> > > Patches 2 and 4 lead to a new formatting of the usage text.
> > > It is a matter of taste and should be discussed more.
> > > 
> > > v5: no change
> > > 
> > > Thomas Monjalon (4):
> > >   eal: explain argv behaviour during init
> > >   eal: improve options usage text
> > >   eal: use macros for help option
> > >   app: hook in EAL usage help  
> > 
> > Thomas, this patchset seems ready but never made it in.
> > What is best disposition for it:
> >   1. Rebase and resubmit?
> >   2. I could add it to the log patch series WIP?
> >   3. Drop it since old?  
> 
> I've applied the patches 1 and 3 that you acked.
> 
> I let you revisit the patches 2 and 4 if you wish.

Thanks. Trying to reach 500 patches by 23.08 release.
Thomas Monjalon July 6, 2023, 3:53 p.m. UTC | #4 
06/07/2023 16:44, Stephen Hemminger:
> Trying to reach 500 patches by 23.08 release.

Impossible. It is 23.07 :)