Message ID | 20210406093048.2923172-1-jiawenwu@trustnetic.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BAD4A0A02; Tue, 6 Apr 2021 11:31:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B714414102C; Tue, 6 Apr 2021 11:30:47 +0200 (CEST) Received: from smtpbg506.qq.com (smtpbg506.qq.com [203.205.250.33]) by mails.dpdk.org (Postfix) with ESMTP id 094A5406A2 for <dev@dpdk.org>; Tue, 6 Apr 2021 11:30:40 +0200 (CEST) X-QQ-mid: bizesmtp13t1617701435telwl3xz Received: from wxdbg.localdomain.com (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Tue, 06 Apr 2021 17:29:39 +0800 (CST) X-QQ-SSF: 01400000000000D0E000B00A0000000 X-QQ-FEAT: YKCDl5A3/aqyohGnlRmTVl2Z8NLH5aM3zSUUTwYNXtg/Hqpp7SgVLQPKwSZCp r6FfL3cnt5DTO/h3FMmLygleZgMnZndeGcmoW4XDkGiCX7DhWz/KPyPMG/ySghqjd5Rt6cg Mle8QYRDmZSvZCPLfbd2FwYehafpIwsFlF2z0GoF9cVse4O9BYCjmh2x/Lnjeepa6juKdIE WAVvSpdUFzxPqArW8orw59P6H8AlwQFqgmPvjXx8Aj2ziMA0qPmWGab/K4mTLRd2o2u0zRo ZA5a+7VGPMeCkcMa7l49nlpAUyEFG6Y28vapFqD2Av0sRldUT7Kny1Ruckjg4kZ6dM95hTo D2Nvjuf X-QQ-GoodBg: 2 From: Jiawen Wu <jiawenwu@trustnetic.com> To: dev@dpdk.org Cc: Jiawen Wu <jiawenwu@trustnetic.com> Date: Tue, 6 Apr 2021 17:30:42 +0800 Message-Id: <20210406093048.2923172-1-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign7 X-QQ-Bgrelay: 1 Subject: [dpdk-dev] [PATCH v4 0/6] net: ngbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | net: ngbe PMD | |
Message
Jiawen Wu
April 6, 2021, 9:30 a.m. UTC
This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun WX1860 series NICs. v4: - Fix compile error. v3: - Use rte_ether functions to define marcos. v2: - Correct some clerical errors. - Use ethdev debug flags instead of driver own. Jiawen Wu (6): net/ngbe: add build and doc infrastructure net/ngbe: add device IDs net/ngbe: support probe and remove net/ngbe: add device init and uninit net/ngbe: add log type and error type net/ngbe: define registers MAINTAINERS | 6 + doc/guides/nics/features/ngbe.ini | 11 + doc/guides/nics/index.rst | 1 + doc/guides/nics/ngbe.rst | 48 + doc/guides/rel_notes/release_21_05.rst | 6 + drivers/net/meson.build | 1 + drivers/net/ngbe/base/meson.build | 20 + drivers/net/ngbe/base/ngbe.h | 11 + drivers/net/ngbe/base/ngbe_devids.h | 83 ++ drivers/net/ngbe/base/ngbe_hw.c | 59 + drivers/net/ngbe/base/ngbe_hw.h | 12 + drivers/net/ngbe/base/ngbe_osdep.h | 174 +++ drivers/net/ngbe/base/ngbe_regs.h | 1489 ++++++++++++++++++++++++ drivers/net/ngbe/base/ngbe_status.h | 124 ++ drivers/net/ngbe/base/ngbe_type.h | 30 + drivers/net/ngbe/meson.build | 18 + drivers/net/ngbe/ngbe_ethdev.c | 156 +++ drivers/net/ngbe/ngbe_ethdev.h | 21 + drivers/net/ngbe/ngbe_logs.h | 45 + drivers/net/ngbe/version.map | 3 + 20 files changed, 2318 insertions(+) create mode 100644 doc/guides/nics/features/ngbe.ini create mode 100644 doc/guides/nics/ngbe.rst create mode 100644 drivers/net/ngbe/base/meson.build create mode 100644 drivers/net/ngbe/base/ngbe.h create mode 100644 drivers/net/ngbe/base/ngbe_devids.h create mode 100644 drivers/net/ngbe/base/ngbe_hw.c create mode 100644 drivers/net/ngbe/base/ngbe_hw.h create mode 100644 drivers/net/ngbe/base/ngbe_osdep.h create mode 100644 drivers/net/ngbe/base/ngbe_regs.h create mode 100644 drivers/net/ngbe/base/ngbe_status.h create mode 100644 drivers/net/ngbe/base/ngbe_type.h create mode 100644 drivers/net/ngbe/meson.build create mode 100644 drivers/net/ngbe/ngbe_ethdev.c create mode 100644 drivers/net/ngbe/ngbe_ethdev.h create mode 100644 drivers/net/ngbe/ngbe_logs.h create mode 100644 drivers/net/ngbe/version.map
Comments
On 4/6/2021 10:30 AM, Jiawen Wu wrote: > This patch set provides a skeleton of ngbe PMD, > which adapted to Wangxun WX1860 series NICs. > > v4: > - Fix compile error. > > v3: > - Use rte_ether functions to define marcos. > > v2: > - Correct some clerical errors. > - Use ethdev debug flags instead of driver own. > > Jiawen Wu (6): > net/ngbe: add build and doc infrastructure > net/ngbe: add device IDs > net/ngbe: support probe and remove > net/ngbe: add device init and uninit > net/ngbe: add log type and error type > net/ngbe: define registers > Hi Jiawen, I put some comments on some patches, but as far as I can see the device is not functional yet after this set, I assume rest of the support will be submitted later. But I think the device should have at least bare minimum functionality when it is upstreamed, like proper device initialization and primitive Rx/Tx, also it would be good to have basic control functions. More control and datapath functionality can be added gradually later. What do you think extending this set to have base minimum functionality? Thanks, ferruh
On Friday, April 9, 2021 10:47 PM, Ferruh Yigit wrote: > On 4/6/2021 10:30 AM, Jiawen Wu wrote: > > This patch set provides a skeleton of ngbe PMD, which adapted to > > Wangxun WX1860 series NICs. > > > > v4: > > - Fix compile error. > > > > v3: > > - Use rte_ether functions to define marcos. > > > > v2: > > - Correct some clerical errors. > > - Use ethdev debug flags instead of driver own. > > > > Jiawen Wu (6): > > net/ngbe: add build and doc infrastructure > > net/ngbe: add device IDs > > net/ngbe: support probe and remove > > net/ngbe: add device init and uninit > > net/ngbe: add log type and error type > > net/ngbe: define registers > > > > Hi Jiawen, > > I put some comments on some patches, but as far as I can see the device is not > functional yet after this set, I assume rest of the support will be submitted > later. > But I think the device should have at least bare minimum functionality when it > is upstreamed, like proper device initialization and primitive Rx/Tx, also it would > be good to have basic control functions. > More control and datapath functionality can be added gradually later. > > What do you think extending this set to have base minimum functionality? > > Thanks, > ferruh Hi Ferruh, Unfortunately, this driver may not be merged in 21.05, to follow the roadmap. There is not enough time for me to improve the patches, because I was busy with other works in these weeks. I'll try my best to submit the driver in this release cycle, and hope it will be merged nicely in next release. Thanks.
On 4/29/2021 11:52 AM, Jiawen Wu wrote: > On Friday, April 9, 2021 10:47 PM, Ferruh Yigit wrote: >> On 4/6/2021 10:30 AM, Jiawen Wu wrote: >>> This patch set provides a skeleton of ngbe PMD, which adapted to >>> Wangxun WX1860 series NICs. >>> >>> v4: >>> - Fix compile error. >>> >>> v3: >>> - Use rte_ether functions to define marcos. >>> >>> v2: >>> - Correct some clerical errors. >>> - Use ethdev debug flags instead of driver own. >>> >>> Jiawen Wu (6): >>> net/ngbe: add build and doc infrastructure >>> net/ngbe: add device IDs >>> net/ngbe: support probe and remove >>> net/ngbe: add device init and uninit >>> net/ngbe: add log type and error type >>> net/ngbe: define registers >>> >> >> Hi Jiawen, >> >> I put some comments on some patches, but as far as I can see the device is not >> functional yet after this set, I assume rest of the support will be submitted >> later. >> But I think the device should have at least bare minimum functionality when it >> is upstreamed, like proper device initialization and primitive Rx/Tx, also it would >> be good to have basic control functions. >> More control and datapath functionality can be added gradually later. >> >> What do you think extending this set to have base minimum functionality? >> >> Thanks, >> ferruh > > Hi Ferruh, > > Unfortunately, this driver may not be merged in 21.05, to follow the roadmap. > There is not enough time for me to improve the patches, because I was busy with other works in these weeks. > > I'll try my best to submit the driver in this release cycle, and hope it will be merged nicely in next release. > That is OK, thanks for heads up.