From patchwork Fri Jun 18 13:57:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 94502 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80DC3A0C46; Fri, 18 Jun 2021 15:57:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05A6940150; Fri, 18 Jun 2021 15:57:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id E81EA40142 for ; Fri, 18 Jun 2021 15:57:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624024666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h7NPEcbZq3YfNS+aPJbtOvC0/+hBgy3bt9zrG7Q/R2o=; b=YMmz0YItbokhpnD8Ei34o1q+p5Im860TilvnHdGFa+eF1hyQ2wBf/YJ+58zZBm5gHAerSG EEI45v+2TxiiRhc4FFRXqBBTGKGD8/lHGtJREK0LurkqQD8YUzoi/1ZEgjciqStxxBk397 oo4YHWg8iVJP2XwoPBo/2un2jjtg9ks= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-537-Bkz3-mc0Pce_Uj_3j09Pig-1; Fri, 18 Jun 2021 09:57:45 -0400 X-MC-Unique: Bkz3-mc0Pce_Uj_3j09Pig-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB799824F89; Fri, 18 Jun 2021 13:57:44 +0000 (UTC) Received: from max-t490s.redhat.com (unknown [10.36.110.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC75D60BE5; Fri, 18 Jun 2021 13:57:37 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com Cc: Maxime Coquelin Date: Fri, 18 Jun 2021 15:57:31 +0200 Message-Id: <20210618135735.253770-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH v5 0/4] vhost: Fix and improve NUMA reallocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch series first fixes missing reallocations of some Virtqueue and device metadata. Then, it improves the numa_realloc function by using rte_realloc_socket API that takes care of the memcpy & freeing. The VQs NUMA IDs are also saved in the VQ metadata and used for every allocations so that all allocations before NUMA realloc are on the same VQ, later ones are allocated on the proper one. Finally inflight feature metada are converted from calloc() to rte_zmalloc_socket() and their reallocation is handled in numa_realloc(). Changes in v5: ============== - Do not reallocate if VS is ready (Chenbo) - Fix typos & cosmetics (Chenbo) - Improve numa_realloc() comment (Chenbo) Changes in v4: ============== - Check Vhose device numa node to avoid rte_realloc_socket to realloc even if already right node/size/align. Changes in v3: ============== - Fix copy/paste issues (David) - Ad new patch to fix multiqueue reallocation Changes in v2: ============== - Add missing NUMA realloc in patch 6 Maxime Coquelin (4): vhost: fix missing memory table NUMA realloc vhost: fix missing guest pages table NUMA realloc vhost: fix missing cache logging NUMA realloc vhost: fix NUMA reallocation with multiqueue lib/vhost/vhost_user.c | 54 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 49 insertions(+), 5 deletions(-)