mbox series

[v5,0/3] net/i40e: remove i40evf

Message ID 20210915030959.59245-1-robinx.zhang@intel.com (mailing list archive)
Headers
Series net/i40e: remove i40evf |

Message

Robin Zhang Sept. 15, 2021, 3:09 a.m. UTC 
  In DPDK 21.05, iavf already became the default VF for i40e devices.
So remove i40evf due to it's no need to maintain now.

v5:
- rebase code.

v4:
- resolve compile warning issue.

v3:
- remove VF related code in i40e_rxtx.c.

v2:
- update 21.11 release note, remove some missed documentation.

Robin Zhang (3):
  net/i40e: remove i40evf
  net/iavf: remove i40evf devargs option
  doc: remove i40evf related documentation

 doc/guides/howto/lm_bond_virtio_sriov.rst |    4 +-
 doc/guides/nics/intel_vf.rst              |    8 +-
 doc/guides/rel_notes/deprecation.rst      |    8 -
 doc/guides/rel_notes/release_21_11.rst    |    2 +
 drivers/net/i40e/i40e_ethdev.h            |    1 -
 drivers/net/i40e/i40e_ethdev_vf.c         | 3006 ---------------------
 drivers/net/i40e/i40e_rxtx.c              |   50 +-
 drivers/net/i40e/meson.build              |    1 -
 drivers/net/i40e/rte_pmd_i40e.c           |    9 +-
 drivers/net/iavf/iavf_ethdev.c            |   52 +-
 10 files changed, 26 insertions(+), 3115 deletions(-)
 delete mode 100644 drivers/net/i40e/i40e_ethdev_vf.c

Comments

Qi Zhang Sept. 15, 2021, 4:03 a.m. UTC | #1 
> -----Original Message-----
> From: Zhang, RobinX <robinx.zhang@intel.com>
> Sent: Wednesday, September 15, 2021 11:10 AM
> To: dev@dpdk.org
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; mdr@ashroe.eu; Wu, Jingjing
> <jingjing.wu@intel.com>; Burakov, Anatoly <anatoly.burakov@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>;
> Yang, SteveX <stevex.yang@intel.com>; Zhang, RobinX
> <robinx.zhang@intel.com>
> Subject: [PATCH v5 0/3] net/i40e: remove i40evf
> 
> In DPDK 21.05, iavf already became the default VF for i40e devices.
> So remove i40evf due to it's no need to maintain now.
> 
> v5:
> - rebase code.
> 
> v4:
> - resolve compile warning issue.
> 
> v3:
> - remove VF related code in i40e_rxtx.c.
> 
> v2:
> - update 21.11 release note, remove some missed documentation.
> 
> Robin Zhang (3):
>   net/i40e: remove i40evf
>   net/iavf: remove i40evf devargs option
>   doc: remove i40evf related documentation
> 
>  doc/guides/howto/lm_bond_virtio_sriov.rst |    4 +-
>  doc/guides/nics/intel_vf.rst              |    8 +-
>  doc/guides/rel_notes/deprecation.rst      |    8 -
>  doc/guides/rel_notes/release_21_11.rst    |    2 +
>  drivers/net/i40e/i40e_ethdev.h            |    1 -
>  drivers/net/i40e/i40e_ethdev_vf.c         | 3006 ---------------------
>  drivers/net/i40e/i40e_rxtx.c              |   50 +-
>  drivers/net/i40e/meson.build              |    1 -
>  drivers/net/i40e/rte_pmd_i40e.c           |    9 +-
>  drivers/net/iavf/iavf_ethdev.c            |   52 +-
>  10 files changed, 26 insertions(+), 3115 deletions(-)  delete mode 100644
> drivers/net/i40e/i40e_ethdev_vf.c
> 
> --
> 2.25.1

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
Ferruh Yigit Sept. 16, 2021, 4:27 p.m. UTC | #2 
On 9/15/2021 4:09 AM, Robin Zhang wrote:
> In DPDK 21.05, iavf already became the default VF for i40e devices.
> So remove i40evf due to it's no need to maintain now.
> 
> v5:
> - rebase code.
> 
> v4:
> - resolve compile warning issue.
> 
> v3:
> - remove VF related code in i40e_rxtx.c.
> 
> v2:
> - update 21.11 release note, remove some missed documentation.
> 
> Robin Zhang (3):
>   net/i40e: remove i40evf
>   net/iavf: remove i40evf devargs option
>   doc: remove i40evf related documentation
> 

Just to double check, searching 'i40evf' within driver still yields some results
[1]. Is this expected? Why they should remain?


Thanks,
ferruh


[1]
git grep -i i40evf drivers/net/
Robin Zhang Sept. 17, 2021, 1:55 a.m. UTC | #3 
Hi, Ferruh

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Friday, September 17, 2021 12:28 AM
> To: Zhang, RobinX <robinx.zhang@intel.com>; dev@dpdk.org
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; mdr@ashroe.eu; Wu, Jingjing
> <jingjing.wu@intel.com>; Burakov, Anatoly <anatoly.burakov@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>;
> Yang, SteveX <stevex.yang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5 0/3] net/i40e: remove i40evf
> 
> On 9/15/2021 4:09 AM, Robin Zhang wrote:
> > In DPDK 21.05, iavf already became the default VF for i40e devices.
> > So remove i40evf due to it's no need to maintain now.
> >
> > v5:
> > - rebase code.
> >
> > v4:
> > - resolve compile warning issue.
> >
> > v3:
> > - remove VF related code in i40e_rxtx.c.
> >
> > v2:
> > - update 21.11 release note, remove some missed documentation.
> >
> > Robin Zhang (3):
> >   net/i40e: remove i40evf
> >   net/iavf: remove i40evf devargs option
> >   doc: remove i40evf related documentation
> >
> 
> Just to double check, searching 'i40evf' within driver still yields some results
> [1]. Is this expected? Why they should remain?

git grep -i i40evf drivers/net/:

i40e/base/i40e_osdep.h:#define I40EVF_WRITE_FLUSH(a) I40E_READ_REG(a, I40E_VFGEN_RSTAT)
	This macro is defined in i40e share code.

i40e/i40e_ethdev.h:/* I40EVF_DEV_PRIVATE_TO */
i40e/i40e_ethdev.h:#define I40EVF_DEV_PRIVATE_TO_VF(adapter) \
i40e/i40e_ethdev.h:             struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(adapter);
	This is a helper function "i40e_get_vsi_from_adapter", we still keep the i40e_vf member in i40e_adapter structure for some future possibilities.

i40e/i40e_vf_representor.c:i40evf_stat_update_48(uint64_t *offset,
i40e/i40e_vf_representor.c:i40evf_stat_update_32(uint64_t *offset,
i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
	These are ops for VF representor ports of i40e

> 
> 
> Thanks,
> ferruh
> 
> 
> [1]
> git grep -i i40evf drivers/net/
Ferruh Yigit Sept. 17, 2021, 8:05 a.m. UTC | #4 
On 9/17/2021 2:55 AM, Zhang, RobinX wrote:
> Hi, Ferruh
> 
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Friday, September 17, 2021 12:28 AM
>> To: Zhang, RobinX <robinx.zhang@intel.com>; dev@dpdk.org
>> Cc: Wang, Haiyue <haiyue.wang@intel.com>; Xing, Beilei
>> <beilei.xing@intel.com>; mdr@ashroe.eu; Wu, Jingjing
>> <jingjing.wu@intel.com>; Burakov, Anatoly <anatoly.burakov@intel.com>;
>> Zhang, Qi Z <qi.z.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>;
>> Yang, SteveX <stevex.yang@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v5 0/3] net/i40e: remove i40evf
>>
>> On 9/15/2021 4:09 AM, Robin Zhang wrote:
>>> In DPDK 21.05, iavf already became the default VF for i40e devices.
>>> So remove i40evf due to it's no need to maintain now.
>>>
>>> v5:
>>> - rebase code.
>>>
>>> v4:
>>> - resolve compile warning issue.
>>>
>>> v3:
>>> - remove VF related code in i40e_rxtx.c.
>>>
>>> v2:
>>> - update 21.11 release note, remove some missed documentation.
>>>
>>> Robin Zhang (3):
>>>   net/i40e: remove i40evf
>>>   net/iavf: remove i40evf devargs option
>>>   doc: remove i40evf related documentation
>>>
>>
>> Just to double check, searching 'i40evf' within driver still yields some results
>> [1]. Is this expected? Why they should remain?
> 
> git grep -i i40evf drivers/net/:
> 
> i40e/base/i40e_osdep.h:#define I40EVF_WRITE_FLUSH(a) I40E_READ_REG(a, I40E_VFGEN_RSTAT)
> 	This macro is defined in i40e share code.
> 
> i40e/i40e_ethdev.h:/* I40EVF_DEV_PRIVATE_TO */
> i40e/i40e_ethdev.h:#define I40EVF_DEV_PRIVATE_TO_VF(adapter) \
> i40e/i40e_ethdev.h:             struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(adapter);
> 	This is a helper function "i40e_get_vsi_from_adapter", we still keep the i40e_vf member in i40e_adapter structure for some future possibilities.
> 

What do you mean by "future possibilities"?

> i40e/i40e_vf_representor.c:i40evf_stat_update_48(uint64_t *offset,
> i40e/i40e_vf_representor.c:i40evf_stat_update_32(uint64_t *offset,
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
> 	These are ops for VF representor ports of i40e
> 
>>
>>
>> Thanks,
>> ferruh
>>
>>
>> [1]
>> git grep -i i40evf drivers/net/