From patchwork Wed Sep 22 09:57:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 99411 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FA88A0C45; Wed, 22 Sep 2021 11:58:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0D9641198; Wed, 22 Sep 2021 11:58:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D6B3641196 for ; Wed, 22 Sep 2021 11:58:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632304689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NeA+xivs62ehX9PKyOp/n0rTU5hQPHjrDi9dNNjSiYc=; b=BcHJw9svd7SkePywfpU+AJj73KXfc0gpBimKIJN1hsaBg5iocjdYCS0W683iqdBvKFKKzS wd++9D+odRUF5WinYy0tXtHCIXnjSvqMJx8l1ec1geHaMeKBBM8IzQfR4LkxSNjvoAN/U0 XQgvrMhUkwDKFmNJnxF+O1Uuu0gL0cg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-YVLmZ1IjNxK74bnJuy6l6w-1; Wed, 22 Sep 2021 05:58:06 -0400 X-MC-Unique: YVLmZ1IjNxK74bnJuy6l6w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B812C1007905; Wed, 22 Sep 2021 09:58:04 +0000 (UTC) Received: from max-t490s.redhat.com (unknown [10.39.208.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5BA260871; Wed, 22 Sep 2021 09:57:44 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com, xiaoyun.li@intel.com Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com, yvugenfi@redhat.com, ybendito@redhat.com, Maxime Coquelin Date: Wed, 22 Sep 2021 11:57:37 +0200 Message-Id: <20210922095742.229262-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH v2 0/5] Virtio PMD RSS support & RSS fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This series is mainly adding support for RSS to Virtio PMD driver. The two last patches are fixing an issue in testpmd that could cause out of bounds access, and fix an issue spotted in the mlx5 driver while looking for inspiration. The first motivation for this series is to eventually support RSS down to the Vhost-user library, so that OVS can benefit from it. But it will be also useful with vDPA devices in the future. Regarding the testing, I have tested it with qemu v5.2 from Fedora 34. Since libvirt does not support yet enabling RSS feature in the Qemu virtio-net device, and this feature is disabled by default, the tester can either rebuild the qemu package to enable it by default or use the qemu cmdline to do the same. The tester can use testpmd in icmpecho mode in the guest and scapy on the host to inject random traffic on the tap interface, e.g.: sendp(Ether(src=RandMAC()) / IP(src=RandIP(), dst='192.168.123.9') / UDP(sport=RandShort(), dport=RandShort()), loop=True, iface='vnet7') Then it can play with RSS config in testpmd to change the RETA, or hash type and see traffic being steered accordingly by checking the Rx xstats. Changes in v2: ============== - Rework patch 2 to keep old behaviour, but fix possible out of bounds due to key length (Andrew/Nelio/Xiaoyun) - s/reta/RETA/ (Andrew) - Applied A-by on patch 3 (Slava) - Fix display of configured hash types - Add missing flow types definition to testpmd's port info command Maxime Coquelin (3): net/virtio: add initial RSS support app/testpmd: fix RSS key length app/testpmd: fix RSS type display net/mlx5: fix RSS RETA update app/testpmd: add missing flow types in port info app/test-pmd/config.c | 10 +- doc/guides/nics/features/virtio.ini | 3 + doc/guides/nics/virtio.rst | 3 + doc/guides/rel_notes/release_21_11.rst | 6 + drivers/net/mlx5/mlx5_rss.c | 2 +- drivers/net/virtio/virtio.h | 31 ++- drivers/net/virtio/virtio_ethdev.c | 367 ++++++++++++++++++++++++- drivers/net/virtio/virtio_ethdev.h | 3 +- drivers/net/virtio/virtqueue.h | 21 ++ 9 files changed, 437 insertions(+), 9 deletions(-)