| Message ID | 20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B06AAA0C4C; Thu, 14 Oct 2021 10:37:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9E37411DC; Thu, 14 Oct 2021 10:37:16 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 9E666411DB for <dev@dpdk.org>; Thu, 14 Oct 2021 10:37:15 +0200 (CEST) Received: by shelob.oktetlabs.ru (Postfix, from userid 122) id 306227F6FD; Thu, 14 Oct 2021 11:37:15 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD autolearn=no autolearn_force=no version=3.4.2 Received: from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17]) by shelob.oktetlabs.ru (Postfix) with ESMTP id 8B3177F6C8 for <dev@dpdk.org>; Thu, 14 Oct 2021 11:37:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8B3177F6C8 Authentication-Results: shelob.oktetlabs.ru/8B3177F6C8; dkim=none; dkim-atps=neutral From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> To: Cc: dev@dpdk.org Date: Thu, 14 Oct 2021 11:36:59 +0300 Message-Id: <20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/5] ethdev: cosmetic fixes for just moved structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
ethdev: cosmetic fixes for just moved structures
|
|
Message
Andrew Rybchenko
Oct. 14, 2021, 8:36 a.m. UTC
Sicne rte_eth_dev and rte_eth_dev_data structures are just moved right now is a good chance to make a cleanup. No strong opinion, but I think it would be useful for the future. Make be at least some fixes from below could be accepted. Andrew Rybchenko (5): ethdev: avoid documentation in next lines ethdev: fix Rx/Tx spelling in just moved structures ethdev: remove reserved fields from internal structures ethdev: make device and data structures readable ethdev: remove full stop after short comments and references lib/ethdev/ethdev_driver.h | 124 +++++++++++++++++++------------------ 1 file changed, 64 insertions(+), 60 deletions(-)
Comments
On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: > Sicne rte_eth_dev and rte_eth_dev_data structures are just moved > right now is a good chance to make a cleanup. > > No strong opinion, but I think it would be useful for the future. > > Make be at least some fixes from below could be accepted. > > Andrew Rybchenko (5): > ethdev: avoid documentation in next lines > ethdev: fix Rx/Tx spelling in just moved structures > ethdev: remove reserved fields from internal structures > ethdev: make device and data structures readable > ethdev: remove full stop after short comments and references > Overall +1 to these changes, I think this release is the opportunity to have changes like this. But as far as I can see only new moved code updated in 'ethdev_driver.h', why not update whole 'ethdev_driver.h'?
On 10/19/21 2:55 PM, Ferruh Yigit wrote: > On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: >> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved >> right now is a good chance to make a cleanup. >> >> No strong opinion, but I think it would be useful for the future. >> >> Make be at least some fixes from below could be accepted. >> >> Andrew Rybchenko (5): >> ethdev: avoid documentation in next lines >> ethdev: fix Rx/Tx spelling in just moved structures >> ethdev: remove reserved fields from internal structures >> ethdev: make device and data structures readable >> ethdev: remove full stop after short comments and references >> > > Overall +1 to these changes, I think this release is the opportunity > to have changes like this. > > But as far as I can see only new moved code updated in 'ethdev_driver.h', > why not update whole 'ethdev_driver.h'? Simply don't want to complicate search by git blame because of cosmetic changes. No strong opinion, but decided to go this way for now.
On 10/19/2021 7:07 PM, Andrew Rybchenko wrote: > On 10/19/21 2:55 PM, Ferruh Yigit wrote: >> On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: >>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved >>> right now is a good chance to make a cleanup. >>> >>> No strong opinion, but I think it would be useful for the future. >>> >>> Make be at least some fixes from below could be accepted. >>> >>> Andrew Rybchenko (5): >>> ethdev: avoid documentation in next lines >>> ethdev: fix Rx/Tx spelling in just moved structures >>> ethdev: remove reserved fields from internal structures >>> ethdev: make device and data structures readable >>> ethdev: remove full stop after short comments and references >>> >> >> Overall +1 to these changes, I think this release is the opportunity >> to have changes like this. >> >> But as far as I can see only new moved code updated in 'ethdev_driver.h', >> why not update whole 'ethdev_driver.h'? > > Simply don't want to complicate search by git blame because of cosmetic > changes. No strong opinion, but decided to go this way for now. Normally agree to NOT get cosmetic changes because the reason you mentioned, noise in the git history. But in this release we already shuffled things a bit, that is why I think it is good opportunity to get these kind of changes. Also there will be some inconsistencies in 'ethdev_driver.h' after your changes, like 'RX' -> 'Rx' change done in one patch, but half of the file still uses 'RX'. I also don't have strong opinion, but my preference is either fix all, or none. Lets get some more comments.
20/10/2021 00:05, Ferruh Yigit: > On 10/19/2021 7:07 PM, Andrew Rybchenko wrote: > > On 10/19/21 2:55 PM, Ferruh Yigit wrote: > >> On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: > >>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved > >>> right now is a good chance to make a cleanup. > >>> > >>> No strong opinion, but I think it would be useful for the future. > >>> > >>> Make be at least some fixes from below could be accepted. > >>> > >>> Andrew Rybchenko (5): > >>> ethdev: avoid documentation in next lines > >>> ethdev: fix Rx/Tx spelling in just moved structures > >>> ethdev: remove reserved fields from internal structures > >>> ethdev: make device and data structures readable > >>> ethdev: remove full stop after short comments and references > >>> > >> > >> Overall +1 to these changes, I think this release is the opportunity > >> to have changes like this. > >> > >> But as far as I can see only new moved code updated in 'ethdev_driver.h', > >> why not update whole 'ethdev_driver.h'? > > > > Simply don't want to complicate search by git blame because of cosmetic > > changes. No strong opinion, but decided to go this way for now. > > Normally agree to NOT get cosmetic changes because the reason you mentioned, > noise in the git history. But in this release we already shuffled things a bit, > that is why I think it is good opportunity to get these kind of changes. > > Also there will be some inconsistencies in 'ethdev_driver.h' after your changes, > like 'RX' -> 'Rx' change done in one patch, but half of the file still uses 'RX'. > > I also don't have strong opinion, but my preference is either fix all, or none. > Lets get some more comments. OK to fix all, given ethdev is already shuffled a lot.
On 10/20/21 1:20 AM, Thomas Monjalon wrote: > 20/10/2021 00:05, Ferruh Yigit: >> On 10/19/2021 7:07 PM, Andrew Rybchenko wrote: >>> On 10/19/21 2:55 PM, Ferruh Yigit wrote: >>>> On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: >>>>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved >>>>> right now is a good chance to make a cleanup. >>>>> >>>>> No strong opinion, but I think it would be useful for the future. >>>>> >>>>> Make be at least some fixes from below could be accepted. >>>>> >>>>> Andrew Rybchenko (5): >>>>> ethdev: avoid documentation in next lines >>>>> ethdev: fix Rx/Tx spelling in just moved structures >>>>> ethdev: remove reserved fields from internal structures >>>>> ethdev: make device and data structures readable >>>>> ethdev: remove full stop after short comments and references >>>>> >>>> >>>> Overall +1 to these changes, I think this release is the opportunity >>>> to have changes like this. >>>> >>>> But as far as I can see only new moved code updated in 'ethdev_driver.h', >>>> why not update whole 'ethdev_driver.h'? >>> >>> Simply don't want to complicate search by git blame because of cosmetic >>> changes. No strong opinion, but decided to go this way for now. >> >> Normally agree to NOT get cosmetic changes because the reason you mentioned, >> noise in the git history. But in this release we already shuffled things a bit, >> that is why I think it is good opportunity to get these kind of changes. >> >> Also there will be some inconsistencies in 'ethdev_driver.h' after your changes, >> like 'RX' -> 'Rx' change done in one patch, but half of the file still uses 'RX'. >> >> I also don't have strong opinion, but my preference is either fix all, or none. >> Lets get some more comments. > > OK to fix all, given ethdev is already shuffled a lot. > I've made the next step. See v2. Let me know if it is OK, too much or insufficient.