From patchwork Fri Oct 15 19:24:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Matz X-Patchwork-Id: 101840 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 393E2A0C43; Fri, 15 Oct 2021 21:24:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FD12410F2; Fri, 15 Oct 2021 21:24:29 +0200 (CEST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 46F964003C for ; Fri, 15 Oct 2021 21:24:28 +0200 (CEST) Received: by mail-wr1-f49.google.com with SMTP id v17so28095902wrv.9 for ; Fri, 15 Oct 2021 12:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wpD+cogQxnzr9dc8cV0X2KwBdEiEI2OCJPp2QeLH8vY=; b=P1ISPFnRRzoJbFbTaJY7epwvxVHgZ5v0N69Aa8TbRbNMgH8sg532QPNgZQ7HZnNBID DxBTaYVFp0r60JGaS0NE1bO3KNMlUHUZ6HlIz0BeQBwN0iqkyMWrcyo0JXuSNwW7w81i 5On1WBa/KTnvJcWGCCxdyeKbb8lfX+ipc434rpcEnUZ9e82K+ozAhyROENarNa1FJ/TZ Ddx5dyMKx01TPcLBtW8Eji9MjrsQSojEhKOKYnrbVcoA2DIieiecIovI4DSIm+pImwEr IdPIs87nG0wop7yZrv3tK4neC3p0qNooXHnoobA7eKuAtLtAJvSo+l3Mbrt8QZbD+S62 0hyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wpD+cogQxnzr9dc8cV0X2KwBdEiEI2OCJPp2QeLH8vY=; b=Q5N5AfPErDFcFYrVpyZHc50XOAnPehhb2NReHOSGmIs8p7tDY7qzgvH20YidrM8bga ZeeOA2T+Z194lHMzGLpFM6LaRJw/sgITgNP1qTW3zMLp4ALvxYMX9ofBNb0P3CDjULcx NJ6UaMGqaokYSTdcFeGW3KGL1acOpMfGsAce5qIzeHgpFx+frtT2+cZdp68jr/4mURkO oxQJde5LSzsCkkNIW5JUGd45/b/iLf9NTXx0oQxvev00temCuD3Ta86OeJRMSDiRuywb vJy1jn08ZXsoIbxFBq2P3NuOz+sJ0HtRci2qd7xMutoksI2tcMN/Ex1IeDa5t/IDjeHi 4eGw== X-Gm-Message-State: AOAM531R2dW28jZRsEfNtJPcjUl22SMP83raVEvg8Dx7weLP6FRaqRib vhyYh96z0VhXAs6EW9nrULg1Sg3CRWz6wN3m X-Google-Smtp-Source: ABdhPJyUdFRvtArMHvRxJIHFa3NboAzzsAZSoi4zu0r3XfaZdp7Xecyi+uN6RkL99LZC6wx9Yr6w8w== X-Received: by 2002:a5d:4d0f:: with SMTP id z15mr16967990wrt.334.1634325867997; Fri, 15 Oct 2021 12:24:27 -0700 (PDT) Received: from gojira.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s186sm6335862wme.14.2021.10.15.12.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 12:24:26 -0700 (PDT) From: Olivier Matz To: dev@dpdk.org Cc: David Marchand Date: Fri, 15 Oct 2021 21:24:04 +0200 Message-Id: <20211015192408.21798-1-olivier.matz@6wind.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210929214817.18082-1-olivier.matz@6wind.com> References: <20210929214817.18082-1-olivier.matz@6wind.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 0/4] mbuf: offload flags namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patchset fixes the mbuf offload flags namespace by adding an RTE_ prefix to the definitions. The old flags remain usable, but a deprecation warning is issued at compilation. v2 * rebase * remove part about PKT_RX_EIP_CKSUM_BAD, already in 74a74bf98c * mark old vlan flags as deprecated instead of removing them * clarify that rx checksum flags are not really removed (just remove dup) Olivier Matz (4): mbuf: remove duplicate definition of cksum offload flags mbuf: mark old VLAN offload flags as deprecated cocci: add cocci script to rename mbuf offload flags mbuf: add rte prefix to offload flags app/test-pmd/csumonly.c | 62 +-- app/test-pmd/flowgen.c | 8 +- app/test-pmd/ieee1588fwd.c | 6 +- app/test-pmd/macfwd.c | 8 +- app/test-pmd/macswap_common.h | 12 +- app/test-pmd/txonly.c | 8 +- app/test-pmd/util.c | 18 +- app/test/test_cryptodev_security_ipsec.c | 4 +- app/test/test_ipsec.c | 4 +- app/test/test_mbuf.c | 144 +++--- .../cocci/prefix_mbuf_offload_flags.cocci | 441 ++++++++++++++++++ doc/guides/nics/bnxt.rst | 8 +- doc/guides/nics/enic.rst | 8 +- doc/guides/nics/features.rst | 70 +-- doc/guides/nics/ixgbe.rst | 2 +- doc/guides/nics/mlx5.rst | 6 +- .../generic_segmentation_offload_lib.rst | 4 +- doc/guides/prog_guide/mbuf_lib.rst | 18 +- doc/guides/prog_guide/metrics_lib.rst | 2 +- doc/guides/prog_guide/rte_flow.rst | 14 +- doc/guides/rel_notes/deprecation.rst | 5 - doc/guides/rel_notes/release_21_11.rst | 3 + drivers/compress/mlx5/mlx5_compress.c | 2 +- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 12 +- drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 4 +- drivers/crypto/mlx5/mlx5_crypto.c | 2 +- drivers/event/cnxk/cn9k_worker.h | 2 +- drivers/event/octeontx/ssovf_worker.c | 36 +- drivers/event/octeontx/ssovf_worker.h | 2 +- drivers/event/octeontx2/otx2_worker.h | 2 +- drivers/net/af_packet/rte_eth_af_packet.c | 4 +- drivers/net/atlantic/atl_rxtx.c | 46 +- drivers/net/avp/avp_ethdev.c | 8 +- drivers/net/axgbe/axgbe_rxtx.c | 64 +-- drivers/net/axgbe/axgbe_rxtx_vec_sse.c | 2 +- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x_rxtx.c | 2 +- drivers/net/bnxt/bnxt_rxr.c | 50 +- drivers/net/bnxt/bnxt_rxr.h | 32 +- drivers/net/bnxt/bnxt_txr.c | 40 +- drivers/net/bnxt/bnxt_txr.h | 38 +- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- drivers/net/cnxk/cn10k_ethdev.c | 18 +- drivers/net/cnxk/cn10k_rx.h | 38 +- drivers/net/cnxk/cn10k_tx.h | 178 +++---- drivers/net/cnxk/cn9k_ethdev.c | 18 +- drivers/net/cnxk/cn9k_rx.h | 32 +- drivers/net/cnxk/cn9k_tx.h | 170 +++---- drivers/net/cnxk/cnxk_ethdev.h | 10 +- drivers/net/cnxk/cnxk_lookup.c | 40 +- drivers/net/cxgbe/sge.c | 46 +- drivers/net/dpaa/dpaa_ethdev.h | 7 +- drivers/net/dpaa/dpaa_rxtx.c | 10 +- drivers/net/dpaa2/dpaa2_rxtx.c | 30 +- drivers/net/e1000/em_rxtx.c | 39 +- drivers/net/e1000/igb_rxtx.c | 81 ++-- drivers/net/ena/ena_ethdev.c | 53 ++- drivers/net/enetc/enetc_rxtx.c | 44 +- drivers/net/enic/enic_main.c | 10 +- drivers/net/enic/enic_res.c | 12 +- drivers/net/enic/enic_rxtx.c | 24 +- drivers/net/enic/enic_rxtx_common.h | 18 +- drivers/net/enic/enic_rxtx_vec_avx2.c | 80 ++-- drivers/net/fm10k/fm10k_rxtx.c | 43 +- drivers/net/fm10k/fm10k_rxtx_vec.c | 25 +- drivers/net/hinic/hinic_pmd_rx.c | 22 +- drivers/net/hinic/hinic_pmd_tx.c | 56 +-- drivers/net/hinic/hinic_pmd_tx.h | 13 +- drivers/net/hns3/hns3_ethdev.h | 2 +- drivers/net/hns3/hns3_rxtx.c | 108 ++--- drivers/net/hns3/hns3_rxtx.h | 25 +- drivers/net/hns3/hns3_rxtx_vec_neon.h | 2 +- drivers/net/hns3/hns3_rxtx_vec_sve.c | 2 +- drivers/net/i40e/i40e_rxtx.c | 157 +++---- drivers/net/i40e/i40e_rxtx_vec_altivec.c | 22 +- drivers/net/i40e/i40e_rxtx_vec_avx2.c | 70 +-- drivers/net/i40e/i40e_rxtx_vec_avx512.c | 62 +-- drivers/net/i40e/i40e_rxtx_vec_neon.c | 50 +- drivers/net/i40e/i40e_rxtx_vec_sse.c | 60 +-- drivers/net/iavf/iavf_rxtx.c | 90 ++-- drivers/net/iavf/iavf_rxtx.h | 28 +- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 140 +++--- drivers/net/iavf/iavf_rxtx_vec_avx512.c | 140 +++--- drivers/net/iavf/iavf_rxtx_vec_common.h | 16 +- drivers/net/iavf/iavf_rxtx_vec_sse.c | 112 ++--- drivers/net/ice/ice_rxtx.c | 117 +++-- drivers/net/ice/ice_rxtx_vec_avx2.c | 158 +++---- drivers/net/ice/ice_rxtx_vec_avx512.c | 158 +++---- drivers/net/ice/ice_rxtx_vec_common.h | 16 +- drivers/net/ice/ice_rxtx_vec_sse.c | 112 ++--- drivers/net/igc/igc_txrx.c | 67 +-- drivers/net/ionic/ionic_rxtx.c | 59 ++- drivers/net/ixgbe/ixgbe_ethdev.c | 4 +- drivers/net/ixgbe/ixgbe_rxtx.c | 113 +++-- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 38 +- drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 44 +- drivers/net/liquidio/lio_rxtx.c | 16 +- drivers/net/mlx4/mlx4_rxtx.c | 22 +- drivers/net/mlx5/mlx5_flow.c | 2 +- drivers/net/mlx5/mlx5_rx.c | 18 +- drivers/net/mlx5/mlx5_rx.h | 4 +- drivers/net/mlx5/mlx5_rxq.c | 2 +- drivers/net/mlx5/mlx5_rxtx.c | 18 +- drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 76 +-- drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 36 +- drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 38 +- drivers/net/mlx5/mlx5_tx.h | 104 ++--- drivers/net/mvneta/mvneta_ethdev.h | 6 +- drivers/net/mvneta/mvneta_rxtx.c | 16 +- drivers/net/mvpp2/mrvl_ethdev.c | 22 +- drivers/net/netvsc/hn_rxtx.c | 28 +- drivers/net/nfp/nfp_rxtx.c | 26 +- drivers/net/octeontx/octeontx_rxtx.h | 38 +- drivers/net/octeontx2/otx2_ethdev.c | 18 +- drivers/net/octeontx2/otx2_lookup.c | 40 +- drivers/net/octeontx2/otx2_rx.c | 12 +- drivers/net/octeontx2/otx2_rx.h | 22 +- drivers/net/octeontx2/otx2_tx.c | 86 ++-- drivers/net/octeontx2/otx2_tx.h | 70 +-- drivers/net/qede/qede_rxtx.c | 104 ++--- drivers/net/qede/qede_rxtx.h | 20 +- drivers/net/sfc/sfc_dp_tx.h | 14 +- drivers/net/sfc/sfc_ef100_rx.c | 18 +- drivers/net/sfc/sfc_ef100_tx.c | 52 +-- drivers/net/sfc/sfc_ef10_essb_rx.c | 6 +- drivers/net/sfc/sfc_ef10_rx.c | 6 +- drivers/net/sfc/sfc_ef10_rx_ev.h | 16 +- drivers/net/sfc/sfc_ef10_tx.c | 18 +- drivers/net/sfc/sfc_rx.c | 22 +- drivers/net/sfc/sfc_tso.c | 2 +- drivers/net/sfc/sfc_tso.h | 2 +- drivers/net/sfc/sfc_tx.c | 4 +- drivers/net/tap/rte_eth_tap.c | 28 +- drivers/net/thunderx/nicvf_rxtx.c | 24 +- drivers/net/thunderx/nicvf_rxtx.h | 2 +- drivers/net/txgbe/txgbe_ethdev.c | 4 +- drivers/net/txgbe/txgbe_rxtx.c | 172 +++---- drivers/net/vhost/rte_eth_vhost.c | 2 +- drivers/net/virtio/virtio_rxtx.c | 14 +- drivers/net/virtio/virtio_rxtx_packed.h | 6 +- drivers/net/virtio/virtqueue.h | 14 +- drivers/net/vmxnet3/vmxnet3_rxtx.c | 59 ++- drivers/regex/mlx5/mlx5_regex_fastpath.c | 2 +- examples/bpf/t2.c | 4 +- examples/ip_fragmentation/main.c | 2 +- examples/ip_reassembly/main.c | 2 +- examples/ipsec-secgw/esp.c | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 20 +- examples/ipsec-secgw/ipsec_worker.c | 12 +- examples/ipsec-secgw/sa.c | 2 +- examples/ptpclient/ptpclient.c | 4 +- examples/qos_meter/main.c | 12 +- examples/vhost/main.c | 12 +- lib/ethdev/rte_ethdev.h | 4 +- lib/ethdev/rte_flow.h | 33 +- lib/eventdev/rte_event_eth_rx_adapter.c | 4 +- lib/gso/gso_common.h | 40 +- lib/gso/gso_tunnel_tcp4.c | 2 +- lib/gso/rte_gso.c | 10 +- lib/gso/rte_gso.h | 4 +- lib/ipsec/esp_inb.c | 10 +- lib/ipsec/esp_outb.c | 4 +- lib/ipsec/misc.h | 2 +- lib/ipsec/rte_ipsec_group.h | 6 +- lib/ipsec/sa.c | 2 +- lib/mbuf/rte_mbuf.c | 220 ++++----- lib/mbuf/rte_mbuf.h | 30 +- lib/mbuf/rte_mbuf_core.h | 422 ++++++++++------- lib/mbuf/rte_mbuf_dyn.c | 2 +- lib/net/rte_ether.h | 6 +- lib/net/rte_ip.h | 4 +- lib/net/rte_net.h | 22 +- lib/pipeline/rte_table_action.c | 10 +- lib/security/rte_security.h | 10 +- lib/vhost/virtio_net.c | 42 +- 175 files changed, 3561 insertions(+), 3031 deletions(-) create mode 100644 devtools/cocci/prefix_mbuf_offload_flags.cocci