Message ID | 20211019174022.2036272-1-andrew.rybchenko@oktetlabs.ru (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66299A0547; Tue, 19 Oct 2021 19:40:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3473A40683; Tue, 19 Oct 2021 19:40:40 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id D1B7F4003E for <dev@dpdk.org>; Tue, 19 Oct 2021 19:40:38 +0200 (CEST) Received: by shelob.oktetlabs.ru (Postfix, from userid 122) id 7A17C7F6FE; Tue, 19 Oct 2021 20:40:38 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD autolearn=no autolearn_force=no version=3.4.2 Received: from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17]) by shelob.oktetlabs.ru (Postfix) with ESMTP id 1F9377F4FE; Tue, 19 Oct 2021 20:40:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 1F9377F4FE Authentication-Results: shelob.oktetlabs.ru/1F9377F4FE; dkim=none; dkim-atps=neutral From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> To: Olivier Matz <olivier.matz@6wind.com> Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org Date: Tue, 19 Oct 2021 20:40:16 +0300 Message-Id: <20211019174022.2036272-1-andrew.rybchenko@oktetlabs.ru> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 0/6] mempool: cleanup namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
mempool: cleanup namespace
|
|
Message
Andrew Rybchenko
Oct. 19, 2021, 5:40 p.m. UTC
Add RTE_ prefix to mempool API including internal. Keep old public API with fallback to new defines. Internal API is just renamed. v3: - fix typo - rebase on top of current main - add prefix to newly added MEMPOOL_F_NON_IO - fix deprecation usage - add Fixes tag the patch which deprecates unused macros v2: - do not deprecate MEMPOOL_F_* flags - fix unintended usage of internal get/put helpers from bulk get/put Andrew Rybchenko (6): mempool: avoid flags documentation in the next line mempool: add namespace prefix to flags mempool: add namespace to internal but still visible API mempool: make header size calculation internal mempool: add namespace to driver register macro mempool: deprecate unused defines app/proc-info/main.c | 17 +- app/test-pmd/parameters.c | 4 +- app/test/test_mempool.c | 18 +- doc/guides/contributing/documentation.rst | 4 +- doc/guides/nics/mlx5.rst | 2 +- doc/guides/prog_guide/mempool_lib.rst | 2 +- doc/guides/rel_notes/deprecation.rst | 11 ++ doc/guides/rel_notes/release_21_11.rst | 14 +- drivers/common/mlx5/mlx5_common_mr.c | 4 +- drivers/event/cnxk/cnxk_tim_evdev.c | 2 +- drivers/event/octeontx/ssovf_worker.h | 2 +- drivers/event/octeontx/timvf_evdev.c | 2 +- drivers/event/octeontx2/otx2_tim_evdev.c | 2 +- drivers/mempool/bucket/rte_mempool_bucket.c | 10 +- drivers/mempool/cnxk/cn10k_mempool_ops.c | 2 +- drivers/mempool/cnxk/cn9k_mempool_ops.c | 2 +- drivers/mempool/dpaa/dpaa_mempool.c | 2 +- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 2 +- .../mempool/octeontx/rte_mempool_octeontx.c | 2 +- drivers/mempool/octeontx2/otx2_mempool_ops.c | 2 +- drivers/mempool/ring/rte_mempool_ring.c | 16 +- drivers/mempool/stack/rte_mempool_stack.c | 4 +- drivers/net/cnxk/cn10k_rx.h | 12 +- drivers/net/cnxk/cn10k_tx.h | 30 ++-- drivers/net/cnxk/cn9k_rx.h | 12 +- drivers/net/cnxk/cn9k_tx.h | 26 +-- drivers/net/mlx5/mlx5_mr.c | 2 +- drivers/net/octeontx/octeontx_rxtx.h | 4 +- drivers/net/octeontx2/otx2_ethdev.c | 4 +- drivers/net/octeontx2/otx2_ethdev_sec_tx.h | 2 +- drivers/net/octeontx2/otx2_rx.c | 8 +- drivers/net/octeontx2/otx2_rx.h | 4 +- drivers/net/octeontx2/otx2_tx.c | 16 +- drivers/net/octeontx2/otx2_tx.h | 4 +- drivers/net/thunderx/nicvf_ethdev.c | 2 +- lib/mempool/rte_mempool.c | 58 +++---- lib/mempool/rte_mempool.h | 164 +++++++++++------- lib/mempool/rte_mempool_ops.c | 2 +- lib/pdump/rte_pdump.c | 3 +- lib/vhost/iotlb.c | 4 +- 40 files changed, 275 insertions(+), 208 deletions(-)
Comments
On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote: > > Add RTE_ prefix to mempool API including internal. Keep old public API > with fallback to new defines. Internal API is just renamed. > > v3: > - fix typo > - rebase on top of current main > - add prefix to newly added MEMPOOL_F_NON_IO > - fix deprecation usage > - add Fixes tag the patch which deprecates unused macros Thanks for the quick rebase. I had rebased v2 before Olivier comments. I spotted a little issue diffing with your v3 (see comment on patch 2), and fixed your v3 in a local branch of mine. It passes my checks. I'll wait tomorrow, to see if Olivier wants to send some acks.
On Tue, Oct 19, 2021 at 10:09 PM David Marchand <david.marchand@redhat.com> wrote: > On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko > <andrew.rybchenko@oktetlabs.ru> wrote: > > > > Add RTE_ prefix to mempool API including internal. Keep old public API > > with fallback to new defines. Internal API is just renamed. > > > > v3: > > - fix typo > > - rebase on top of current main > > - add prefix to newly added MEMPOOL_F_NON_IO > > - fix deprecation usage > > - add Fixes tag the patch which deprecates unused macros > > I spotted a little issue diffing with your v3 (see comment on patch > 2), and fixed your v3 in a local branch of mine. Series applied with fix on patch 2. Thanks.
On 10/19/21 11:09 PM, David Marchand wrote: > On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko > <andrew.rybchenko@oktetlabs.ru> wrote: >> >> Add RTE_ prefix to mempool API including internal. Keep old public API >> with fallback to new defines. Internal API is just renamed. >> >> v3: >> - fix typo >> - rebase on top of current main >> - add prefix to newly added MEMPOOL_F_NON_IO >> - fix deprecation usage >> - add Fixes tag the patch which deprecates unused macros > > Thanks for the quick rebase. > I had rebased v2 before Olivier comments. > I spotted a little issue diffing with your v3 (see comment on patch > 2), and fixed your v3 in a local branch of mine. > It passes my checks. > > I'll wait tomorrow, to see if Olivier wants to send some acks. Olivier has just added missing Acks. Do you need v4 from me with patch 2 fixes? Your changes LGTM and I don't mind if you fix it on apply.
On 10/20/21 10:52 AM, David Marchand wrote: > On Tue, Oct 19, 2021 at 10:09 PM David Marchand > <david.marchand@redhat.com> wrote: >> On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko >> <andrew.rybchenko@oktetlabs.ru> wrote: >>> >>> Add RTE_ prefix to mempool API including internal. Keep old public API >>> with fallback to new defines. Internal API is just renamed. >>> >>> v3: >>> - fix typo >>> - rebase on top of current main >>> - add prefix to newly added MEMPOOL_F_NON_IO >>> - fix deprecation usage >>> - add Fixes tag the patch which deprecates unused macros >> >> I spotted a little issue diffing with your v3 (see comment on patch >> 2), and fixed your v3 in a local branch of mine. > > Series applied with fix on patch 2. > Thanks. Sorry, I've not noticed this reply before my question. Many thanks that you agreed to accept these patches that late.
On Wed, Oct 20, 2021 at 9:52 AM Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote: > > Thanks for the quick rebase. > > I had rebased v2 before Olivier comments. > > I spotted a little issue diffing with your v3 (see comment on patch > > 2), and fixed your v3 in a local branch of mine. > > It passes my checks. > > > > I'll wait tomorrow, to see if Olivier wants to send some acks. > > Olivier has just added missing Acks. Do you need v4 from me > with patch 2 fixes? Your changes LGTM and I don't mind if you > fix it on apply. I applied Olivier acks. Patches are pushed if you want to double check, but I think we are good. Now looking at mbuf offload namespace series... :-)