mbox series

[0/7] vhost: improve logging

Message ID 20211223083659.245766-1-maxime.coquelin@redhat.com (mailing list archive)
Headers
Series vhost: improve logging |

Message

Maxime Coquelin Dec. 23, 2021, 8:36 a.m. UTC 
  This series aims at easing Vhost logs analysis, by
prepending the Vhost-user socket path to all logs and to
remove multi-line comments. Doing so, filtering Vhost-user
ports logs is much easier.

Maxime Coquelin (7):
  vhost: improve IOTLB logs
  vhost: improve vDPA registration failure log
  vhost: improve socket layer logs
  vhost: improve Vhost layer logs
  vhost: improve Vhost-user layer logs
  vhost: improve Virtio-net layer logs
  vhost: remove multi-line logs

 lib/vhost/iotlb.c      |  26 +-
 lib/vhost/iotlb.h      |  10 +-
 lib/vhost/socket.c     | 131 ++++-----
 lib/vhost/vdpa.c       |   4 +-
 lib/vhost/vhost.c      | 106 ++++---
 lib/vhost/vhost_user.c | 653 ++++++++++++++++++++---------------------
 lib/vhost/virtio_net.c | 165 +++++------
 7 files changed, 518 insertions(+), 577 deletions(-)

Comments

Stephen Hemminger Dec. 23, 2021, 3:59 p.m. UTC | #1 
On Thu, 23 Dec 2021 09:36:52 +0100
Maxime Coquelin <maxime.coquelin@redhat.com> wrote:

> This series aims at easing Vhost logs analysis, by
> prepending the Vhost-user socket path to all logs and to
> remove multi-line comments. Doing so, filtering Vhost-user
> ports logs is much easier.
> 
> Maxime Coquelin (7):
>   vhost: improve IOTLB logs
>   vhost: improve vDPA registration failure log
>   vhost: improve socket layer logs
>   vhost: improve Vhost layer logs
>   vhost: improve Vhost-user layer logs
>   vhost: improve Virtio-net layer logs
>   vhost: remove multi-line logs
> 
>  lib/vhost/iotlb.c      |  26 +-
>  lib/vhost/iotlb.h      |  10 +-
>  lib/vhost/socket.c     | 131 ++++-----
>  lib/vhost/vdpa.c       |   4 +-
>  lib/vhost/vhost.c      | 106 ++++---
>  lib/vhost/vhost_user.c | 653 ++++++++++++++++++++---------------------
>  lib/vhost/virtio_net.c | 165 +++++------
>  7 files changed, 518 insertions(+), 577 deletions(-)
> 

Good work

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
David Marchand Jan. 4, 2022, 3:05 p.m. UTC | #2 
On Thu, Dec 23, 2021 at 9:37 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> This series aims at easing Vhost logs analysis, by
> prepending the Vhost-user socket path to all logs and to
> remove multi-line comments. Doing so, filtering Vhost-user
> ports logs is much easier.
>
> Maxime Coquelin (7):
>   vhost: improve IOTLB logs
>   vhost: improve vDPA registration failure log
>   vhost: improve socket layer logs
>   vhost: improve Vhost layer logs
>   vhost: improve Vhost-user layer logs
>   vhost: improve Virtio-net layer logs
>   vhost: remove multi-line logs
>
>  lib/vhost/iotlb.c      |  26 +-
>  lib/vhost/iotlb.h      |  10 +-
>  lib/vhost/socket.c     | 131 ++++-----
>  lib/vhost/vdpa.c       |   4 +-
>  lib/vhost/vhost.c      | 106 ++++---
>  lib/vhost/vhost_user.c | 653 ++++++++++++++++++++---------------------
>  lib/vhost/virtio_net.c | 165 +++++------
>  7 files changed, 518 insertions(+), 577 deletions(-)

Thanks for the series!
I sent some comments.

We can probably work more on those logs but this series is a good enhancement.