[v3,0/5] Add JSON vector set support to fips validation

  Adds a very basic introduction to JSON vector sets in
the fips validation example application. This patch set
will only introduce the AES-GCM test using a JSON request
file because the other algorithms need more information
than what is given in the new JSON format.

Brandon Lo (5):
  examples/fips_validation: add jansson dependency
  examples/fips_validation: add json info to header
  examples/fips_validation: add json parsing
  examples/fips_validation: allow json file as input
  examples/fips_validation: add json to gcm test

 examples/fips_validation/fips_validation.c    |  96 ++++++++-
 examples/fips_validation/fips_validation.h    |  48 ++++-
 .../fips_validation/fips_validation_gcm.c     | 150 ++++++++++++++
 examples/fips_validation/main.c               | 195 +++++++++++++++++-
 examples/fips_validation/meson.build          |   4 +
 5 files changed, 483 insertions(+), 10 deletions(-)
  

Hi Fan and Ciara,

Could you please review this patch set?
Not sure who the maintainer of the fips_validation example is (I think
Marko Kovacevic stopped working on the FIPS validation example).

Thanks,
Brandon



--
Brandon Lo
UNH InterOperability Laboratory
21 Madbury Rd, Suite 100, Durham, NH 03824
blo@iol.unh.edu
www.iol.unh.edu
  

Hi Marko/Fan,

Please review this series.

> Adds a very basic introduction to JSON vector sets in
> the fips validation example application. This patch set
> will only introduce the AES-GCM test using a JSON request
> file because the other algorithms need more information
> than what is given in the new JSON format.
> 
> Brandon Lo (5):
>   examples/fips_validation: add jansson dependency
>   examples/fips_validation: add json info to header
>   examples/fips_validation: add json parsing
>   examples/fips_validation: allow json file as input
>   examples/fips_validation: add json to gcm test
> 
>  examples/fips_validation/fips_validation.c    |  96 ++++++++-
>  examples/fips_validation/fips_validation.h    |  48 ++++-
>  .../fips_validation/fips_validation_gcm.c     | 150 ++++++++++++++
>  examples/fips_validation/main.c               | 195 +++++++++++++++++-
>  examples/fips_validation/meson.build          |   4 +
>  5 files changed, 483 insertions(+), 10 deletions(-)
> 
> --
> 2.25.1
  

Adding the dev mailing list back into this discussion.

On Wed, Apr 13, 2022 at 9:13 AM Brandon Lo <blo@iol.unh.edu> wrote:
>
> Hi guys,
>
> Lincoln and I would like to know if we can get this patch set looked
> at and merged before submitting the rest of the algorithms. So far,
> I've worked on implementing the HMAC and CMAC tests, but I keep
> getting pulled away by some requests from the community. This patchset
> does not seem to break backward compatibility, so merging it will only
> lead to more coverage from the UNH lab. It may also be easier to
> review since it isn't going to be one huge patchset that needs to be
> looked at in the future.
>
> On Thu, Feb 17, 2022 at 7:47 AM Brandon Lo <blo@iol.unh.edu> wrote:
> >
> > On Fri, Feb 11, 2022 at 9:16 AM Brandon Lo <blo@iol.unh.edu> wrote:
> > > I only have the AES-GCM algorithm implemented because the current
> > > implementations of the other algorithms require some extra information
> > > than what comes with the JSON format in the API.
> > > For example, I couldn't find the JSON counterpart for things like
> > > fips_validation_sha.c's "MD =" or "Seed =" as well as
> > > fips_validation_ccm.c's extra test types like CCM-DVPT, CCM-VADT, etc.
> > > just to name a few.
> > > This could very well be due to my inexperience with the FIPS
> > > validation, and I definitely plan to take another look at it again.
> > >
> > > My assumption is that the JSON version of FIPS validation files isn't
> > > used as much as the old CAVP format, so I am more aiming towards
> > > getting something working in the lab first and then expanding on it
> > > later.
> >
> > Hi all,
> >
> > Could I get someone to look at this patch set?
> > The UNH lab is ready to deploy FIPS testing on patches that affect the
> > crypto portion of DPDK.
> >
> > Thanks,
> > Brandon
> >
> >
> > --
> > Brandon Lo
> > UNH InterOperability Laboratory
> > 21 Madbury Rd, Suite 100, Durham, NH 03824
> > blo@iol.unh.edu
> > www.iol.unh.edu
>
>
>
> --
> Brandon Lo
> UNH InterOperability Laboratory
> 21 Madbury Rd, Suite 100, Durham, NH 03824
> blo@iol.unh.edu
> www.iol.unh.edu
  

Hi Brandon,
Following some cleanup patches I have posted against examples/fips, I would like to take enabling AES_CBC in fips validation.
Please let me know if you/anyone have already have WIP for the same, before I proceed.

Thanks,
Gowrishankar

> -----Original Message-----
> From: Brandon Lo <blo@iol.unh.edu>
> Sent: Thursday, April 14, 2022 7:12 PM
> To: dev <dev@dpdk.org>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> Power, Ciara <ciara.power@intel.com>
> Subject: [EXT] Re: [PATCH v3 0/5] Add JSON vector set support to fips
> validation
> 
> External Email
> 
> ----------------------------------------------------------------------
> Adding the dev mailing list back into this discussion.
> 
> On Wed, Apr 13, 2022 at 9:13 AM Brandon Lo <blo@iol.unh.edu> wrote:
> >
> > Hi guys,
> >
> > Lincoln and I would like to know if we can get this patch set looked
> > at and merged before submitting the rest of the algorithms. So far,
> > I've worked on implementing the HMAC and CMAC tests, but I keep
> > getting pulled away by some requests from the community. This patchset
> > does not seem to break backward compatibility, so merging it will only
> > lead to more coverage from the UNH lab. It may also be easier to
> > review since it isn't going to be one huge patchset that needs to be
> > looked at in the future.
> >
> > On Thu, Feb 17, 2022 at 7:47 AM Brandon Lo <blo@iol.unh.edu> wrote:
> > >
> > > On Fri, Feb 11, 2022 at 9:16 AM Brandon Lo <blo@iol.unh.edu> wrote:
> > > > I only have the AES-GCM algorithm implemented because the current
> > > > implementations of the other algorithms require some extra
> > > > information than what comes with the JSON format in the API.
> > > > For example, I couldn't find the JSON counterpart for things like
> > > > fips_validation_sha.c's "MD =" or "Seed =" as well as
> > > > fips_validation_ccm.c's extra test types like CCM-DVPT, CCM-VADT,
> etc.
> > > > just to name a few.
> > > > This could very well be due to my inexperience with the FIPS
> > > > validation, and I definitely plan to take another look at it again.
> > > >
> > > > My assumption is that the JSON version of FIPS validation files
> > > > isn't used as much as the old CAVP format, so I am more aiming
> > > > towards getting something working in the lab first and then
> > > > expanding on it later.
> > >
> > > Hi all,
> > >
> > > Could I get someone to look at this patch set?
> > > The UNH lab is ready to deploy FIPS testing on patches that affect
> > > the crypto portion of DPDK.
> > >
> > > Thanks,
> > > Brandon
> > >
> > >
> > > --
> > > Brandon Lo
> > > UNH InterOperability Laboratory
> > > 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu
> > > https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__www.iol.unh.edu&
> > > d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr-
> g7yUFhtOio8r2Rtm13Aqe4WVp_S
> > >
> _gHpcu6KFVo&m=35t4n1T3FnlAkNla3EmGLgWSAhIknbuvLgguNAXKjN0xCMs
> cV7HXyJ
> > >
> 95BftFMJJJ&s=GVCZy3E9sE9H23TSCEcLyQoT4zxNQ4pyameEW76PZno&e=
> >
> >
> >
> > --
> > Brandon Lo
> > UNH InterOperability Laboratory
> > 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu
> > https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__www.iol.unh.edu&d=
> > DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr-
> g7yUFhtOio8r2Rtm13Aqe4WVp_S_gHp
> >
> cu6KFVo&m=35t4n1T3FnlAkNla3EmGLgWSAhIknbuvLgguNAXKjN0xCMscV7H
> XyJ95BftF
> > MJJJ&s=GVCZy3E9sE9H23TSCEcLyQoT4zxNQ4pyameEW76PZno&e=
> 
> 
> 
> --
> Brandon Lo
> UNH InterOperability Laboratory
> 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu
> https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__www.iol.unh.edu&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr-
> g7yUFhtOio8r2Rtm13Aqe4WVp_S_gHpcu6KFVo&m=35t4n1T3FnlAkNla3EmG
> LgWSAhIknbuvLgguNAXKjN0xCMscV7HXyJ95BftFMJJJ&s=GVCZy3E9sE9H23T
> SCEcLyQoT4zxNQ4pyameEW76PZno&e=
  

Hi Gowrishankar,

I apologize for the late response. I have not worked on the AES-CBC
implementation, so you are free to go ahead.
Please let me know if you run into any issues that I can help with.

Thanks,
Brandon

On Thu, Apr 21, 2022 at 4:02 AM Gowrishankar Muthukrishnan
<gmuthukrishn@marvell.com> wrote:
>
> Hi Brandon,
> Following some cleanup patches I have posted against examples/fips, I would like to take enabling AES_CBC in fips validation.
> Please let me know if you/anyone have already have WIP for the same, before I proceed.
>
> Thanks,
> Gowrishankar
>
> > -----Original Message-----
> > From: Brandon Lo <blo@iol.unh.edu>
> > Sent: Thursday, April 14, 2022 7:12 PM
> > To: dev <dev@dpdk.org>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> > Power, Ciara <ciara.power@intel.com>
> > Subject: [EXT] Re: [PATCH v3 0/5] Add JSON vector set support to fips
> > validation
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > Adding the dev mailing list back into this discussion.
> >
> > On Wed, Apr 13, 2022 at 9:13 AM Brandon Lo <blo@iol.unh.edu> wrote:
> > >
> > > Hi guys,
> > >
> > > Lincoln and I would like to know if we can get this patch set looked
> > > at and merged before submitting the rest of the algorithms. So far,
> > > I've worked on implementing the HMAC and CMAC tests, but I keep
> > > getting pulled away by some requests from the community. This patchset
> > > does not seem to break backward compatibility, so merging it will only
> > > lead to more coverage from the UNH lab. It may also be easier to
> > > review since it isn't going to be one huge patchset that needs to be
> > > looked at in the future.
> > >
> > > On Thu, Feb 17, 2022 at 7:47 AM Brandon Lo <blo@iol.unh.edu> wrote:
> > > >
> > > > On Fri, Feb 11, 2022 at 9:16 AM Brandon Lo <blo@iol.unh.edu> wrote:
> > > > > I only have the AES-GCM algorithm implemented because the current
> > > > > implementations of the other algorithms require some extra
> > > > > information than what comes with the JSON format in the API.
> > > > > For example, I couldn't find the JSON counterpart for things like
> > > > > fips_validation_sha.c's "MD =" or "Seed =" as well as
> > > > > fips_validation_ccm.c's extra test types like CCM-DVPT, CCM-VADT,
> > etc.
> > > > > just to name a few.
> > > > > This could very well be due to my inexperience with the FIPS
> > > > > validation, and I definitely plan to take another look at it again.
> > > > >
> > > > > My assumption is that the JSON version of FIPS validation files
> > > > > isn't used as much as the old CAVP format, so I am more aiming
> > > > > towards getting something working in the lab first and then
> > > > > expanding on it later.
> > > >
> > > > Hi all,
> > > >
> > > > Could I get someone to look at this patch set?
> > > > The UNH lab is ready to deploy FIPS testing on patches that affect
> > > > the crypto portion of DPDK.
> > > >
> > > > Thanks,
> > > > Brandon
> > > >
> > > >
> > > > --
> > > > Brandon Lo
> > > > UNH InterOperability Laboratory
> > > > 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu
> > > > https://urldefense.proofpoint.com/v2/url?u=http-
> > 3A__www.iol.unh.edu&
> > > > d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr-
> > g7yUFhtOio8r2Rtm13Aqe4WVp_S
> > > >
> > _gHpcu6KFVo&m=35t4n1T3FnlAkNla3EmGLgWSAhIknbuvLgguNAXKjN0xCMs
> > cV7HXyJ
> > > >
> > 95BftFMJJJ&s=GVCZy3E9sE9H23TSCEcLyQoT4zxNQ4pyameEW76PZno&e=
> > >
> > >
> > >
> > > --
> > > Brandon Lo
> > > UNH InterOperability Laboratory
> > > 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu
> > > https://urldefense.proofpoint.com/v2/url?u=http-
> > 3A__www.iol.unh.edu&d=
> > > DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr-
> > g7yUFhtOio8r2Rtm13Aqe4WVp_S_gHp
> > >
> > cu6KFVo&m=35t4n1T3FnlAkNla3EmGLgWSAhIknbuvLgguNAXKjN0xCMscV7H
> > XyJ95BftF
> > > MJJJ&s=GVCZy3E9sE9H23TSCEcLyQoT4zxNQ4pyameEW76PZno&e=
> >
> >
> >
> > --
> > Brandon Lo
> > UNH InterOperability Laboratory
> > 21 Madbury Rd, Suite 100, Durham, NH 03824 blo@iol.unh.edu
> > https://urldefense.proofpoint.com/v2/url?u=http-
> > 3A__www.iol.unh.edu&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr-
> > g7yUFhtOio8r2Rtm13Aqe4WVp_S_gHpcu6KFVo&m=35t4n1T3FnlAkNla3EmG
> > LgWSAhIknbuvLgguNAXKjN0xCMscV7HXyJ95BftFMJJJ&s=GVCZy3E9sE9H23T
> > SCEcLyQoT4zxNQ4pyameEW76PZno&e=