mbox series

[v2,0/2] eal: support configuring runtime directory

Message ID 20220205171101.7673-1-stephen@networkplumber.org (mailing list archive)
Headers
Series eal: support configuring runtime directory |

Message

Stephen Hemminger Feb. 5, 2022, 5:10 p.m. UTC 
  Found this while exploring running a DPDK service with systemd
container environment. It helps if the place DPDK puts its runtime
directory is configurable.

v2 - fix dpdk_telemetry.py to use append dpdk

Stephen Hemminger (2):
  eal: remove size for eal_set_runtime_dir
  eal: support systemd service convention for runtime directory

 lib/eal/common/eal_common_config.c |  7 ++-----
 lib/eal/common/eal_private.h       |  4 +---
 lib/eal/freebsd/eal.c              |  2 +-
 lib/eal/linux/eal.c                | 25 ++++++++++++++-----------
 usertools/dpdk-telemetry.py        | 10 +++++++---
 5 files changed, 25 insertions(+), 23 deletions(-)

Comments

Stephen Hemminger Feb. 8, 2022, 4:43 a.m. UTC | #1 
On Sat,  5 Feb 2022 09:10:59 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:

> Found this while exploring running a DPDK service with systemd
> container environment. It helps if the place DPDK puts its runtime
> directory is configurable.
> 
> v2 - fix dpdk_telemetry.py to use append dpdk
> 
> Stephen Hemminger (2):
>   eal: remove size for eal_set_runtime_dir
>   eal: support systemd service convention for runtime directory
> 
>  lib/eal/common/eal_common_config.c |  7 ++-----
>  lib/eal/common/eal_private.h       |  4 +---
>  lib/eal/freebsd/eal.c              |  2 +-
>  lib/eal/linux/eal.c                | 25 ++++++++++++++-----------
>  usertools/dpdk-telemetry.py        | 10 +++++++---
>  5 files changed, 25 insertions(+), 23 deletions(-)
> 

Bruce is it worth moving this (and the sysfs logic) from
Linux only into unix/ directory and have common code with FreeBSD?
Bruce Richardson Feb. 8, 2022, 10:48 a.m. UTC | #2 
On Mon, Feb 07, 2022 at 08:43:48PM -0800, Stephen Hemminger wrote:
> On Sat,  5 Feb 2022 09:10:59 -0800
> Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> > Found this while exploring running a DPDK service with systemd
> > container environment. It helps if the place DPDK puts its runtime
> > directory is configurable.
> > 
> > v2 - fix dpdk_telemetry.py to use append dpdk
> > 
> > Stephen Hemminger (2):
> >   eal: remove size for eal_set_runtime_dir
> >   eal: support systemd service convention for runtime directory
> > 
> >  lib/eal/common/eal_common_config.c |  7 ++-----
> >  lib/eal/common/eal_private.h       |  4 +---
> >  lib/eal/freebsd/eal.c              |  2 +-
> >  lib/eal/linux/eal.c                | 25 ++++++++++++++-----------
> >  usertools/dpdk-telemetry.py        | 10 +++++++---
> >  5 files changed, 25 insertions(+), 23 deletions(-)
> > 
> 
> Bruce is it worth moving this (and the sysfs logic) from
> Linux only into unix/ directory and have common code with FreeBSD?
> 
The "create_runtime_dir()" function is indeed a copy-paste between the two
OS's so looks like it should be moved into a common unix implementation.