mbox series

[v1,0/4] sched: HQoS Library cleanup.

Message ID 20220218074148.2549134-1-megha.ajmera@intel.com (mailing list archive)
Headers
Series sched: HQoS Library cleanup. |

Message

Ajmera, Megha Feb. 18, 2022, 7:41 a.m. UTC 
  v1: 
* Removed unused HQoS #defines from rte_config.
* Enabled stats in HQoS by default.
* TC subscription for best effort queues is always enabled in HQoS library.
* VECTOR defines are removed from HQoS library.


Megha Ajmera (4):
  sched: Cleanup qos scheduler defines from rte_config
  sched: Always enable stats in HQoS library.
  sched: Always enable best effort TC oversubscription in HQoS library.
  sched: Removed code defined under VECTOR #Defines.

 config/rte_config.h                        |   7 -
 doc/guides/sample_app_ug/qos_scheduler.rst |   3 +-
 lib/sched/rte_sched.c                      | 156 +--------------------
 3 files changed, 3 insertions(+), 163 deletions(-)

Comments

David Marchand Feb. 18, 2022, 8:11 a.m. UTC | #1 
On Fri, Feb 18, 2022 at 8:42 AM Megha Ajmera <megha.ajmera@intel.com> wrote:
>
> v1:
> * Removed unused HQoS #defines from rte_config.
> * Enabled stats in HQoS by default.
> * TC subscription for best effort queues is always enabled in HQoS library.
> * VECTOR defines are removed from HQoS library.

This series does not apply on main, so we won't get tests from CI.

Is this a followup of patches?
https://patchwork.dpdk.org/project/dpdk/patch/20220121181459.1599739-1-megha.ajmera@intel.com/
(<-- which should be marked superseded..)
https://patchwork.dpdk.org/project/dpdk/patch/20220125102105.1719667-1-megha.ajmera@intel.com/

I prefer to ask because I did not see much public discussion.
Commitlogs are poor/nonexistent and the cover letter does not explain
the rationale.
Ajmera, Megha Feb. 18, 2022, 9:41 a.m. UTC | #2 
Hi David,

I have rebased patch-set with latest main branch code resolving the conflicts. Also updated cover letter.

Regards,
Megha

-----Original Message-----
From: David Marchand <david.marchand@redhat.com> 
Sent: Friday, February 18, 2022 1:42 PM
To: Ajmera, Megha <megha.ajmera@intel.com>
Cc: dev <dev@dpdk.org>; Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v1 0/4] sched: HQoS Library cleanup.

On Fri, Feb 18, 2022 at 8:42 AM Megha Ajmera <megha.ajmera@intel.com> wrote:
>
> v1:
> * Removed unused HQoS #defines from rte_config.
> * Enabled stats in HQoS by default.
> * TC subscription for best effort queues is always enabled in HQoS library.
> * VECTOR defines are removed from HQoS library.

This series does not apply on main, so we won't get tests from CI.

Is this a followup of patches?
https://patchwork.dpdk.org/project/dpdk/patch/20220121181459.1599739-1-megha.ajmera@intel.com/
(<-- which should be marked superseded..) https://patchwork.dpdk.org/project/dpdk/patch/20220125102105.1719667-1-megha.ajmera@intel.com/

I prefer to ask because I did not see much public discussion.
Commitlogs are poor/nonexistent and the cover letter does not explain the rationale.


--
David Marchand