From patchwork Sun Feb 20 00:51:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 107849 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AD31A00C2; Sun, 20 Feb 2022 01:51:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B00B140395; Sun, 20 Feb 2022 01:51:45 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id AAFA94014E for ; Sun, 20 Feb 2022 01:51:44 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id d187so5495476pfa.10 for ; Sat, 19 Feb 2022 16:51:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vszabs5L4nhYc8wlPoS3c/TSeJ4sqCMqD88aIeAjd+c=; b=aa7ofvwysf38eXAKRO2g+c4D/sE+HZoqJIwIb5mCYYg9H/lNQmm0alPQSs1iAA9Ds3 vOQJJDOFaGtDh6YEjBBoVTnejuMvrSxd5Q7oNZX4EhNJ/tyEW0UDnFtI8nw7X+qEn7Ji ++49qHYPglwMptuUXYxjCqp2LzUAe0Hr8cATlRKVSvuS1EyFqPPdVv0vtlxq+18ivtsB hmxe2BGeiDzDAoK2S16xDWwjBZs34hFWd90FUbkjP3ubP4UCOyqmQTjFMCH/CHkHTWOA Nr/fDZEue7hQ5hivNruMv9UCbX0dMR8WJWgujunrcnjTzvP1PEhrwopCnBhN4GP+PLMz mHGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Vszabs5L4nhYc8wlPoS3c/TSeJ4sqCMqD88aIeAjd+c=; b=Imfwrr78fCEWHWcNumJRvVYeHiButs6li0O9sYmdVgiOadPQsBtpHyRdtA8GLj0ddm 6pNMn4igYxWOR2GIcOMf64qfgGGJEs40lYtn3+fhYySaWucaGp2qe3HO8GSQhB5KK37E HdN6L4S0uQ0ot7dZYR9TqMeld7VHielzmliStXutrIR62IGTdHeMG/OL6N5nb2OYq6H3 tj4cgji5t/5uFdcy+DWHpNiuRObtjPlWTHriwpOwo+fAIgptVnRUJv4ZSK8YO0YDTPFw b44IjEPulhKebFvzXvjvlF7Z9DfEPJvg7rJVMiyYeyoqSgZpyLfsCE3E0yX5fE++s5XF gxSA== X-Gm-Message-State: AOAM530pbR9gcpYBtklYvGZYM7flEIaZ3O5IRKAigIQxhRrFpPTQYHwV 8gVdCPM79xoQpfNJ2irc4KRF6bOzgaKnp1Iy X-Google-Smtp-Source: ABdhPJzk5MrZmd3FGfhbti1daJaqj1MjqAEytjtsuq99L8P8JVOSqt5MefxWYWjCSo9iagiQpiDwtw== X-Received: by 2002:a63:c051:0:b0:372:d4a5:7033 with SMTP id z17-20020a63c051000000b00372d4a57033mr11312724pgi.303.1645318303071; Sat, 19 Feb 2022 16:51:43 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id f7sm8129695pfc.0.2022.02.19.16.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Feb 2022 16:51:42 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 0/7] fix more unnecessary null checks Date: Sat, 19 Feb 2022 16:51:33 -0800 Message-Id: <20220220005140.78713-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220219234322.61309-1-stephen@networkplumber.org> References: <20220219234322.61309-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thomas suggested there are some other functions that could use the nullfree cleanup; this covers the rest of the story. v2 - fix spelling typo and add more functions Stephen Hemminger (7): cocci/nullfree: add more functions acl: remove unnecessary null checks lpm: remove unnecessary NULL checks lib: document existing free functions test: remove unecessary NULL checks before free fips_validation: remove unnecessary NULL check event/sw: remove unnecessary NULL check app/test/test_acl.c | 12 ++-- app/test/test_cmdline_lib.c | 3 +- app/test/test_cryptodev.c | 9 +-- app/test/test_cryptodev_asym.c | 30 +++------ app/test/test_cryptodev_blockcipher.c | 3 +- app/test/test_func_reentrancy.c | 6 +- app/test/test_hash.c | 3 +- devtools/cocci/nullfree.cocci | 63 +++++++++++++++++-- drivers/event/sw/sw_evdev.c | 6 +- examples/fips_validation/fips_dev_self_test.c | 3 +- lib/acl/rte_acl.h | 1 + lib/compressdev/rte_comp.h | 1 + lib/cryptodev/rte_crypto.h | 1 + lib/eal/include/rte_interrupts.h | 4 +- lib/efd/rte_efd.h | 1 + lib/eventdev/rte_event_ring.h | 1 + lib/lpm/rte_lpm.h | 1 + lib/lpm/rte_lpm6.h | 1 + lib/member/rte_member.h | 1 + lib/rib/rte_rib.h | 1 + lib/rib/rte_rib6.h | 1 + lib/stack/rte_stack.h | 1 + lib/table/rte_swx_table_wm.c | 3 +- lib/table/rte_table_acl.c | 15 ++--- lib/telemetry/rte_telemetry.h | 2 +- 25 files changed, 103 insertions(+), 70 deletions(-)