Message ID | 20220519080415.1577680-1-andrew.rybchenko@oktetlabs.ru (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99238A0503; Thu, 19 May 2022 10:04:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A40E427F2; Thu, 19 May 2022 10:04:43 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C5E2342686 for <dev@dpdk.org>; Thu, 19 May 2022 10:04:41 +0200 (CEST) Received: by shelob.oktetlabs.ru (Postfix, from userid 115) id 77A178F; Thu, 19 May 2022 11:04:41 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mail1.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17]) by shelob.oktetlabs.ru (Postfix) with ESMTP id E3D5C8A; Thu, 19 May 2022 11:04:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E3D5C8A Authentication-Results: shelob.oktetlabs.ru/E3D5C8A; dkim=none; dkim-atps=neutral From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> To: Pankaj Gupta <pagupta@vmware.com>, Jochen Behrens <jbehrens@vmware.com> Cc: dev@dpdk.org Subject: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Date: Thu, 19 May 2022 11:04:06 +0300 Message-Id: <20220519080415.1577680-1-andrew.rybchenko@oktetlabs.ru> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220503042257.15626-1-pagupta@vmware.com> References: <20220503042257.15626-1-pagupta@vmware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
net/vmxnet3: support versions 5 and 6
|
|
Message
Andrew Rybchenko
May 19, 2022, 8:04 a.m. UTC
v6 (Andrew Rybchenko): Minor style changes in patches description Split FW version get patch to have callbacks reorder seperately Minor fix in FW version get patch to put callback definition, assignment and implementation just after device info get v5: Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c User RETA instead of reta in commit message Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c v4: Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error in initialization for rxDataRing feature" to "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")" v3: adding Reviewed-by info in all the patches v2: address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru Pankaj Gupta (9): net/vmxnet3: add version 5 support net/vmxnet3: implement RETA query and RETA update net/vmxnet3: add Rx queue usage count utility net/vmxnet3: fix ethdev callbacks init order net/vmxnet3: report HW version on FW version get net/vmxnet3: add version 6 support net/vmxnet3: advertise RETA size in device info net/vmxnet3: set packet type for fragmented packet net/vmxnet3: fix merge error in Rx data ring initialization drivers/net/vmxnet3/base/vmxnet3_defs.h | 73 ++++- drivers/net/vmxnet3/vmxnet3_ethdev.c | 339 +++++++++++++++++++----- drivers/net/vmxnet3/vmxnet3_ethdev.h | 15 +- drivers/net/vmxnet3/vmxnet3_rxtx.c | 49 +++- 4 files changed, 388 insertions(+), 88 deletions(-)
Comments
Hi Pankaj, I did final cleanup before applying the patch series, but realized that release notes update is missing. Please, pick up my changes and amend patches which support new features with release notes update in the documentation. Everything else LGTM now. Thanks, Andrew. On 5/19/22 11:04, Andrew Rybchenko wrote: > v6 (Andrew Rybchenko): > Minor style changes in patches description > Split FW version get patch to have callbacks reorder seperately > Minor fix in FW version get patch to put callback definition, > assignment and implementation just after device info get > > v5: > Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c > User RETA instead of reta in commit message > Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c > > v4: > Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error > in initialization for rxDataRing feature" to > "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")" > > v3: > adding Reviewed-by info in all the patches > > v2: > address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru > > Pankaj Gupta (9): > net/vmxnet3: add version 5 support > net/vmxnet3: implement RETA query and RETA update > net/vmxnet3: add Rx queue usage count utility > net/vmxnet3: fix ethdev callbacks init order > net/vmxnet3: report HW version on FW version get > net/vmxnet3: add version 6 support > net/vmxnet3: advertise RETA size in device info > net/vmxnet3: set packet type for fragmented packet > net/vmxnet3: fix merge error in Rx data ring initialization > > drivers/net/vmxnet3/base/vmxnet3_defs.h | 73 ++++- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 339 +++++++++++++++++++----- > drivers/net/vmxnet3/vmxnet3_ethdev.h | 15 +- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 49 +++- > 4 files changed, 388 insertions(+), 88 deletions(-) >
Hi Andrew, New features were introduced in following two patches so I will update release_22_07.rst for these two patches. [PATCH v6 1/9] net/vmxnet3: add version 5 support [PATCH v6 6/9] net/vmxnet3: add version 6 support Let me know if I am missing anything. Thanks, Pankaj From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Date: Thursday, May 19, 2022 at 1:07 AM To: Pankaj Gupta <pagupta@vmware.com>, Jochen Behrens <jbehrens@vmware.com> Cc: dev@dpdk.org <dev@dpdk.org> Subject: Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 ⚠ External Email Hi Pankaj, I did final cleanup before applying the patch series, but realized that release notes update is missing. Please, pick up my changes and amend patches which support new features with release notes update in the documentation. Everything else LGTM now. Thanks, Andrew. On 5/19/22 11:04, Andrew Rybchenko wrote: > v6 (Andrew Rybchenko): > Minor style changes in patches description > Split FW version get patch to have callbacks reorder seperately > Minor fix in FW version get patch to put callback definition, > assignment and implementation just after device info get > > v5: > Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c > User RETA instead of reta in commit message > Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c > > v4: > Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error > in initialization for rxDataRing feature" to > "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")" > > v3: > adding Reviewed-by info in all the patches > > v2: > address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru > > Pankaj Gupta (9): > net/vmxnet3: add version 5 support > net/vmxnet3: implement RETA query and RETA update > net/vmxnet3: add Rx queue usage count utility > net/vmxnet3: fix ethdev callbacks init order > net/vmxnet3: report HW version on FW version get > net/vmxnet3: add version 6 support > net/vmxnet3: advertise RETA size in device info > net/vmxnet3: set packet type for fragmented packet > net/vmxnet3: fix merge error in Rx data ring initialization > > drivers/net/vmxnet3/base/vmxnet3_defs.h | 73 ++++- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 339 +++++++++++++++++++----- > drivers/net/vmxnet3/vmxnet3_ethdev.h | 15 +- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 49 +++- > 4 files changed, 388 insertions(+), 88 deletions(-) >
Hi Pankai, I'd consider a patch which adds RETA controls as well. IMHO it is a major feature which could be interesting to end users. Regards, Andrew. On 5/23/22 23:56, Pankaj Gupta wrote: > Hi Andrew, > > New features were introduced in following two patches so I will update > release_22_07.rst for these two patches. > > [PATCH v6 1/9] net/vmxnet3: add version 5 support > > [PATCH v6 6/9] net/vmxnet3: add version 6 support > > Let me know if I am missing anything. > > Thanks, > > Pankaj > > *From: *Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> > *Date: *Thursday, May 19, 2022 at 1:07 AM > *To: *Pankaj Gupta <pagupta@vmware.com>, Jochen Behrens > <jbehrens@vmware.com> > *Cc: *dev@dpdk.org <dev@dpdk.org> > *Subject: *Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 > > ⚠External Email > > Hi Pankaj, > > I did final cleanup before applying the patch series, but > realized that release notes update is missing. > Please, pick up my changes and amend patches which support > new features with release notes update in the documentation. > > Everything else LGTM now. > > Thanks, > Andrew. > > On 5/19/22 11:04, Andrew Rybchenko wrote: >> v6 (Andrew Rybchenko): >> Minor style changes in patches description >> Split FW version get patch to have callbacks reorder seperately >> Minor fix in FW version get patch to put callback definition, >> assignment and implementation just after device info get >> >> v5: >> Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c >> User RETA instead of reta in commit message >> Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c >> >> v4: >> Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error >> in initialization for rxDataRing feature" to >> "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")" >> >> v3: >> adding Reviewed-by info in all the patches >> >> v2: >> address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru >> >> Pankaj Gupta (9): >> net/vmxnet3: add version 5 support >> net/vmxnet3: implement RETA query and RETA update >> net/vmxnet3: add Rx queue usage count utility >> net/vmxnet3: fix ethdev callbacks init order >> net/vmxnet3: report HW version on FW version get >> net/vmxnet3: add version 6 support >> net/vmxnet3: advertise RETA size in device info >> net/vmxnet3: set packet type for fragmented packet >> net/vmxnet3: fix merge error in Rx data ring initialization >> >> drivers/net/vmxnet3/base/vmxnet3_defs.h | 73 ++++- >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 339 +++++++++++++++++++----- >> drivers/net/vmxnet3/vmxnet3_ethdev.h | 15 +- >> drivers/net/vmxnet3/vmxnet3_rxtx.c | 49 +++- >> 4 files changed, 388 insertions(+), 88 deletions(-) >> > > > ________________________________ > > ⚠External Email: This email originated from outside of the organization. > Do not click links or open attachments unless you recognize the sender. >