mbox series

[v2,0/5] baseband/fpga_5gnr: maintenance changes to fpga_5gnr PMD

Message ID 20220520030556.3475133-1-hernan.vargas@intel.com (mailing list archive)
Headers
Series baseband/fpga_5gnr: maintenance changes to fpga_5gnr PMD |

Message

Hernan Vargas May 20, 2022, 3:05 a.m. UTC 
  Few PMD changes as part of maintenance of the driver. These are not required on the stable variants. Aiming to upstream these in 22.07.
Updated with review suggestions.

Hernan (5):
  baseband/fpga_5gnr_fec: remove FLR timeout
  baseband/fpga_5gnr_fec: add FPGA Mutex
  baseband/fpga_5gnr_fec: add check for HARQ input length
  baseband/fpga_5gnr_fec: enable validate LDPC enc/dec
  baseband/fpga_5gnr_fec: remove filler from HARQ

 app/test-bbdev/test_bbdev_perf.c              |   4 -
 .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h    |   9 +-
 .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 581 ++++++++++++++----
 .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h     |   2 -
 4 files changed, 451 insertions(+), 145 deletions(-)

Comments

Akhil Goyal May 31, 2022, 6:06 p.m. UTC | #1 
Hi Nicolas,

Can you review the series and ack?

Regards,
Akhil

> Few PMD changes as part of maintenance of the driver. These are not required
> on the stable variants. Aiming to upstream these in 22.07.
> Updated with review suggestions.
> 
> Hernan (5):
>   baseband/fpga_5gnr_fec: remove FLR timeout
>   baseband/fpga_5gnr_fec: add FPGA Mutex
>   baseband/fpga_5gnr_fec: add check for HARQ input length
>   baseband/fpga_5gnr_fec: enable validate LDPC enc/dec
>   baseband/fpga_5gnr_fec: remove filler from HARQ
> 
>  app/test-bbdev/test_bbdev_perf.c              |   4 -
>  .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h    |   9 +-
>  .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 581 ++++++++++++++----
>  .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h     |   2 -
>  4 files changed, 451 insertions(+), 145 deletions(-)
> 
> --
> 2.25.1
Chautru, Nicolas May 31, 2022, 6:12 p.m. UTC | #2 
Hi Akhil, 
I believe I did ack it here https://patches.dpdk.org/project/dpdk/patch/20220520030556.3475133-6-hernan.vargas@intel.com/

But doing it formally here below

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, May 31, 2022 11:07 AM
> To: Vargas, Hernan <hernan.vargas@intel.com>; dev@dpdk.org;
> trix@redhat.com; Chautru, Nicolas <nicolas.chautru@intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [EXT] [PATCH v2 0/5] baseband/fpga_5gnr: maintenance changes
> to fpga_5gnr PMD
> 
> Hi Nicolas,
> 
> Can you review the series and ack?
> 
> Regards,
> Akhil
> 
> > Few PMD changes as part of maintenance of the driver. These are not
> > required on the stable variants. Aiming to upstream these in 22.07.
> > Updated with review suggestions.
> >


Reviewed-by: Nicolas Chautru <nicolas.chautru@intel.com>

> > Hernan (5):
> >   baseband/fpga_5gnr_fec: remove FLR timeout
> >   baseband/fpga_5gnr_fec: add FPGA Mutex
> >   baseband/fpga_5gnr_fec: add check for HARQ input length
> >   baseband/fpga_5gnr_fec: enable validate LDPC enc/dec
> >   baseband/fpga_5gnr_fec: remove filler from HARQ
> >
> >  app/test-bbdev/test_bbdev_perf.c              |   4 -
> >  .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h    |   9 +-
> >  .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 581 ++++++++++++++----
> >  .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h     |   2 -
> >  4 files changed, 451 insertions(+), 145 deletions(-)
> >
> > --
> > 2.25.1
Akhil Goyal May 31, 2022, 6:17 p.m. UTC | #3 
> Hi Akhil,
> I believe I did ack it here https://patches.dpdk.org/project/dpdk/patch/20220520030556.3475133-6-hernan.vargas@intel.com/
> 

That was only on the 5th patch not the entire series.
While giving ack to a series, please mention it explicitly or 
Send ack on coverletter.

> But doing it formally here below

Thanks.
> 
> >
> > Hi Nicolas,
> >
> > Can you review the series and ack?
> >
> > Regards,
> > Akhil
> >
> > > Few PMD changes as part of maintenance of the driver. These are not
> > > required on the stable variants. Aiming to upstream these in 22.07.
> > > Updated with review suggestions.
> > >
> 
> 
> Reviewed-by: Nicolas Chautru <nicolas.chautru@intel.com>
> 
> > > Hernan (5):
> > >   baseband/fpga_5gnr_fec: remove FLR timeout
> > >   baseband/fpga_5gnr_fec: add FPGA Mutex
> > >   baseband/fpga_5gnr_fec: add check for HARQ input length
> > >   baseband/fpga_5gnr_fec: enable validate LDPC enc/dec
> > >   baseband/fpga_5gnr_fec: remove filler from HARQ
> > >
> > >  app/test-bbdev/test_bbdev_perf.c              |   4 -
> > >  .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h    |   9 +-
> > >  .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 581 ++++++++++++++----
> > >  .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h     |   2 -
> > >  4 files changed, 451 insertions(+), 145 deletions(-)
> > >
> > > --
> > > 2.25.1
Akhil Goyal May 31, 2022, 6:30 p.m. UTC | #4 
> > > Few PMD changes as part of maintenance of the driver. These are not
> > > required on the stable variants. Aiming to upstream these in 22.07.
> > > Updated with review suggestions.
> > >
> 
> 
> Reviewed-by: Nicolas Chautru <nicolas.chautru@intel.com>
Series Applied to dpdk-next-crypto

Thanks.