mbox series

[v4,00/12] cryptodev: rsa, dh, ecdh changes

Message ID 20220531040439.15862-1-arkadiuszx.kusztal@intel.com (mailing list archive)
Headers
Series cryptodev: rsa, dh, ecdh changes |

Message

Arkadiusz Kusztal May 31, 2022, 4:04 a.m. UTC
  This patchset introduces some of changes discussed on mailing list for 22.07 release in cryptodev asym.

Key changes:

- It fixes API for RSA (expescially signature paddings)
- Adds Elliptic-Curve Diffie-Hellman
- Adds Eliiptic-Curve point verification
- Adds RSA missing padding fields
- Adds asym op flags
- Fixes many API comments (like EC curves)

v4:
- fixed shared build problem
- added ABI ignore entry for xform

Arek Kusztal (12):
  cryptodev: redefine ec group enum
  cryptodev: separate key exchange operation enum
  cryptodev: remove comment about using ephemeral key in dsa
  cryptodev: clarify usage of private key in dh
  cryptodev: move dh type from xform to dh op
  cryptodev: add elliptic curve diffie hellman
  cryptodev: add public key verify option
  cryptodev: add asym op flags
  cryptodev: clarify usage of rsa padding hash
  cryptodev: move RSA padding into separate struct
  cryptodev: clarify rsa verify with none padding
  cryptodev: add salt length and optional label

 app/test/test_cryptodev_asym.c               |  63 ++++----
 devtools/libabigail.abignore                 |   3 +
 drivers/common/cpt/cpt_ucode_asym.h          |   4 +-
 drivers/crypto/cnxk/cnxk_ae.h                |   8 +-
 drivers/crypto/octeontx/otx_cryptodev_ops.c  |   4 +-
 drivers/crypto/openssl/rte_openssl_pmd.c     |  17 +--
 drivers/crypto/openssl/rte_openssl_pmd_ops.c |  33 +---
 drivers/crypto/qat/qat_asym.c                |  12 +-
 lib/cryptodev/rte_crypto_asym.h              | 217 ++++++++++++++++++++-------
 lib/cryptodev/rte_cryptodev.c                |  15 +-
 lib/cryptodev/rte_cryptodev.h                |   4 +-
 lib/cryptodev/version.map                    |   1 +
 12 files changed, 237 insertions(+), 144 deletions(-)
  

Comments

Fan Zhang May 31, 2022, 7:49 a.m. UTC | #1
> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Tuesday, May 31, 2022 5:04 AM
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Kusztal,
> ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v4 00/12] cryptodev: rsa, dh, ecdh changes
> 
> This patchset introduces some of changes discussed on mailing list for 22.07
> release in cryptodev asym.
> 
> Key changes:
> 
> - It fixes API for RSA (expescially signature paddings)
> - Adds Elliptic-Curve Diffie-Hellman
> - Adds Eliiptic-Curve point verification
> - Adds RSA missing padding fields
> - Adds asym op flags
> - Fixes many API comments (like EC curves)
> 
> v4:
> - fixed shared build problem
> - added ABI ignore entry for xform
> 
> Arek Kusztal (12):
>   cryptodev: redefine ec group enum
>   cryptodev: separate key exchange operation enum
>   cryptodev: remove comment about using ephemeral key in dsa
>   cryptodev: clarify usage of private key in dh
>   cryptodev: move dh type from xform to dh op
>   cryptodev: add elliptic curve diffie hellman
>   cryptodev: add public key verify option
>   cryptodev: add asym op flags
>   cryptodev: clarify usage of rsa padding hash
>   cryptodev: move RSA padding into separate struct
>   cryptodev: clarify rsa verify with none padding
>   cryptodev: add salt length and optional label
> 
>  app/test/test_cryptodev_asym.c               |  63 ++++----
>  devtools/libabigail.abignore                 |   3 +
>  drivers/common/cpt/cpt_ucode_asym.h          |   4 +-
>  drivers/crypto/cnxk/cnxk_ae.h                |   8 +-
>  drivers/crypto/octeontx/otx_cryptodev_ops.c  |   4 +-
>  drivers/crypto/openssl/rte_openssl_pmd.c     |  17 +--
>  drivers/crypto/openssl/rte_openssl_pmd_ops.c |  33 +---
>  drivers/crypto/qat/qat_asym.c                |  12 +-
>  lib/cryptodev/rte_crypto_asym.h              | 217 ++++++++++++++++++++-----
> --
>  lib/cryptodev/rte_cryptodev.c                |  15 +-
>  lib/cryptodev/rte_cryptodev.h                |   4 +-
>  lib/cryptodev/version.map                    |   1 +
>  12 files changed, 237 insertions(+), 144 deletions(-)
> 
> --
> 2.13.6
Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com>
  
Akhil Goyal May 31, 2022, 11:52 a.m. UTC | #2
> This patchset introduces some of changes discussed on mailing list for 22.07
> release in cryptodev asym.
> 
> Key changes:
> 
> - It fixes API for RSA (expescially signature paddings)
> - Adds Elliptic-Curve Diffie-Hellman
> - Adds Eliiptic-Curve point verification
> - Adds RSA missing padding fields
> - Adds asym op flags
> - Fixes many API comments (like EC curves)
> 
> v4:
> - fixed shared build problem
> - added ABI ignore entry for xform

The Documentation is still not updated for these changes.
Please update doc/guides/prog_guide/cryptodev_lib.rst
And doc/guides/cryptodevs/features/default.ini (for ECDH)

Also update release notes (ECDH).


> 
> Arek Kusztal (12):
>   cryptodev: redefine ec group enum
>   cryptodev: separate key exchange operation enum
>   cryptodev: remove comment about using ephemeral key in dsa
>   cryptodev: clarify usage of private key in dh
>   cryptodev: move dh type from xform to dh op
>   cryptodev: add elliptic curve diffie hellman
>   cryptodev: add public key verify option
>   cryptodev: add asym op flags
>   cryptodev: clarify usage of rsa padding hash
>   cryptodev: move RSA padding into separate struct
>   cryptodev: clarify rsa verify with none padding
>   cryptodev: add salt length and optional label
> 
>  app/test/test_cryptodev_asym.c               |  63 ++++----
>  devtools/libabigail.abignore                 |   3 +
>  drivers/common/cpt/cpt_ucode_asym.h          |   4 +-
>  drivers/crypto/cnxk/cnxk_ae.h                |   8 +-
>  drivers/crypto/octeontx/otx_cryptodev_ops.c  |   4 +-
>  drivers/crypto/openssl/rte_openssl_pmd.c     |  17 +--
>  drivers/crypto/openssl/rte_openssl_pmd_ops.c |  33 +---
>  drivers/crypto/qat/qat_asym.c                |  12 +-
>  lib/cryptodev/rte_crypto_asym.h              | 217 ++++++++++++++++++++-------
>  lib/cryptodev/rte_cryptodev.c                |  15 +-
>  lib/cryptodev/rte_cryptodev.h                |   4 +-
>  lib/cryptodev/version.map                    |   1 +
>  12 files changed, 237 insertions(+), 144 deletions(-)
> 
> --
> 2.13.6