mbox series

[V5,0/7] app/testpmd: fix RSS and flow type

Message ID 20220624072401.21839-1-lihuisong@huawei.com (mailing list archive)
Headers
Series app/testpmd: fix RSS and flow type |

Message

lihuisong (C) June 24, 2022, 7:23 a.m. UTC
  This patchset fix RSS related code and remove duplicated flow type to      
string table.

---
v5:
 - resolve a warning in testpmd_funcs.rst file

v4:
 - delete 'rss_offload_table[]' and use 'rss_type_table[]'
 - add an 'char_num_per_line' parameter to control RSS types display.
 - add 2/7, 3/7 and 6/7 patch.

v3:
 - add 'rss_offload_table[]' to display supported RSS offload.
 - add patch 3/4 and 4/4.

v2:
 - resovle compilation failure when disable i40e and ixgbe.

Ferruh Yigit (2):
  app/testpmd: compact RSS types output in some commands
  app/testpmd: remove duplicated flow type to string table

Huisong Li (5):
  app/testpmd: fix supported RSS offload display
  app/testpmd: unify the name of L2 payload offload
  app/testpmd: refactor config all RSS command
  app/testpmd: unify RSS types display
  app/testpmd: reorder elements in RSS type table array

 app/test-pmd/cmdline.c                      | 127 +++-------
 app/test-pmd/config.c                       | 263 +++++++++++++-------
 app/test-pmd/testpmd.h                      |   8 +
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  11 +-
 drivers/net/i40e/i40e_testpmd.c             |  41 +--
 5 files changed, 228 insertions(+), 222 deletions(-)
  

Comments

lihuisong (C) June 24, 2022, 8:55 a.m. UTC | #1
Hi Ferruh,

This patchset has been sent. However, a merge conflict is displayed on 
the CI.
In fact, I'm do it based on the latest mainline, and there are nothing 
conflict.

Can you help me re-trigger the build?

Thanks,
huisong

在 2022/6/24 15:23, Huisong Li 写道:
> This patchset fix RSS related code and remove duplicated flow type to
> string table.
>
> ---
> v5:
>   - resolve a warning in testpmd_funcs.rst file
>
> v4:
>   - delete 'rss_offload_table[]' and use 'rss_type_table[]'
>   - add an 'char_num_per_line' parameter to control RSS types display.
>   - add 2/7, 3/7 and 6/7 patch.
>
> v3:
>   - add 'rss_offload_table[]' to display supported RSS offload.
>   - add patch 3/4 and 4/4.
>
> v2:
>   - resovle compilation failure when disable i40e and ixgbe.
>
> Ferruh Yigit (2):
>    app/testpmd: compact RSS types output in some commands
>    app/testpmd: remove duplicated flow type to string table
>
> Huisong Li (5):
>    app/testpmd: fix supported RSS offload display
>    app/testpmd: unify the name of L2 payload offload
>    app/testpmd: refactor config all RSS command
>    app/testpmd: unify RSS types display
>    app/testpmd: reorder elements in RSS type table array
>
>   app/test-pmd/cmdline.c                      | 127 +++-------
>   app/test-pmd/config.c                       | 263 +++++++++++++-------
>   app/test-pmd/testpmd.h                      |   8 +
>   doc/guides/testpmd_app_ug/testpmd_funcs.rst |  11 +-
>   drivers/net/i40e/i40e_testpmd.c             |  41 +--
>   5 files changed, 228 insertions(+), 222 deletions(-)
>
  
David Marchand June 24, 2022, 8:59 a.m. UTC | #2
On Fri, Jun 24, 2022 at 10:55 AM lihuisong (C) <lihuisong@huawei.com> wrote:
>
> Hi Ferruh,
>
> This patchset has been sent. However, a merge conflict is displayed on
> the CI.
> In fact, I'm do it based on the latest mainline, and there are nothing
> conflict.
>
> Can you help me re-trigger the build?

There may be different reasons why (likely on your side), but
patchwork does not see the patches you sent as a single series.
For example, patch 4 is seen as part of the v2 series.

The CI tools rely on patchwork.
So the various CI won't be able to apply them.

Please resend.
  
lihuisong (C) June 24, 2022, 9:54 a.m. UTC | #3
Hi David,

在 2022/6/24 16:59, David Marchand 写道:
> On Fri, Jun 24, 2022 at 10:55 AM lihuisong (C) <lihuisong@huawei.com> wrote:
>> Hi Ferruh,
>>
>> This patchset has been sent. However, a merge conflict is displayed on
>> the CI.
>> In fact, I'm do it based on the latest mainline, and there are nothing
>> conflict.
>>
>> Can you help me re-trigger the build?
> There may be different reasons why (likely on your side), but
> patchwork does not see the patches you sent as a single series.
> For example, patch 4 is seen as part of the v2 series.
>
> The CI tools rely on patchwork.
> So the various CI won't be able to apply them.
>
> Please resend.
Thanks. It's the patchwork problem. This patchset are assigned to two 
series.
As shown in the link below:
http://patches.dpdk.org/project/dpdk/list/?series=&submitter=2085&state=&q=&archive=&delegate=

If I resend, but this patchset hasn't changed.
Do I need to change the version number of this patchset?
  
Ferruh Yigit June 24, 2022, 10:44 a.m. UTC | #4
On 6/24/2022 10:54 AM, lihuisong (C) wrote:
> CAUTION: This message has originated from an External Source. Please use 
> proper judgment and caution when opening attachments, clicking links, or 
> responding to this email.
> 
> 
> Hi David,
> 
> 在 2022/6/24 16:59, David Marchand 写道:
>> On Fri, Jun 24, 2022 at 10:55 AM lihuisong (C) <lihuisong@huawei.com> 
>> wrote:
>>> Hi Ferruh,
>>>
>>> This patchset has been sent. However, a merge conflict is displayed on
>>> the CI.
>>> In fact, I'm do it based on the latest mainline, and there are nothing
>>> conflict.
>>>
>>> Can you help me re-trigger the build?
>> There may be different reasons why (likely on your side), but
>> patchwork does not see the patches you sent as a single series.
>> For example, patch 4 is seen as part of the v2 series.
>>
>> The CI tools rely on patchwork.
>> So the various CI won't be able to apply them.
>>
>> Please resend.
> Thanks. It's the patchwork problem. This patchset are assigned to two
> series.
> As shown in the link below:
> http://patches.dpdk.org/project/dpdk/list/?series=&submitter=2085&state=&q=&archive=&delegate= 
> 
> 
> If I resend, but this patchset hasn't changed.
> Do I need to change the version number of this patchset?

Hi Huisong,

I think both are OK, but just to clarify which one is latest, I think 
there is no harm to increase the version.
  
lihuisong (C) June 25, 2022, 1:09 a.m. UTC | #5
在 2022/6/24 18:44, Ferruh Yigit 写道:
> On 6/24/2022 10:54 AM, lihuisong (C) wrote:
>> CAUTION: This message has originated from an External Source. Please 
>> use proper judgment and caution when opening attachments, clicking 
>> links, or responding to this email.
>>
>>
>> Hi David,
>>
>> 在 2022/6/24 16:59, David Marchand 写道:
>>> On Fri, Jun 24, 2022 at 10:55 AM lihuisong (C) 
>>> <lihuisong@huawei.com> wrote:
>>>> Hi Ferruh,
>>>>
>>>> This patchset has been sent. However, a merge conflict is displayed on
>>>> the CI.
>>>> In fact, I'm do it based on the latest mainline, and there are nothing
>>>> conflict.
>>>>
>>>> Can you help me re-trigger the build?
>>> There may be different reasons why (likely on your side), but
>>> patchwork does not see the patches you sent as a single series.
>>> For example, patch 4 is seen as part of the v2 series.
>>>
>>> The CI tools rely on patchwork.
>>> So the various CI won't be able to apply them.
>>>
>>> Please resend.
>> Thanks. It's the patchwork problem. This patchset are assigned to two
>> series.
>> As shown in the link below:
>> http://patches.dpdk.org/project/dpdk/list/?series=&submitter=2085&state=&q=&archive=&delegate= 
>>
>>
>> If I resend, but this patchset hasn't changed.
>> Do I need to change the version number of this patchset?
>
> Hi Huisong,
>
> I think both are OK, but just to clarify which one is latest, I think 
> there is no harm to increase the version.
Get it. V6 will be sent.
> .
  
Ferruh Yigit June 28, 2022, 1:18 p.m. UTC | #6
On 6/25/2022 2:09 AM, lihuisong (C) wrote:
> 
> 在 2022/6/24 18:44, Ferruh Yigit 写道:
>> On 6/24/2022 10:54 AM, lihuisong (C) wrote:
>>> CAUTION: This message has originated from an External Source. Please
>>> use proper judgment and caution when opening attachments, clicking
>>> links, or responding to this email.
>>>
>>>
>>> Hi David,
>>>
>>> 在 2022/6/24 16:59, David Marchand 写道:
>>>> On Fri, Jun 24, 2022 at 10:55 AM lihuisong (C)
>>>> <lihuisong@huawei.com> wrote:
>>>>> Hi Ferruh,
>>>>>
>>>>> This patchset has been sent. However, a merge conflict is displayed on
>>>>> the CI.
>>>>> In fact, I'm do it based on the latest mainline, and there are nothing
>>>>> conflict.
>>>>>
>>>>> Can you help me re-trigger the build?
>>>> There may be different reasons why (likely on your side), but
>>>> patchwork does not see the patches you sent as a single series.
>>>> For example, patch 4 is seen as part of the v2 series.
>>>>
>>>> The CI tools rely on patchwork.
>>>> So the various CI won't be able to apply them.
>>>>
>>>> Please resend.
>>> Thanks. It's the patchwork problem. This patchset are assigned to two
>>> series.
>>> As shown in the link below:
>>> http://patches.dpdk.org/project/dpdk/list/?series=&submitter=2085&state=&q=&archive=&delegate= 
>>>
>>>
>>>
>>> If I resend, but this patchset hasn't changed.
>>> Do I need to change the version number of this patchset?
>>
>> Hi Huisong,
>>
>> I think both are OK, but just to clarify which one is latest, I think
>> there is no harm to increase the version.
> Get it. V6 will be sent.

Thank you.