| Message ID | 20220803111358.375544-1-andrew.rybchenko@oktetlabs.ru (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C5F4A00C5; Wed, 3 Aug 2022 13:14:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D58E140A7E; Wed, 3 Aug 2022 13:14:29 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C565740141 for <dev@dpdk.org>; Wed, 3 Aug 2022 13:14:27 +0200 (CEST) Received: by shelob.oktetlabs.ru (Postfix, from userid 115) id 44B30C5; Wed, 3 Aug 2022 14:14:27 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mail1.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD autolearn=no autolearn_force=no version=3.4.6 Received: from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17]) by shelob.oktetlabs.ru (Postfix) with ESMTP id 83886BD; Wed, 3 Aug 2022 14:14:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 83886BD Authentication-Results: shelob.oktetlabs.ru/83886BD; dkim=none; dkim-atps=neutral From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> To: Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@xilinx.com> Cc: dev@dpdk.org, Qiming Yang <qiming.yang@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>, Yuying Zhang <Yuying.Zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>, Rasesh Mody <rmody@marvell.com>, Devendra Singh Rawat <dsinghrawat@marvell.com>, Jiawen Wu <jiawenwu@trustnetic.com>, Jian Wang <jianwang@trustnetic.com> Subject: [PATCH 0/3] ethdev: remove deprecated Flow Director configuration Date: Wed, 3 Aug 2022 14:13:55 +0300 Message-Id: <20220803111358.375544-1-andrew.rybchenko@oktetlabs.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
ethdev: remove deprecated Flow Director configuration
|
|
Message
Andrew Rybchenko
Aug. 3, 2022, 11:13 a.m. UTC
Flow Director configuration fdir_conf was deprecated long time ago and was planned to be removed in 20.11. i40e, ixgbe, qede and txgbe driver maintainers are encouraged to review correspodning patches very carefully. Internal copy of the Flow Director configuration in ixgbe and txgbe drivers is not actually initialized. Should I use configuration from testpmd as the default one? Andrew Rybchenko (3): net/ixgbe: add helper to get Flow Director configuration net/txgbe: add helper to get Flow Director configuration ethdev: remove deprecated Flow Director configuration app/test-pmd/cmdline.c | 343 -------------------- app/test-pmd/config.c | 100 ------ app/test-pmd/parameters.c | 76 ----- app/test-pmd/testpmd.c | 24 -- app/test-pmd/testpmd.h | 6 - doc/guides/nics/fm10k.rst | 2 - doc/guides/nics/ixgbe.rst | 1 - doc/guides/rel_notes/deprecation.rst | 4 - doc/guides/rel_notes/release_22_11.rst | 4 + doc/guides/testpmd_app_ug/run_app.rst | 27 -- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 38 --- drivers/net/cnxk/cnxk_ethdev.c | 5 - drivers/net/fm10k/fm10k_rxtx_vec.c | 5 - drivers/net/hns3/hns3_rxtx_vec.c | 4 - drivers/net/i40e/i40e_ethdev.c | 31 -- drivers/net/i40e/i40e_fdir.c | 304 +---------------- drivers/net/i40e/i40e_rxtx_vec_common.h | 5 - drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- drivers/net/ixgbe/ixgbe_ethdev.h | 4 + drivers/net/ixgbe/ixgbe_fdir.c | 32 +- drivers/net/ixgbe/ixgbe_flow.c | 13 +- drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 2 +- drivers/net/octeontx/octeontx_ethdev.c | 5 - drivers/net/qede/qede_filter.c | 29 +- drivers/net/sfc/sfc.c | 5 - drivers/net/sfc/sfc_repr.c | 5 - drivers/net/thunderx/nicvf_ethdev.c | 5 - drivers/net/txgbe/txgbe_ethdev.c | 2 +- drivers/net/txgbe/txgbe_ethdev.h | 3 + drivers/net/txgbe/txgbe_fdir.c | 24 +- drivers/net/txgbe/txgbe_flow.c | 13 +- lib/ethdev/ethdev_driver.h | 36 ++ lib/ethdev/rte_ethdev.h | 43 --- 33 files changed, 100 insertions(+), 1102 deletions(-)
Comments
On 8/3/2022 12:13 PM, Andrew Rybchenko wrote: > Flow Director configuration fdir_conf was deprecated long time ago and > was planned to be removed in 20.11. > > i40e, ixgbe, qede and txgbe driver maintainers are encouraged to review > correspodning patches very carefully. > > Internal copy of the Flow Director configuration in ixgbe and txgbe > drivers is not actually initialized. Should I use configuration from > testpmd as the default one? > > Andrew Rybchenko (3): > net/ixgbe: add helper to get Flow Director configuration > net/txgbe: add helper to get Flow Director configuration > ethdev: remove deprecated Flow Director configuration > Thanks Andrew, this is one of the long lasting deprecating notices. Change looks good to me, but impacted driver (ixgbe, txgbe, i40e, qede) maintainers, can you please looks at the change, if there is no comment it will proceed.
On 8/24/2022 10:42 AM, Ferruh Yigit wrote: > On 8/3/2022 12:13 PM, Andrew Rybchenko wrote: >> Flow Director configuration fdir_conf was deprecated long time ago and >> was planned to be removed in 20.11. >> >> i40e, ixgbe, qede and txgbe driver maintainers are encouraged to review >> correspodning patches very carefully. >> >> Internal copy of the Flow Director configuration in ixgbe and txgbe >> drivers is not actually initialized. Should I use configuration from >> testpmd as the default one? >> >> Andrew Rybchenko (3): >> net/ixgbe: add helper to get Flow Director configuration >> net/txgbe: add helper to get Flow Director configuration >> ethdev: remove deprecated Flow Director configuration >> > > Thanks Andrew, this is one of the long lasting deprecating notices. > > Change looks good to me, but impacted driver (ixgbe, txgbe, i40e, qede) > maintainers, can you please looks at the change, if there is no comment > it will proceed. > There was no objection/comment, so I am proceeding with the set: Series applied to dpdk-next-net/main, thanks.