mbox series

[00/10] ethdev: cleanup deprecated defines

Message ID 20220804190602.1045171-1-andrew.rybchenko@oktetlabs.ru (mailing list archive)
Headers show
Series ethdev: cleanup deprecated defines | expand

Message

Andrew Rybchenko Aug. 4, 2022, 7:05 p.m. UTC
Remove deprecated because of invalid namespace defines.

Andrew Rybchenko (10):
  ethdev: remove deprecated link speed and duplex defines
  ethdev: remove deprecated Rx and Tx multi-queue mode defines
  ethdev: remove deprecated defines for RSS configuration
  ethdev: remove deprecated Rx and Tx offload defines
  ethdev: remove deprecated DCB and VMDq defines
  ethdev: remove deprecated tunnel type defines
  ethdev: remove deprecated flow control defines
  ethdev: remove deprecated VLAN offload configuration defines
  ethdev: remove deprecated maximum Rx MAC addresses define
  ethdev: remove deprecated metadata dynamic fields defines

 doc/guides/rel_notes/release_22_11.rst |  34 ++++
 lib/ethdev/rte_ethdev.h                | 242 -------------------------
 lib/ethdev/rte_flow.h                  |   4 -
 3 files changed, 34 insertions(+), 246 deletions(-)

Comments

Stephen Hemminger Aug. 4, 2022, 7:29 p.m. UTC | #1
On Thu,  4 Aug 2022 22:05:52 +0300
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:

> Remove deprecated because of invalid namespace defines.
> 
> Andrew Rybchenko (10):
>   ethdev: remove deprecated link speed and duplex defines
>   ethdev: remove deprecated Rx and Tx multi-queue mode defines
>   ethdev: remove deprecated defines for RSS configuration
>   ethdev: remove deprecated Rx and Tx offload defines
>   ethdev: remove deprecated DCB and VMDq defines
>   ethdev: remove deprecated tunnel type defines
>   ethdev: remove deprecated flow control defines
>   ethdev: remove deprecated VLAN offload configuration defines
>   ethdev: remove deprecated maximum Rx MAC addresses define
>   ethdev: remove deprecated metadata dynamic fields defines
> 
>  doc/guides/rel_notes/release_22_11.rst |  34 ++++
>  lib/ethdev/rte_ethdev.h                | 242 -------------------------
>  lib/ethdev/rte_flow.h                  |   4 -
>  3 files changed, 34 insertions(+), 246 deletions(-)
> 


Looks good. I assume the flow director (FDIR) defines should also
go away in this release when it is removed.

Series-Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Andrew Rybchenko Aug. 5, 2022, 8:01 a.m. UTC | #2
On 8/4/22 22:29, Stephen Hemminger wrote:
> On Thu,  4 Aug 2022 22:05:52 +0300
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
> 
>> Remove deprecated because of invalid namespace defines.
>>
>> Andrew Rybchenko (10):
>>    ethdev: remove deprecated link speed and duplex defines
>>    ethdev: remove deprecated Rx and Tx multi-queue mode defines
>>    ethdev: remove deprecated defines for RSS configuration
>>    ethdev: remove deprecated Rx and Tx offload defines
>>    ethdev: remove deprecated DCB and VMDq defines
>>    ethdev: remove deprecated tunnel type defines
>>    ethdev: remove deprecated flow control defines
>>    ethdev: remove deprecated VLAN offload configuration defines
>>    ethdev: remove deprecated maximum Rx MAC addresses define
>>    ethdev: remove deprecated metadata dynamic fields defines
>>
>>   doc/guides/rel_notes/release_22_11.rst |  34 ++++
>>   lib/ethdev/rte_ethdev.h                | 242 -------------------------
>>   lib/ethdev/rte_flow.h                  |   4 -
>>   3 files changed, 34 insertions(+), 246 deletions(-)
>>
> 
> 
> Looks good. I assume the flow director (FDIR) defines should also
> go away in this release when it is removed.

Yes, I wanted but simply forgot to mention it in the cover letter.
FDIR defines are covered by fdir cleanup patch series [1].
I decided that it does not deserve separate patch.

[1] 
https://patches.dpdk.org/project/dpdk/patch/20220803111358.375544-4-andrew.rybchenko@oktetlabs.ru/

> 
> Series-Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Thanks for the review, Stephen.
David Marchand Aug. 23, 2022, 8:41 a.m. UTC | #3
On Thu, Aug 4, 2022 at 9:06 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> Remove deprecated because of invalid namespace defines.
>
> Andrew Rybchenko (10):
>   ethdev: remove deprecated link speed and duplex defines
>   ethdev: remove deprecated Rx and Tx multi-queue mode defines
>   ethdev: remove deprecated defines for RSS configuration
>   ethdev: remove deprecated Rx and Tx offload defines
>   ethdev: remove deprecated DCB and VMDq defines
>   ethdev: remove deprecated tunnel type defines
>   ethdev: remove deprecated flow control defines
>   ethdev: remove deprecated VLAN offload configuration defines
>   ethdev: remove deprecated maximum Rx MAC addresses define
>   ethdev: remove deprecated metadata dynamic fields defines
>

Same comment as for the mbuf flags patch, we have a cocci script to do
the migration to the "new" API: devtools/cocci/namespace_ethdev.cocci
We can reference it in the release notes.

I suspect the RN will grow quite big for 22.11.
Can we perhaps have a single entry for ethdev, listing all the
different defines in a sublist?
(and looking again at the other cleanups, this last comment applies to
the mempool series too).


I sent some comments, but otherwise, the series lgtm and you can add my ack.
Thanks Andrew!
Ferruh Yigit Aug. 23, 2022, 6:08 p.m. UTC | #4
On 8/23/2022 9:41 AM, David Marchand wrote:
> On Thu, Aug 4, 2022 at 9:06 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>
>> Remove deprecated because of invalid namespace defines.
>>
>> Andrew Rybchenko (10):
>>    ethdev: remove deprecated link speed and duplex defines
>>    ethdev: remove deprecated Rx and Tx multi-queue mode defines
>>    ethdev: remove deprecated defines for RSS configuration
>>    ethdev: remove deprecated Rx and Tx offload defines
>>    ethdev: remove deprecated DCB and VMDq defines
>>    ethdev: remove deprecated tunnel type defines
>>    ethdev: remove deprecated flow control defines
>>    ethdev: remove deprecated VLAN offload configuration defines
>>    ethdev: remove deprecated maximum Rx MAC addresses define
>>    ethdev: remove deprecated metadata dynamic fields defines
>>
> 
> Same comment as for the mbuf flags patch, we have a cocci script to do
> the migration to the "new" API: devtools/cocci/namespace_ethdev.cocci
> We can reference it in the release notes.
> 

Agreed. I will group release notes updates while merging. And note 
'devtools/cocci/namespace_ethdev.cocci'.

> I suspect the RN will grow quite big for 22.11.
> Can we perhaps have a single entry for ethdev, listing all the
> different defines in a sublist?

I am also not sure about benefit of the multiple commits, I will keep as 
it is since it is already split. But maybe can be squashed while pulling 
from next-net.

> (and looking again at the other cleanups, this last comment applies to
> the mempool series too).
> 
> 
> I sent some comments, but otherwise, the series lgtm and you can add my ack.

Adding your explicit ack while merging:
Acked-by: David Marchand <david.marchand@redhat.com>

For series,
Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>

Series applied to dpdk-next-net/main, thanks.
David Marchand Aug. 24, 2022, 6:46 a.m. UTC | #5
On Tue, Aug 23, 2022 at 8:08 PM Ferruh Yigit <ferruh.yigit@xilinx.com> wrote:
> Adding your explicit ack while merging:
> Acked-by: David Marchand <david.marchand@redhat.com>
>
> For series,
> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>
> Series applied to dpdk-next-net/main, thanks.
>

Thanks for the tweaks while merging.
Btw, Stephen also acked the series.
Ferruh Yigit Aug. 24, 2022, 7:51 a.m. UTC | #6
On 8/24/2022 7:46 AM, David Marchand wrote:
> On Tue, Aug 23, 2022 at 8:08 PM Ferruh Yigit <ferruh.yigit@xilinx.com> wrote:
>> Adding your explicit ack while merging:
>> Acked-by: David Marchand <david.marchand@redhat.com>
>>
>> For series,
>> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>>
>> Series applied to dpdk-next-net/main, thanks.
>>
> 
> Thanks for the tweaks while merging.
> Btw, Stephen also acked the series.
> 

Missed that, will add in the repo, thanks.