| Message ID | 20220804190602.1045171-1-andrew.rybchenko@oktetlabs.ru (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 113F7A00C4; Thu, 4 Aug 2022 21:06:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4231542BF4; Thu, 4 Aug 2022 21:06:13 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 9AEE242BCA for <dev@dpdk.org>; Thu, 4 Aug 2022 21:06:10 +0200 (CEST) Received: by shelob.oktetlabs.ru (Postfix, from userid 115) id 0FB32BD; Thu, 4 Aug 2022 22:06:09 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mail1.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD autolearn=no autolearn_force=no version=3.4.6 Received: from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17]) by shelob.oktetlabs.ru (Postfix) with ESMTP id 914DAB0; Thu, 4 Aug 2022 22:06:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 914DAB0 Authentication-Results: shelob.oktetlabs.ru/914DAB0; dkim=none; dkim-atps=neutral From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> To: Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@xilinx.com> Cc: dev@dpdk.org Subject: [PATCH 00/10] ethdev: cleanup deprecated defines Date: Thu, 4 Aug 2022 22:05:52 +0300 Message-Id: <20220804190602.1045171-1-andrew.rybchenko@oktetlabs.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
ethdev: cleanup deprecated defines
|
|
Message
Andrew Rybchenko
Aug. 4, 2022, 7:05 p.m. UTC
Remove deprecated because of invalid namespace defines. Andrew Rybchenko (10): ethdev: remove deprecated link speed and duplex defines ethdev: remove deprecated Rx and Tx multi-queue mode defines ethdev: remove deprecated defines for RSS configuration ethdev: remove deprecated Rx and Tx offload defines ethdev: remove deprecated DCB and VMDq defines ethdev: remove deprecated tunnel type defines ethdev: remove deprecated flow control defines ethdev: remove deprecated VLAN offload configuration defines ethdev: remove deprecated maximum Rx MAC addresses define ethdev: remove deprecated metadata dynamic fields defines doc/guides/rel_notes/release_22_11.rst | 34 ++++ lib/ethdev/rte_ethdev.h | 242 ------------------------- lib/ethdev/rte_flow.h | 4 - 3 files changed, 34 insertions(+), 246 deletions(-)
Comments
On Thu, 4 Aug 2022 22:05:52 +0300 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote: > Remove deprecated because of invalid namespace defines. > > Andrew Rybchenko (10): > ethdev: remove deprecated link speed and duplex defines > ethdev: remove deprecated Rx and Tx multi-queue mode defines > ethdev: remove deprecated defines for RSS configuration > ethdev: remove deprecated Rx and Tx offload defines > ethdev: remove deprecated DCB and VMDq defines > ethdev: remove deprecated tunnel type defines > ethdev: remove deprecated flow control defines > ethdev: remove deprecated VLAN offload configuration defines > ethdev: remove deprecated maximum Rx MAC addresses define > ethdev: remove deprecated metadata dynamic fields defines > > doc/guides/rel_notes/release_22_11.rst | 34 ++++ > lib/ethdev/rte_ethdev.h | 242 ------------------------- > lib/ethdev/rte_flow.h | 4 - > 3 files changed, 34 insertions(+), 246 deletions(-) > Looks good. I assume the flow director (FDIR) defines should also go away in this release when it is removed. Series-Acked-by: Stephen Hemminger <stephen@networkplumber.org>
On 8/4/22 22:29, Stephen Hemminger wrote: > On Thu, 4 Aug 2022 22:05:52 +0300 > Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote: > >> Remove deprecated because of invalid namespace defines. >> >> Andrew Rybchenko (10): >> ethdev: remove deprecated link speed and duplex defines >> ethdev: remove deprecated Rx and Tx multi-queue mode defines >> ethdev: remove deprecated defines for RSS configuration >> ethdev: remove deprecated Rx and Tx offload defines >> ethdev: remove deprecated DCB and VMDq defines >> ethdev: remove deprecated tunnel type defines >> ethdev: remove deprecated flow control defines >> ethdev: remove deprecated VLAN offload configuration defines >> ethdev: remove deprecated maximum Rx MAC addresses define >> ethdev: remove deprecated metadata dynamic fields defines >> >> doc/guides/rel_notes/release_22_11.rst | 34 ++++ >> lib/ethdev/rte_ethdev.h | 242 ------------------------- >> lib/ethdev/rte_flow.h | 4 - >> 3 files changed, 34 insertions(+), 246 deletions(-) >> > > > Looks good. I assume the flow director (FDIR) defines should also > go away in this release when it is removed. Yes, I wanted but simply forgot to mention it in the cover letter. FDIR defines are covered by fdir cleanup patch series [1]. I decided that it does not deserve separate patch. [1] https://patches.dpdk.org/project/dpdk/patch/20220803111358.375544-4-andrew.rybchenko@oktetlabs.ru/ > > Series-Acked-by: Stephen Hemminger <stephen@networkplumber.org> Thanks for the review, Stephen.
On Thu, Aug 4, 2022 at 9:06 PM Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote: > > Remove deprecated because of invalid namespace defines. > > Andrew Rybchenko (10): > ethdev: remove deprecated link speed and duplex defines > ethdev: remove deprecated Rx and Tx multi-queue mode defines > ethdev: remove deprecated defines for RSS configuration > ethdev: remove deprecated Rx and Tx offload defines > ethdev: remove deprecated DCB and VMDq defines > ethdev: remove deprecated tunnel type defines > ethdev: remove deprecated flow control defines > ethdev: remove deprecated VLAN offload configuration defines > ethdev: remove deprecated maximum Rx MAC addresses define > ethdev: remove deprecated metadata dynamic fields defines > Same comment as for the mbuf flags patch, we have a cocci script to do the migration to the "new" API: devtools/cocci/namespace_ethdev.cocci We can reference it in the release notes. I suspect the RN will grow quite big for 22.11. Can we perhaps have a single entry for ethdev, listing all the different defines in a sublist? (and looking again at the other cleanups, this last comment applies to the mempool series too). I sent some comments, but otherwise, the series lgtm and you can add my ack. Thanks Andrew!
On 8/23/2022 9:41 AM, David Marchand wrote: > On Thu, Aug 4, 2022 at 9:06 PM Andrew Rybchenko > <andrew.rybchenko@oktetlabs.ru> wrote: >> >> Remove deprecated because of invalid namespace defines. >> >> Andrew Rybchenko (10): >> ethdev: remove deprecated link speed and duplex defines >> ethdev: remove deprecated Rx and Tx multi-queue mode defines >> ethdev: remove deprecated defines for RSS configuration >> ethdev: remove deprecated Rx and Tx offload defines >> ethdev: remove deprecated DCB and VMDq defines >> ethdev: remove deprecated tunnel type defines >> ethdev: remove deprecated flow control defines >> ethdev: remove deprecated VLAN offload configuration defines >> ethdev: remove deprecated maximum Rx MAC addresses define >> ethdev: remove deprecated metadata dynamic fields defines >> > > Same comment as for the mbuf flags patch, we have a cocci script to do > the migration to the "new" API: devtools/cocci/namespace_ethdev.cocci > We can reference it in the release notes. > Agreed. I will group release notes updates while merging. And note 'devtools/cocci/namespace_ethdev.cocci'. > I suspect the RN will grow quite big for 22.11. > Can we perhaps have a single entry for ethdev, listing all the > different defines in a sublist? I am also not sure about benefit of the multiple commits, I will keep as it is since it is already split. But maybe can be squashed while pulling from next-net. > (and looking again at the other cleanups, this last comment applies to > the mempool series too). > > > I sent some comments, but otherwise, the series lgtm and you can add my ack. Adding your explicit ack while merging: Acked-by: David Marchand <david.marchand@redhat.com> For series, Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com> Series applied to dpdk-next-net/main, thanks.
On Tue, Aug 23, 2022 at 8:08 PM Ferruh Yigit <ferruh.yigit@xilinx.com> wrote: > Adding your explicit ack while merging: > Acked-by: David Marchand <david.marchand@redhat.com> > > For series, > Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com> > > Series applied to dpdk-next-net/main, thanks. > Thanks for the tweaks while merging. Btw, Stephen also acked the series.
On 8/24/2022 7:46 AM, David Marchand wrote: > On Tue, Aug 23, 2022 at 8:08 PM Ferruh Yigit <ferruh.yigit@xilinx.com> wrote: >> Adding your explicit ack while merging: >> Acked-by: David Marchand <david.marchand@redhat.com> >> >> For series, >> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com> >> >> Series applied to dpdk-next-net/main, thanks. >> > > Thanks for the tweaks while merging. > Btw, Stephen also acked the series. > Missed that, will add in the repo, thanks.