mbox series

[v2,00/11] codeql fixes for various subsystems

Message ID 20221121223208.1147154-1-okaya@kernel.org (mailing list archive)
Headers
Series codeql fixes for various subsystems |

Message

Sinan Kaya Nov. 21, 2022, 10:31 p.m. UTC 
  From: Sinan Kaya <okaya@kernel.org>

Following up the codeql reported problems first submitted
by Stephen Hemminger here:

https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/

Posting a series of fixes about potential null pointer accesses.

Changes from v1:
- Remove braces around single line statements
- use NULL comparisons

Sinan Kaya (11):
  ethdev: check return result of rte_eth_dev_info_get
  net/tap: check if name is null
  memzone: check result of rte_fbarray_get
  memzone: check result of malloc_elem_from_data
  malloc: malloc_elem_join_adjacent_free can return null
  malloc: check result of rte_mem_virt2memseg_list
  malloc: check result of rte_fbarray_get
  malloc: check result of rte_mem_virt2memseg
  malloc: check result of malloc_elem_free
  malloc: check result of elem_start_pt
  bus/vdev: check result of rte_vdev_device_name

 drivers/net/tap/rte_eth_tap.c        |  3 +++
 lib/eal/common/eal_common_memalloc.c |  5 ++++-
 lib/eal/common/eal_common_memzone.c  | 10 +++++++++-
 lib/eal/common/malloc_elem.c         | 14 +++++++++++---
 lib/eal/common/malloc_heap.c         |  9 ++++++++-
 lib/ethdev/ethdev_vdev.h             |  2 ++
 lib/ethdev/rte_class_eth.c           |  4 +++-
 7 files changed, 40 insertions(+), 7 deletions(-)

Comments

David Marchand Nov. 22, 2022, 3:24 p.m. UTC | #1 
Hello,

On Mon, Nov 21, 2022 at 11:32 PM <okaya@kernel.org> wrote:
>
> From: Sinan Kaya <okaya@kernel.org>
>
> Following up the codeql reported problems first submitted
> by Stephen Hemminger here:
>
> https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/
>
> Posting a series of fixes about potential null pointer accesses.
>
> Changes from v1:
> - Remove braces around single line statements
> - use NULL comparisons

Thanks for the fixes, but it looks like the v2 series is truncated.
Can you resend it so it passes through the CI?

Thanks.
Sinan Kaya Nov. 22, 2022, 3:26 p.m. UTC | #2 
On Tue, 2022-11-22 at 16:24 +0100, David Marchand wrote:
> Thanks for the fixes, but it looks like the v2 series is truncated.
> 
> Can you resend it so it passes through the CI?

Sure