mbox series

[v2,0/3] support match icmpv6 ID and sequence

Message ID 20221220074403.1015411-1-yongquanx@nvidia.com (mailing list archive)
Headers
Series support match icmpv6 ID and sequence |

Message

Leo Xu Dec. 20, 2022, 7:44 a.m. UTC 
  Currently, rte_flow API does not support matching
ID and sequence fields of icmp6 echo packets.

This patchset is used to support match icmpv6 ID and
sequence in rte_flow. It adds needed API in rte_flow,
and gives corresponding implementation for mlx5 pmd.

Leo Xu (3):
  ethdev: add ICMPv6 ID and sequence
  net/mlx5: add ICMPv6 ID and sequence match support
  net/mlx5/hws: add ICMPv6 ID and sequence match support

---
v2:
* rebase 23.03

 app/test-pmd/cmdline_flow.c                 | 70 ++++++++++++++++
 doc/guides/nics/mlx5.rst                    |  2 +-
 doc/guides/prog_guide/rte_flow.rst          | 14 ++++
 doc/guides/rel_notes/release_23_03.rst      | 10 +++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 10 +++
 drivers/net/mlx5/hws/mlx5dr_definer.c       | 88 +++++++++++++++++++++
 drivers/net/mlx5/mlx5_flow.c                | 61 ++++++++++++++
 drivers/net/mlx5/mlx5_flow.h                |  4 +
 drivers/net/mlx5/mlx5_flow_dv.c             | 76 ++++++++++++++++++
 drivers/net/mlx5/mlx5_flow_hw.c             |  2 +
 lib/ethdev/rte_flow.c                       |  4 +
 lib/ethdev/rte_flow.h                       | 25 ++++++
 lib/net/meson.build                         |  1 +
 lib/net/rte_icmp6.h                         | 48 +++++++++++
 14 files changed, 414 insertions(+), 1 deletion(-)
 create mode 100644 lib/net/rte_icmp6.h

Comments

Ferruh Yigit Jan. 26, 2023, 10:47 a.m. UTC | #1 
On 12/20/2022 7:44 AM, Leo Xu wrote:
> Currently, rte_flow API does not support matching
> ID and sequence fields of icmp6 echo packets.
> 
> This patchset is used to support match icmpv6 ID and
> sequence in rte_flow. It adds needed API in rte_flow,
> and gives corresponding implementation for mlx5 pmd.
> 
> Leo Xu (3):
>   ethdev: add ICMPv6 ID and sequence
>   net/mlx5: add ICMPv6 ID and sequence match support
>   net/mlx5/hws: add ICMPv6 ID and sequence match support
> 
> ---
> v2:
> * rebase 23.03
> 

mlx patches are giving following warning:
$ ./devtools/check-doc-vs-code.sh
rte_flow doc out of sync for mlx5
        item icmp6_echo_reply
        item icmp6_echo_request


Also can you please make sure driver patches are acked by driver
maintainers, so we can merge all set with ethdev and driver patches
together.
Leo Xu Jan. 31, 2023, 3:54 a.m. UTC | #2 
Hi,

PSB
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Thursday, January 26, 2023 6:47 PM
> To: Leo Xu (Networking SW) <yongquanx@nvidia.com>
> Cc: Matan Azrad <matan@nvidia.com>; dev@dpdk.org; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Subject: Re: [PATCH v2 0/3] support match icmpv6 ID and sequence
> 
> External email: Use caution opening links or attachments
> 
> 
> On 12/20/2022 7:44 AM, Leo Xu wrote:
> > Currently, rte_flow API does not support matching ID and sequence
> > fields of icmp6 echo packets.
> >
> > This patchset is used to support match icmpv6 ID and sequence in
> > rte_flow. It adds needed API in rte_flow, and gives corresponding
> > implementation for mlx5 pmd.
> >
> > Leo Xu (3):
> >   ethdev: add ICMPv6 ID and sequence
> >   net/mlx5: add ICMPv6 ID and sequence match support
> >   net/mlx5/hws: add ICMPv6 ID and sequence match support
> >
> > ---
> > v2:
> > * rebase 23.03
> >
> 
> mlx patches are giving following warning:
> $ ./devtools/check-doc-vs-code.sh
> rte_flow doc out of sync for mlx5
>         item icmp6_echo_reply
>         item icmp6_echo_request

Thanks for the catch, will fix it in next PATCH.

> 
> Also can you please make sure driver patches are acked by driver maintainers,
> so we can merge all set with ethdev and driver patches together.