mbox series

[0/6] Testpmd code cleanup

Message ID 20230124104742.1265439-1-david.marchand@redhat.com (mailing list archive)
Headers
Series Testpmd code cleanup |

Message

David Marchand Jan. 24, 2023, 10:47 a.m. UTC 
  Here is a series to reduce code duplication in testpmd.

This work started from looking at Robin series on reporting lcore busy
cycles in telemetry, which is then added in testpmd [1].
While looking at the forward engines code, I saw way too much
duplicated code.

Warning: this is only compile tested.

1: https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-rjarry@redhat.com/

Comments

Robin Jarry Jan. 25, 2023, 1:50 p.m. UTC | #1 
David Marchand, Jan 24, 2023 at 11:47:
> Here is a series to reduce code duplication in testpmd.
>
> This work started from looking at Robin series on reporting lcore busy 
> cycles in telemetry, which is then added in testpmd [1]. While looking 
> at the forward engines code, I saw way too much duplicated code.
>
> Warning: this is only compile tested.
>
> 1: https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-rjarry@redhat.com/

Hi David,

The code looks good to me. I have made some basic testing, it seems not 
to break obvious things.

Reviewed-by: Robin Jarry <rjarry@redhat.com>
Ferruh Yigit Feb. 14, 2023, 6:22 p.m. UTC | #2 
On 1/25/2023 1:50 PM, Robin Jarry wrote:
> David Marchand, Jan 24, 2023 at 11:47:
>> Here is a series to reduce code duplication in testpmd.
>>
>> This work started from looking at Robin series on reporting lcore busy
>> cycles in telemetry, which is then added in testpmd [1]. While looking
>> at the forward engines code, I saw way too much duplicated code.
>>
>> Warning: this is only compile tested.
>>
>> 1:
>> https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-rjarry@redhat.com/
> 
> Hi David,
> 
> The code looks good to me. I have made some basic testing, it seems not
> to break obvious things.
> 
> Reviewed-by: Robin Jarry <rjarry@redhat.com>
> 

Hi Robin,

This set conflicts with your set which is merged [1], I guess your test
was before your patch merged. Can you please check again after rebase?



[1]
Commit 99a4974aa569 ("app/testpmd: report lcore usage")
David Marchand Feb. 20, 2023, 3:02 p.m. UTC | #3 
Hi Robin, Ferruh,

On Tue, Feb 14, 2023 at 7:22 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> On 1/25/2023 1:50 PM, Robin Jarry wrote:
> > David Marchand, Jan 24, 2023 at 11:47:
> >> Here is a series to reduce code duplication in testpmd.
> >>
> >> This work started from looking at Robin series on reporting lcore busy
> >> cycles in telemetry, which is then added in testpmd [1]. While looking
> >> at the forward engines code, I saw way too much duplicated code.
> >>
> >> Warning: this is only compile tested.
> >>
> >> 1:
> >> https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-rjarry@redhat.com/
> >
> > Hi David,
> >
> > The code looks good to me. I have made some basic testing, it seems not
> > to break obvious things.
> >
> > Reviewed-by: Robin Jarry <rjarry@redhat.com>
> >
>
> Hi Robin,
>
> This set conflicts with your set which is merged [1], I guess your test
> was before your patch merged. Can you please check again after rebase?
>

The rebase (that I will send later) needs some eyes indeed.