mbox series

[v10,0/2] testpmd: handle signals safely

Message ID 20230130200914.22049-1-stephen@networkplumber.org (mailing list archive)
Headers
Series testpmd: handle signals safely |

Message

Stephen Hemminger Jan. 30, 2023, 8:09 p.m. UTC 
  Fixing the signal handling in testpmd requires also
fixing EOF handling in cmdline_poll()

Stephen Hemminger (2):
  cmdline: handle EOF in cmdline_poll
  testpmd: cleanup cleanly from signal

 app/test-pmd/cmdline.c | 30 ++++++----------
 app/test-pmd/testpmd.c | 77 ++++++++++++++++++++----------------------
 app/test-pmd/testpmd.h |  1 +
 lib/cmdline/cmdline.c  |  2 +-
 4 files changed, 49 insertions(+), 61 deletions(-)

Comments

Ferruh Yigit Jan. 30, 2023, 10:13 p.m. UTC | #1 
On 1/30/2023 8:09 PM, Stephen Hemminger wrote:
> Fixing the signal handling in testpmd requires also
> fixing EOF handling in cmdline_poll()
> 
> Stephen Hemminger (2):
>   cmdline: handle EOF in cmdline_poll
>   testpmd: cleanup cleanly from signal
> 

I confirm this solves the EOF issue, but please check comment on the
cmdline library patch (1/2).