| Message ID | 20230206070549.27265-1-chaoyong.he@corigine.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FDF241BE7; Mon, 6 Feb 2023 08:06:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6DD641156; Mon, 6 Feb 2023 08:06:12 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2109.outbound.protection.outlook.com [40.107.100.109]) by mails.dpdk.org (Postfix) with ESMTP id 5BBEE40A7D for <dev@dpdk.org>; Mon, 6 Feb 2023 08:06:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hPENmhrTlFRqMK6Wns8WYrgLi3TAOT1FZu/XiNd+em85fg+GhhxrkUtgjZOaLS9VGyb6jcpQPj3mccJxf7ks6YBzA1jsGcbclb1KMAWoTM5bm3jqCcEDxE7e4RsZA0adbv8/2D1Ai/ei39eIkU6JUgevCmtO4BzmODLcvLou9ynwCXca2RfB2TxO6jwVYjIL0Mbap/3WJRx7e569QKO22fH5dO6LlLYLP6YAECE0Il1PcPX46CXDr1YgGuCEvNNc3GWeH/gDpBOIxPvAK+vjPYmQNxy+STLjG5W2LFbpsE2VUUl+RY6IpIkNRet/erWJP69sdjvq/U8SPSsKCdOuZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+CSJhhGm3uNYiEUYoWswTrc2f8UoQScD/t6SxKj218c=; b=A3ekW5ul0DArFfNzdp7xDhnQobbcPPukGo3quahuOBUOKlhAfwvSXWT+VkzZEz7LUlpFemp+gOQc+b4rTDE5ta3BhOsHRv8J1wJaTZ0KyqLIBAGSJTi+CRxG5fgqmdw5j4QduljWv8DXP4wn/uWjctytCwaQVo57q3dhvmKc65pdX0+L4iiJ2bKu2QH7cKmAIuIVWbbQTptunIOXmPC2IHU4ysgzBHatTBe4yQTtPB3o3o2z7da69tt6fnndpeUAOEV7HFGPF28yNrPHQGKiqU/D2Epm/i7o0YHyjGFO4FKupNmj8sxM6n5i0S1n+JsWrkiv/0wKs2kyrcprSrg2Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+CSJhhGm3uNYiEUYoWswTrc2f8UoQScD/t6SxKj218c=; b=oQJEvvc6Sa8EXIvv5XhNW3V73HTDr0Rwdx5L6MEd2FV+MfgGqnmkVfR8/LPejFv3kSXbY4lazeabT+ZzbiN1J+ONmuLCbRz344jVZ14JFpSgeG7337NWXLOeCiHBkvfXUjcLsOqf8FagMOf66f9O7iNxnhkKFj+6QPoh18BePRQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SJ0PR13MB5302.namprd13.prod.outlook.com (2603:10b6:a03:3dc::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 07:06:08 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%4]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 07:06:07 +0000 From: Chaoyong He <chaoyong.he@corigine.com> To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He <chaoyong.he@corigine.com> Subject: [PATCH 0/3] cleanup the PMD Date: Mon, 6 Feb 2023 15:05:46 +0800 Message-Id: <20230206070549.27265-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR01CA0120.apcprd01.prod.exchangelabs.com (2603:1096:4:40::24) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SJ0PR13MB5302:EE_ X-MS-Office365-Filtering-Correlation-Id: 565879a3-732a-4adc-3995-08db08109e60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2h9K2q0epyIiK7Rft3gQfn1kp8fFrIL8uwu42c4d52Ko+QsZuVLSuMjDk/TQ9DSJ+WvYTsELyvVxNguSh5Pc6TqtpBf4k9osq6EAtM/4+p7DOovLue4rcLBW2npGoOpztWITZyy+X5q6mT8P+aUXFt+wyz2Bh7xD0lfaSrNX/0d5AnH/vgN6NWLrAaiTJ6M9qPdhrRjl/P02W+/Hj52Kndx0Zdjrr6vN98/OFgVWvDcfwLJgTbkOo2LbkeKI3uZrArnmEwLy47kbDO3I0gZPA7HshmEocRi7v5AtPITi2MLXFLRBqV3A5ZoZLFvOU3AmVGV3C7DNaltvHlqHskXopRSGJ4AG8EhQqp/awCQ90Sw4/dPtiaS5DLb3QzJ7KBYnzTEwSg1wsEOu30P4ukAIRisWzeSpWvcszHeU2iMtL+jhfGT9KF1DHAii8sJEtse1m/DB3NL/0TuXqSWeNSd/SNsyqaUSZInR8Fr0C3/nWpD458z3+LLB7MjK4y25oRTdZYW8kTlpoFUsyyOqTF6+geAmmYNPPWqczk3W9RadwU35PSRkVS+o4ysb3+E0SA7uSV1/GuTRQBMGrAgBkMesfGPOTfc0mTQfUCkmgRUN2rB6QvH/AVTtJ28FXslcBYWkHKuQQn4XVSUHBFB9cQg1ql8fxpOsqtHE3ipP9dWKyZ0pW9WKLQ+0NXjS5psF7tz9ybVanphbCJGicKYIt/uRlA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(396003)(366004)(39840400004)(136003)(376002)(451199018)(52116002)(36756003)(316002)(107886003)(6666004)(1076003)(6506007)(8676002)(6486002)(5660300002)(8936002)(66476007)(66556008)(2906002)(6916009)(66946007)(4326008)(478600001)(44832011)(41300700001)(6512007)(26005)(38100700002)(86362001)(38350700002)(83380400001)(186003)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?mccw6eWCcJcZCP8fotW34m2feRhN?= =?utf-8?q?c2SjWAkphDLx6ct96+q5N5+ri7IuJY6koNjWNfacM3GPE+zW2LxC3gFRKHyKaWh9k?= =?utf-8?q?v0NJIFpOUr+W4zPyD+7+6cMyrv53vTed7ynKPK+GzV6tKjmUsgdWsa0wleP33DqYA?= =?utf-8?q?nlIxErylfGKHXdyMtFffYvRx76xbx8NATU8YbH1dksokFvGu2ezSpn91mMi4ytphd?= =?utf-8?q?HG1ipAUyMMpZ3qJJEDanPP6YkH3TUtJI8iUSQ6aOXuVlFoxd8Ew27JtEps9Il50wF?= =?utf-8?q?NDjT65MYS/GBMtzbMpWiDCYrAWiU1TrxBNYqW/CZx3I3jCeYVWgRSVOMwOGlgsVew?= =?utf-8?q?Si2p1DL5/Lj75M5lE2VN+omIucZ/y0cDvEsuK8eiDI7ugOBGH2hyTet9H49CO9Vi6?= =?utf-8?q?KiV68AyiH4TU4aoS3UM8e6WY+2gWYk3v0ZUk49/xF8t7C0CdC3haBq5d9dapJrlcU?= =?utf-8?q?ydPyKZzeZAmkm1KIl+lyKTNibIDAXSQe4CgYj0ZvSFn+iyjeyc6Nq/O5HLmEDphpj?= =?utf-8?q?gPtl7l0xyr5GLdMCuE/wW27Seine6obXFZ5TYuT2NGGuFirZd6f6Vc5xsgbWQ9fDu?= =?utf-8?q?UxTCuBV9rA7DE4Tm1fP4R4S8ljmArboas4RsS3x9qpzxXAQh+ynYU7HBsa5gPhLCb?= =?utf-8?q?dEJ8lB5bKLRCJV2lIWCFqhISN3NcAUFzi8QoD49y00MLhV1uxi/JAa8DxNqqNz2uo?= =?utf-8?q?4jibI+EdJZKl1Z34bDXM1AbFnnfJ3iT3N8rFetn5qWp8ujOFyY1NL8mXVet9fskPW?= =?utf-8?q?7Vm2xRXrLvziyEhGKjjtkfBMBjfrJTINvmH/4BbYxdXSbhZ13gUd6lgZYeh7zQg1w?= =?utf-8?q?s4QtxDMheQRfPngnD8xwTn8ZHPdnd2zdapWPye3k1yqCiH+7jTiCNalFW6zPFGo2+?= =?utf-8?q?dLxvJUffXGl19YUivHV2aDwdkHTwKU1LugdUbDz0X01NYxXbwVc5Q2tGCww8mjH9l?= =?utf-8?q?T+fh14tCsCGGzHi0M3GZTmhU6IMZHHBYsN8FHa1ikL3wjYohrgN4QOBs3uDGK4uym?= =?utf-8?q?GcuHd9DhOcWHEYq8qcnnc2/B1cw9m5aAEwI0tEGMAmXiCYCj1ziFhZm1XqJwRTUYh?= =?utf-8?q?0BiOQuRlzM89p+FCbRlxCj3EHNjP87eoeuZAjR8Obp2J8uiw/FLfo43PeVpVfOPFQ?= =?utf-8?q?wmntWk8Mq/+KkgFUZgRus3JO5t8H9wPBdEasddybE3vHAtSlXDt8m4bOsN+PXBR2D?= =?utf-8?q?LlS9Uxsuz0OSX9EAX4z2DPKFJoVWg+TTbdGxIV19kl3HseLLTnWm6++Oiwu4D/LB5?= =?utf-8?q?5EuXjzRAnbur2wClpPg7JG1rUT6psXMhsEsLz0+XGxJi4irqc1ngw59FkiICx0Zq8?= =?utf-8?q?qzz+tmQ1+/jRTvGtJn2xr42oG2ImIVgWaAd67aEcw49ZdtfVoBVdSOepoV65fwd8h?= =?utf-8?q?Gw2eI6fzy4hSNoEkbEVPkAgv9iUkGi+QcmG+3RoIN4X9gsyypvlzC2BqfvxrN+3jg?= =?utf-8?q?cJXiRAzN4i69P9AZnlXApAlhyIZRRIIz0ncP+bPmK2DhoekH1+hyJIDA+7Gcs/gVf?= =?utf-8?q?DtdiYuUcPgTo9fIuUvXkli3CLUa8CNd4oA=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 565879a3-732a-4adc-3995-08db08109e60 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 07:06:07.5487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EMLAFPzNTpIvSacRlfc5Cfl55pDsa7VfbG9JEKZ4AG45wuC8s2uBI7JCzsRAHWvTHnlXKMf3L40Na4uR7FWSYWvGveubRnuH2i7b/tlFIZA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5302 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series | cleanup the PMD | |
Message
Chaoyong He
Feb. 6, 2023, 7:05 a.m. UTC
This patch series aims to better align the PMD with the preferred DPDK coding style. - Remove the usage of 'printf()' - Remove the unneeded header file includes - Explicitly compare pointer with NULL - Explicitly compare integer with 0 James Hershaw (3): net/nfp: remove usage of print statements net/nfp: remove unnecessary include net/nfp: explicitly compare to null and 0 drivers/net/nfp/nfp_common.c | 25 +++--- drivers/net/nfp/nfp_cpp_bridge.c | 4 +- drivers/net/nfp/nfp_ethdev.c | 2 +- drivers/net/nfp/nfp_ethdev_vf.c | 2 +- drivers/net/nfp/nfp_rxtx.c | 14 ++-- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 88 +++++++++------------- drivers/net/nfp/nfpcore/nfp_cppcore.c | 31 ++++---- drivers/net/nfp/nfpcore/nfp_hwinfo.c | 23 +++--- drivers/net/nfp/nfpcore/nfp_mip.c | 16 ++-- drivers/net/nfp/nfpcore/nfp_mutex.c | 14 ++-- drivers/net/nfp/nfpcore/nfp_nffw.c | 10 +-- drivers/net/nfp/nfpcore/nfp_nsp.c | 36 +++++---- drivers/net/nfp/nfpcore/nfp_nsp_cmds.c | 10 +-- drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 38 +++++----- drivers/net/nfp/nfpcore/nfp_resource.c | 15 ++-- drivers/net/nfp/nfpcore/nfp_rtsym.c | 48 +++++------- drivers/net/nfp/nfpcore/nfp_target.h | 2 +- 17 files changed, 176 insertions(+), 202 deletions(-)
Comments
On Mon, 6 Feb 2023 15:05:46 +0800 Chaoyong He <chaoyong.he@corigine.com> wrote: > This patch series aims to better align the PMD with > the preferred DPDK coding style. > - Remove the usage of 'printf()' > - Remove the unneeded header file includes > - Explicitly compare pointer with NULL > - Explicitly compare integer with 0 > > James Hershaw (3): > net/nfp: remove usage of print statements > net/nfp: remove unnecessary include > net/nfp: explicitly compare to null and 0 > > drivers/net/nfp/nfp_common.c | 25 +++--- > drivers/net/nfp/nfp_cpp_bridge.c | 4 +- > drivers/net/nfp/nfp_ethdev.c | 2 +- > drivers/net/nfp/nfp_ethdev_vf.c | 2 +- > drivers/net/nfp/nfp_rxtx.c | 14 ++-- > drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 88 +++++++++------------- > drivers/net/nfp/nfpcore/nfp_cppcore.c | 31 ++++---- > drivers/net/nfp/nfpcore/nfp_hwinfo.c | 23 +++--- > drivers/net/nfp/nfpcore/nfp_mip.c | 16 ++-- > drivers/net/nfp/nfpcore/nfp_mutex.c | 14 ++-- > drivers/net/nfp/nfpcore/nfp_nffw.c | 10 +-- > drivers/net/nfp/nfpcore/nfp_nsp.c | 36 +++++---- > drivers/net/nfp/nfpcore/nfp_nsp_cmds.c | 10 +-- > drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 38 +++++----- > drivers/net/nfp/nfpcore/nfp_resource.c | 15 ++-- > drivers/net/nfp/nfpcore/nfp_rtsym.c | 48 +++++------- > drivers/net/nfp/nfpcore/nfp_target.h | 2 +- > 17 files changed, 176 insertions(+), 202 deletions(-) > I am working on getting rid of RTE_LOGTYPE_PMD; all driver should be using their own log type. Looks like this driver has a lot of places that need fixing. $ git grep 'PMD, ' flower/nfp_flower.c: RTE_LOG_DP(ERR, PMD, "RX Bad queue\n"); flower/nfp_flower.c: RTE_LOG_DP(ERR, PMD, "rxb does not exist!\n"); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: area alloc fail\n", __func__); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "area acquire failed\n"); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "nfp_cpp_area_write error\n"); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: area alloc failed\n", __func__); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "area acquire failed\n"); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "nfp_cpp_area_read error\n"); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: read error from socket\n", __func__); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: unknown cmd %d\n", __func__, cmd); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: read error from socket\n", __func__); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: error writing to socket\n", __func__); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: error writing to socket\n", __func__); nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: socket creation error. Service failed\n", nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: bind error (%d). Service failed\n", nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: listen error(%d). Service failed\n", nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: accept call error (%d)\n", nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: service failed\n", __func__); nfp_logs.h: RTE_LOG(level, PMD, "%s() rx: " fmt "\n", __func__, ## args) nfp_logs.h: RTE_LOG(level, PMD, "%s() tx: " fmt "\n", __func__, ## args) nfp_rxtx.c: RTE_LOG_DP(ERR, PMD, "RX Bad queue\n"); nfp_rxtx.c: RTE_LOG_DP(ERR, PMD, "rxb does not exist!\n"); nfpcore/nfp_cpp_pcie_ops.c: RTE_LOG(ERR, PMD, "NFP lock for secondary process failed\n"); nfpcore/nfp_cpp_pcie_ops.c: RTE_LOG(ERR, PMD, "NFP lock for secondary process failed\n");
> On Mon, 6 Feb 2023 15:05:46 +0800 > Chaoyong He <chaoyong.he@corigine.com> wrote: > > > This patch series aims to better align the PMD with the preferred DPDK > > coding style. > > - Remove the usage of 'printf()' > > - Remove the unneeded header file includes > > - Explicitly compare pointer with NULL > > - Explicitly compare integer with 0 > > > > James Hershaw (3): > > net/nfp: remove usage of print statements > > net/nfp: remove unnecessary include > > net/nfp: explicitly compare to null and 0 > > > > drivers/net/nfp/nfp_common.c | 25 +++--- > > drivers/net/nfp/nfp_cpp_bridge.c | 4 +- > > drivers/net/nfp/nfp_ethdev.c | 2 +- > > drivers/net/nfp/nfp_ethdev_vf.c | 2 +- > > drivers/net/nfp/nfp_rxtx.c | 14 ++-- > > drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 88 +++++++++------------- > > drivers/net/nfp/nfpcore/nfp_cppcore.c | 31 ++++---- > > drivers/net/nfp/nfpcore/nfp_hwinfo.c | 23 +++--- > > drivers/net/nfp/nfpcore/nfp_mip.c | 16 ++-- > > drivers/net/nfp/nfpcore/nfp_mutex.c | 14 ++-- > > drivers/net/nfp/nfpcore/nfp_nffw.c | 10 +-- > > drivers/net/nfp/nfpcore/nfp_nsp.c | 36 +++++---- > > drivers/net/nfp/nfpcore/nfp_nsp_cmds.c | 10 +-- > > drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 38 +++++----- > > drivers/net/nfp/nfpcore/nfp_resource.c | 15 ++-- > > drivers/net/nfp/nfpcore/nfp_rtsym.c | 48 +++++------- > > drivers/net/nfp/nfpcore/nfp_target.h | 2 +- > > 17 files changed, 176 insertions(+), 202 deletions(-) > > > > I am working on getting rid of RTE_LOGTYPE_PMD; all driver should be using > their own log type. > > Looks like this driver has a lot of places that need fixing. > $ git grep 'PMD, ' > flower/nfp_flower.c: RTE_LOG_DP(ERR, PMD, "RX Bad queue\n"); > flower/nfp_flower.c: RTE_LOG_DP(ERR, PMD, "rxb does not > exist!\n"); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: area alloc fail\n", > __func__); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "area acquire failed\n"); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "nfp_cpp_area_write > error\n"); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: area alloc failed\n", > __func__); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "area acquire failed\n"); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "nfp_cpp_area_read > error\n"); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: read error from > socket\n", __func__); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: unknown cmd %d\n", > __func__, cmd); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: read error from > socket\n", __func__); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: error writing to socket\n", > __func__); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: error writing to socket\n", > __func__); > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: socket creation error. > Service failed\n", > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: bind error (%d). Service > failed\n", > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: listen error(%d). Service > failed\n", > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: accept call error > (%d)\n", > nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: service failed\n", > __func__); > nfp_logs.h: RTE_LOG(level, PMD, "%s() rx: " fmt "\n", __func__, ## args) > nfp_logs.h: RTE_LOG(level, PMD, "%s() tx: " fmt "\n", __func__, ## args) > nfp_rxtx.c: RTE_LOG_DP(ERR, PMD, "RX Bad queue\n"); > nfp_rxtx.c: RTE_LOG_DP(ERR, PMD, "rxb does not exist!\n"); > nfpcore/nfp_cpp_pcie_ops.c: RTE_LOG(ERR, PMD, "NFP lock for > secondary process failed\n"); > nfpcore/nfp_cpp_pcie_ops.c: RTE_LOG(ERR, PMD, "NFP lock for > secondary process failed\n"); Thanks for your review! This patch series just the first step to make things right, and we will send out another patch series to refactor the log system of nfp PMD, which will solve the problem you point out. Do you think it's okay?
On 2/6/2023 7:05 AM, Chaoyong He wrote: > This patch series aims to better align the PMD with > the preferred DPDK coding style. > - Remove the usage of 'printf()' > - Remove the unneeded header file includes > - Explicitly compare pointer with NULL > - Explicitly compare integer with 0 > > James Hershaw (3): > net/nfp: remove usage of print statements > net/nfp: remove unnecessary include Series applied to dpdk-next-net/main, thanks.
On 2/7/2023 2:17 AM, Chaoyong He wrote: >> On Mon, 6 Feb 2023 15:05:46 +0800 >> Chaoyong He <chaoyong.he@corigine.com> wrote: >> >>> This patch series aims to better align the PMD with the preferred DPDK >>> coding style. >>> - Remove the usage of 'printf()' >>> - Remove the unneeded header file includes >>> - Explicitly compare pointer with NULL >>> - Explicitly compare integer with 0 >>> >>> James Hershaw (3): >>> net/nfp: remove usage of print statements >>> net/nfp: remove unnecessary include >>> net/nfp: explicitly compare to null and 0 >>> >>> drivers/net/nfp/nfp_common.c | 25 +++--- >>> drivers/net/nfp/nfp_cpp_bridge.c | 4 +- >>> drivers/net/nfp/nfp_ethdev.c | 2 +- >>> drivers/net/nfp/nfp_ethdev_vf.c | 2 +- >>> drivers/net/nfp/nfp_rxtx.c | 14 ++-- >>> drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 88 +++++++++------------- >>> drivers/net/nfp/nfpcore/nfp_cppcore.c | 31 ++++---- >>> drivers/net/nfp/nfpcore/nfp_hwinfo.c | 23 +++--- >>> drivers/net/nfp/nfpcore/nfp_mip.c | 16 ++-- >>> drivers/net/nfp/nfpcore/nfp_mutex.c | 14 ++-- >>> drivers/net/nfp/nfpcore/nfp_nffw.c | 10 +-- >>> drivers/net/nfp/nfpcore/nfp_nsp.c | 36 +++++---- >>> drivers/net/nfp/nfpcore/nfp_nsp_cmds.c | 10 +-- >>> drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 38 +++++----- >>> drivers/net/nfp/nfpcore/nfp_resource.c | 15 ++-- >>> drivers/net/nfp/nfpcore/nfp_rtsym.c | 48 +++++------- >>> drivers/net/nfp/nfpcore/nfp_target.h | 2 +- >>> 17 files changed, 176 insertions(+), 202 deletions(-) >>> >> >> I am working on getting rid of RTE_LOGTYPE_PMD; all driver should be using >> their own log type. >> >> Looks like this driver has a lot of places that need fixing. >> $ git grep 'PMD, ' >> flower/nfp_flower.c: RTE_LOG_DP(ERR, PMD, "RX Bad queue\n"); >> flower/nfp_flower.c: RTE_LOG_DP(ERR, PMD, "rxb does not >> exist!\n"); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: area alloc fail\n", >> __func__); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "area acquire failed\n"); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "nfp_cpp_area_write >> error\n"); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: area alloc failed\n", >> __func__); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "area acquire failed\n"); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "nfp_cpp_area_read >> error\n"); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: read error from >> socket\n", __func__); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: unknown cmd %d\n", >> __func__, cmd); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: read error from >> socket\n", __func__); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: error writing to socket\n", >> __func__); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: error writing to socket\n", >> __func__); >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: socket creation error. >> Service failed\n", >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: bind error (%d). Service >> failed\n", >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: listen error(%d). Service >> failed\n", >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: accept call error >> (%d)\n", >> nfp_cpp_bridge.c: RTE_LOG(ERR, PMD, "%s: service failed\n", >> __func__); >> nfp_logs.h: RTE_LOG(level, PMD, "%s() rx: " fmt "\n", __func__, ## args) >> nfp_logs.h: RTE_LOG(level, PMD, "%s() tx: " fmt "\n", __func__, ## args) >> nfp_rxtx.c: RTE_LOG_DP(ERR, PMD, "RX Bad queue\n"); >> nfp_rxtx.c: RTE_LOG_DP(ERR, PMD, "rxb does not exist!\n"); >> nfpcore/nfp_cpp_pcie_ops.c: RTE_LOG(ERR, PMD, "NFP lock for >> secondary process failed\n"); >> nfpcore/nfp_cpp_pcie_ops.c: RTE_LOG(ERR, PMD, "NFP lock for >> secondary process failed\n"); > > Thanks for your review! > This patch series just the first step to make things right, and we will send out another patch series > to refactor the log system of nfp PMD, which will solve the problem you point out. > Do you think it's okay? Thanks Chaoyong, I am merging this set as it is, remaining cleanups can be merged as they received.