mbox series

[v6,0/5] Replace use of RTE_LOGTYPE_USER1 in libraries

Message ID 20230220185001.50714-1-stephen@networkplumber.org (mailing list archive)
Headers
Series Replace use of RTE_LOGTYPE_USER1 in libraries |

Message

Stephen Hemminger Feb. 20, 2023, 6:49 p.m. UTC 
  The DPDK libraries and drivers should not be using the USER1 logtype.

v6 - fix checkpatch warnings

Stephen Hemminger (5):
  ip_frag: use a dynamic logtype
  reorder: use a dynamic logtype
  latencystats: use dynamic logtype
  vhost: use logtype instead of RTE_LOGTYPE_USER1
  ipsec: fix usage of RTE_LOGTYPE_USER1

 drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++-
 lib/ip_frag/ip_frag_common.h           | 5 ++++-
 lib/ip_frag/rte_ip_frag_common.c       | 2 ++
 lib/latencystats/rte_latencystats.c    | 3 ++-
 lib/reorder/rte_reorder.c              | 6 +++---
 lib/vhost/fd_man.c                     | 4 ++--
 lib/vhost/vhost_crypto.c               | 4 ++++
 7 files changed, 19 insertions(+), 8 deletions(-)

Comments

David Marchand Feb. 21, 2023, 10:42 a.m. UTC | #1 
On Mon, Feb 20, 2023 at 7:50 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The DPDK libraries and drivers should not be using the USER1 logtype.
>
> v6 - fix checkpatch warnings
>
> Stephen Hemminger (5):
>   ip_frag: use a dynamic logtype
>   reorder: use a dynamic logtype
>   latencystats: use dynamic logtype
>   vhost: use logtype instead of RTE_LOGTYPE_USER1
>   ipsec: fix usage of RTE_LOGTYPE_USER1
>
>  drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++-
>  lib/ip_frag/ip_frag_common.h           | 5 ++++-
>  lib/ip_frag/rte_ip_frag_common.c       | 2 ++
>  lib/latencystats/rte_latencystats.c    | 3 ++-
>  lib/reorder/rte_reorder.c              | 6 +++---
>  lib/vhost/fd_man.c                     | 4 ++--
>  lib/vhost/vhost_crypto.c               | 4 ++++
>  7 files changed, 19 insertions(+), 8 deletions(-)

Could you update the power library too?

lib/power/guest_channel.c:#define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1

Thanks.
Stephen Hemminger Feb. 21, 2023, 6:46 p.m. UTC | #2 
On Tue, 21 Feb 2023 11:42:45 +0100
David Marchand <david.marchand@redhat.com> wrote:

> On Mon, Feb 20, 2023 at 7:50 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The DPDK libraries and drivers should not be using the USER1 logtype.
> >
> > v6 - fix checkpatch warnings
> >
> > Stephen Hemminger (5):
> >   ip_frag: use a dynamic logtype
> >   reorder: use a dynamic logtype
> >   latencystats: use dynamic logtype
> >   vhost: use logtype instead of RTE_LOGTYPE_USER1
> >   ipsec: fix usage of RTE_LOGTYPE_USER1
> >
> >  drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++-
> >  lib/ip_frag/ip_frag_common.h           | 5 ++++-
> >  lib/ip_frag/rte_ip_frag_common.c       | 2 ++
> >  lib/latencystats/rte_latencystats.c    | 3 ++-
> >  lib/reorder/rte_reorder.c              | 6 +++---
> >  lib/vhost/fd_man.c                     | 4 ++--
> >  lib/vhost/vhost_crypto.c               | 4 ++++
> >  7 files changed, 19 insertions(+), 8 deletions(-)  
> 
> Could you update the power library too?
> 
> lib/power/guest_channel.c:#define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1

I picked that up in the other patch set because lib/power should be using
its own logtype.