mbox series

[v4,0/3] Replace obsolote test cases.

Message ID 20230620103235.539282-1-arkadiuszx.kusztal@intel.com (mailing list archive)
Headers
Series Replace obsolote test cases. |

Message

Arkadiusz Kusztal June 20, 2023, 10:32 a.m. UTC 
  This patchset removes obsolete test cases for RSA, MOD EXP, MOD INV.
Doing that, new way of handling ut_setup and ut_teardown was proposed.
Now both behave like constructor/desctuctor in the unit tests.
It frees particular alghorithm functions from any kind of responsibility to free resources for the new functions.

v2:
- fixed build problem with non compile-time constant
v3:
- rebased
- left old pwct tests intact
v4:
- fixed mailmap mismatch
- rebased

Arkadiusz Kusztal (3):
  app/test: remove obsolete test function
  app/test: add modexp and modinv functions
  app/test: add rsa none padding tests

 app/test/test_cryptodev_asym.c             | 775 +++++++++-----------
 app/test/test_cryptodev_mod_test_vectors.h | 814 +--------------------
 app/test/test_cryptodev_rsa_test_vectors.h | 322 ++++----
 3 files changed, 510 insertions(+), 1401 deletions(-)

Comments

Power, Ciara June 26, 2023, 12:56 p.m. UTC | #1 
> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Tuesday 20 June 2023 11:33
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Ji, Kai <kai.ji@intel.com>; Power, Ciara
> <ciara.power@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v4 0/3] Replace obsolote test cases.
> 
> This patchset removes obsolete test cases for RSA, MOD EXP, MOD INV.
> Doing that, new way of handling ut_setup and ut_teardown was proposed.
> Now both behave like constructor/desctuctor in the unit tests.
> It frees particular alghorithm functions from any kind of responsibility to free
> resources for the new functions.
> 
> v2:
> - fixed build problem with non compile-time constant
> v3:
> - rebased
> - left old pwct tests intact
> v4:
> - fixed mailmap mismatch
> - rebased
> 
> Arkadiusz Kusztal (3):
>   app/test: remove obsolete test function
>   app/test: add modexp and modinv functions
>   app/test: add rsa none padding tests
> 
>  app/test/test_cryptodev_asym.c             | 775 +++++++++-----------
>  app/test/test_cryptodev_mod_test_vectors.h | 814 +--------------------
> app/test/test_cryptodev_rsa_test_vectors.h | 322 ++++----
>  3 files changed, 510 insertions(+), 1401 deletions(-)
> 
> --
> 2.25.1

Series-acked-by: Ciara Power <ciara.power@intel.com>
Gowrishankar Muthukrishnan July 3, 2023, 11:35 a.m. UTC | #2 
Series verified with openssl pmd.

Acked-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>

Thanks.
Akhil Goyal July 3, 2023, 2:14 p.m. UTC | #3 
> Subject: RE: [EXT] [PATCH v4 0/3] Replace obsolote test cases.
> 
> Series verified with openssl pmd.
> 
> Acked-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> 
Series applied to dpdk-next-crypto

There seems to be a false error reported by CI. Hence ignoring it.

Thanks.