mbox series

[v3,00/14] Use rte_pktmbuf_mtod_offset() where possible

Message ID 20230706175938.62721-1-stephen@networkplumber.org (mailing list archive)
Headers
Series Use rte_pktmbuf_mtod_offset() where possible |

Message

Stephen Hemminger July 6, 2023, 5:59 p.m. UTC 
  Run the coccinelle script for rte_pktmbuf_mtod_offset
against current main branch.

v3 - rebase to cover gro changes

Stephen Hemminger (14):
  gro: use rte_pktmbuf_mtod_offset
  gso: use rte_pktmbuf_mtod_offset
  testpmd: use rte_pktmbuf_mtod_offset
  test: cryptodev use rte_pktmbuf_mtod_offset
  examples: use rte_pktmbuf_mtod_offset
  net/tap: use rte_pktmbuf_mtod_offset
  net/nfp: use rte_pktmbuf_mtod_offset
  crypto/ipsec_mb: use rte_pktmbuf_mtod_offset
  crypto/qat: use rte_pktmbuf_mtod_offset
  crypto/cnxk: use rte_ptkmbuf_mtod_offset
  common/cpt: use rte_pktmbuf_mtod_offset
  crypto/caam_jr: use rte_pktmbuf_mtod_offset
  net/mlx4: use rte_pktmbuf_mtod_offset
  baseband/fpga_5gnr: use rte_pktmbu_mtod_offset

 app/test-pmd/ieee1588fwd.c                    |  4 +-
 app/test/test_cryptodev.c                     | 66 ++++++++++---------
 .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         |  7 +-
 drivers/common/cpt/cpt_ucode.h                | 10 ++-
 drivers/crypto/caam_jr/caam_jr.c              |  8 +--
 drivers/crypto/cnxk/cn9k_cryptodev_ops.c      |  2 +-
 drivers/crypto/cnxk/cnxk_se.h                 |  5 +-
 drivers/crypto/ipsec_mb/pmd_kasumi.c          | 16 ++---
 drivers/crypto/ipsec_mb/pmd_snow3g.c          | 35 ++++------
 drivers/crypto/ipsec_mb/pmd_zuc.c             | 16 ++---
 drivers/crypto/qat/dev/qat_crypto_pmd_gens.h  |  9 +--
 drivers/crypto/qat/qat_sym.h                  |  9 +--
 drivers/net/mlx4/mlx4_rxtx.c                  |  6 +-
 drivers/net/nfp/flower/nfp_flower_cmsg.h      |  3 +-
 drivers/net/nfp/flower/nfp_flower_ctrl.c      |  4 +-
 drivers/net/tap/rte_eth_tap.c                 |  3 +-
 examples/l2fwd-crypto/main.c                  | 16 +++--
 examples/ptpclient/ptpclient.c                | 18 ++---
 lib/gro/gro_tcp.h                             |  2 +-
 lib/gro/gro_tcp4.c                            |  2 +-
 lib/gro/gro_udp4.c                            |  4 +-
 lib/gro/gro_vxlan_tcp4.c                      |  4 +-
 lib/gro/gro_vxlan_udp4.c                      |  4 +-
 lib/gso/gso_common.h                          | 11 ++--
 lib/gso/gso_tcp4.c                            |  8 +--
 lib/gso/gso_tunnel_tcp4.c                     | 12 ++--
 lib/gso/gso_tunnel_udp4.c                     | 18 ++---
 27 files changed, 150 insertions(+), 152 deletions(-)

Comments

Ferruh Yigit July 7, 2023, 12:47 p.m. UTC | #1 
On 7/6/2023 6:59 PM, Stephen Hemminger wrote:
> Run the coccinelle script for rte_pktmbuf_mtod_offset
> against current main branch.
> 
> v3 - rebase to cover gro changes
> 

There is one more instance in 'gro_tcp6.c'

```
$ ag -s 'rte_pktmbuf_mtod\(.*\).*\+' lib/
lib/gro/gro_tcp6.c
121:    ipv6_hdr = (struct rte_ipv6_hdr *)(rte_pktmbuf_mtod(pkt, char *) +
```


> Stephen Hemminger (14):
>   gro: use rte_pktmbuf_mtod_offset
>   gso: use rte_pktmbuf_mtod_offset
>   testpmd: use rte_pktmbuf_mtod_offset
>   test: cryptodev use rte_pktmbuf_mtod_offset
>   examples: use rte_pktmbuf_mtod_offset
>   net/tap: use rte_pktmbuf_mtod_offset
>   net/nfp: use rte_pktmbuf_mtod_offset
>   crypto/ipsec_mb: use rte_pktmbuf_mtod_offset
>   crypto/qat: use rte_pktmbuf_mtod_offset
>   crypto/cnxk: use rte_ptkmbuf_mtod_offset
>   common/cpt: use rte_pktmbuf_mtod_offset
>   crypto/caam_jr: use rte_pktmbuf_mtod_offset
>   net/mlx4: use rte_pktmbuf_mtod_offset
>   baseband/fpga_5gnr: use rte_pktmbu_mtod_offset


For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>

There are a few minor issues commented on individual patches.