mbox series

[0/5] net/hns3: some performance optimizations

Message ID 20230711102448.11627-1-liudongdong3@huawei.com (mailing list archive)
Headers
Series net/hns3: some performance optimizations |

Message

Dongdong Liu July 11, 2023, 10:24 a.m. UTC 
  This patchset is to do some performance optimizations for hns3.

Huisong Li (5):
  net/hns3: fix incorrect index to look up table in NEON Rx
  net/hns3: fix the order of NEON Rx code
  net/hns3: optimize free mbuf code for SVE Tx
  net/hns3: optimize the rearm mbuf function for SVE Rx
  net/hns3: optimize SVE Rx performance

 drivers/net/hns3/hns3_rxtx_vec.c      |  51 ------
 drivers/net/hns3/hns3_rxtx_vec.h      |  51 ++++++
 drivers/net/hns3/hns3_rxtx_vec_neon.h |  82 ++++-----
 drivers/net/hns3/hns3_rxtx_vec_sve.c  | 230 ++++----------------------
 4 files changed, 114 insertions(+), 300 deletions(-)

--
2.22.0

Comments

Ferruh Yigit July 11, 2023, 10:48 a.m. UTC | #1 
On 7/11/2023 11:24 AM, Dongdong Liu wrote:
> This patchset is to do some performance optimizations for hns3.
> 
> Huisong Li (5):
>   net/hns3: fix incorrect index to look up table in NEON Rx
>   net/hns3: fix the order of NEON Rx code
>   net/hns3: optimize free mbuf code for SVE Tx
>   net/hns3: optimize the rearm mbuf function for SVE Rx
>   net/hns3: optimize SVE Rx performance
>

Hi Dongdong, Huisong,

Release is around a week away, OK to get critical fixes, but I can see
there are some optimizations as well.

Is this set for current release or next release?
Dongdong Liu July 11, 2023, 11:27 a.m. UTC | #2 
Hi, Ferruh
On 2023/7/11 18:48, Ferruh Yigit wrote:
> On 7/11/2023 11:24 AM, Dongdong Liu wrote:
>> This patchset is to do some performance optimizations for hns3.
>>
>> Huisong Li (5):
>>   net/hns3: fix incorrect index to look up table in NEON Rx
>>   net/hns3: fix the order of NEON Rx code
>>   net/hns3: optimize free mbuf code for SVE Tx
>>   net/hns3: optimize the rearm mbuf function for SVE Rx
>>   net/hns3: optimize SVE Rx performance
>>
>
> Hi Dongdong, Huisong,
>
> Release is around a week away, OK to get critical fixes, but I can see
> there are some optimizations as well.
>
> Is this set for current release or next release?

If possible, we want this patchset can be applied for current release.

Thanks,
Dongdong
>
> .
>
Ferruh Yigit July 11, 2023, 12:26 p.m. UTC | #3 
On 7/11/2023 12:27 PM, Dongdong Liu wrote:
> Hi, Ferruh
> On 2023/7/11 18:48, Ferruh Yigit wrote:
>> On 7/11/2023 11:24 AM, Dongdong Liu wrote:
>>> This patchset is to do some performance optimizations for hns3.
>>>
>>> Huisong Li (5):
>>>   net/hns3: fix incorrect index to look up table in NEON Rx
>>>   net/hns3: fix the order of NEON Rx code
>>>   net/hns3: optimize free mbuf code for SVE Tx
>>>   net/hns3: optimize the rearm mbuf function for SVE Rx
>>>   net/hns3: optimize SVE Rx performance
>>>
>>
>> Hi Dongdong, Huisong,
>>
>> Release is around a week away, OK to get critical fixes, but I can see
>> there are some optimizations as well.
>>
>> Is this set for current release or next release?
> 
> If possible, we want this patchset can be applied for current release.
> 
> 

I can see there is a good performance increase, this makes harder to
defer but I am feeling this level of change is risky and you won't have
time to test and fix any issue.

Let me get first patch, as it is a fix. I can merge remaining patches
early in next release cycle.
@Thomas, what do you think?