mbox series

[v2,0/2] Remove disabled functionality

Message ID 20230801160500.67480-1-stephen@networkplumber.org (mailing list archive)
Headers
Series Remove disabled functionality |

Message

Stephen Hemminger Aug. 1, 2023, 4:04 p.m. UTC 
  The KNI and flow_classify library were already marked disabled
in 23.11 release.

Stephen Hemminger (2):
  flow_classify: remove library
  kni: remove deprecated kernel network interface

 MAINTAINERS                                   |  17 -
 app/test/meson.build                          |   6 -
 app/test/test_flow_classify.c                 | 895 ------------------
 app/test/test_flow_classify.h                 |  26 -
 app/test/test_kni.c                           | 740 ---------------
 doc/api/doxy-api-index.md                     |   3 -
 doc/api/doxy-api.conf.in                      |   2 -
 doc/guides/contributing/documentation.rst     |   4 +-
 doc/guides/freebsd_gsg/build_sample_apps.rst  |   2 +-
 doc/guides/freebsd_gsg/install_from_ports.rst |   2 +-
 doc/guides/howto/flow_bifurcation.rst         |   3 +-
 doc/guides/nics/index.rst                     |   1 -
 doc/guides/nics/kni.rst                       | 170 ----
 doc/guides/nics/virtio.rst                    |  92 +-
 .../prog_guide/env_abstraction_layer.rst      |   2 -
 doc/guides/prog_guide/flow_classify_lib.rst   | 424 ---------
 doc/guides/prog_guide/glossary.rst            |   3 -
 doc/guides/prog_guide/index.rst               |   2 -
 .../prog_guide/kernel_nic_interface.rst       | 423 ---------
 doc/guides/prog_guide/packet_framework.rst    |   9 +-
 doc/guides/rel_notes/deprecation.rst          |  15 +-
 doc/guides/rel_notes/release_23_11.rst        |   4 +
 doc/guides/sample_app_ug/flow_classify.rst    | 242 -----
 doc/guides/sample_app_ug/index.rst            |   1 -
 doc/guides/sample_app_ug/ip_pipeline.rst      |  22 -
 drivers/net/cnxk/cnxk_ethdev.c                |   2 +-
 drivers/net/kni/meson.build                   |  11 -
 drivers/net/kni/rte_eth_kni.c                 | 524 ----------
 drivers/net/meson.build                       |   1 -
 examples/flow_classify/Makefile               |  51 -
 examples/flow_classify/flow_classify.c        | 878 -----------------
 examples/flow_classify/ipv4_rules_file.txt    |  14 -
 examples/flow_classify/meson.build            |  13 -
 examples/ip_pipeline/Makefile                 |   1 -
 examples/ip_pipeline/cli.c                    |  95 --
 examples/ip_pipeline/examples/kni.cli         |  69 --
 examples/ip_pipeline/kni.c                    | 168 ----
 examples/ip_pipeline/kni.h                    |  46 -
 examples/ip_pipeline/main.c                   |  10 -
 examples/ip_pipeline/meson.build              |   1 -
 examples/ip_pipeline/pipeline.c               |  57 --
 examples/ip_pipeline/pipeline.h               |   2 -
 examples/meson.build                          |   1 -
 kernel/linux/kni/Kbuild                       |   6 -
 kernel/linux/kni/compat.h                     | 157 ---
 kernel/linux/kni/kni_dev.h                    | 137 ---
 kernel/linux/kni/kni_fifo.h                   |  87 --
 kernel/linux/kni/kni_misc.c                   | 719 --------------
 kernel/linux/kni/kni_net.c                    | 878 -----------------
 kernel/linux/kni/meson.build                  |  41 -
 kernel/linux/meson.build                      |   2 +-
 lib/eal/common/eal_common_log.c               |   1 -
 lib/eal/include/rte_log.h                     |   2 +-
 lib/eal/linux/eal.c                           |  19 -
 lib/flow_classify/meson.build                 |  12 -
 lib/flow_classify/rte_flow_classify.c         | 670 -------------
 lib/flow_classify/rte_flow_classify.h         | 284 ------
 lib/flow_classify/rte_flow_classify_parse.c   | 532 -----------
 lib/flow_classify/rte_flow_classify_parse.h   |  58 --
 lib/flow_classify/version.map                 |  13 -
 lib/kni/meson.build                           |  21 -
 lib/kni/rte_kni.c                             | 843 -----------------
 lib/kni/rte_kni.h                             | 269 ------
 lib/kni/rte_kni_common.h                      | 147 ---
 lib/kni/rte_kni_fifo.h                        | 117 ---
 lib/kni/version.map                           |  24 -
 lib/meson.build                               |   9 -
 lib/port/meson.build                          |   6 -
 lib/port/rte_port_kni.c                       | 515 ----------
 lib/port/rte_port_kni.h                       |  63 --
 lib/port/version.map                          |   3 -
 meson_options.txt                             |   2 +-
 72 files changed, 18 insertions(+), 10673 deletions(-)
 delete mode 100644 app/test/test_flow_classify.c
 delete mode 100644 app/test/test_flow_classify.h
 delete mode 100644 app/test/test_kni.c
 delete mode 100644 doc/guides/nics/kni.rst
 delete mode 100644 doc/guides/prog_guide/flow_classify_lib.rst
 delete mode 100644 doc/guides/prog_guide/kernel_nic_interface.rst
 delete mode 100644 doc/guides/sample_app_ug/flow_classify.rst
 delete mode 100644 drivers/net/kni/meson.build
 delete mode 100644 drivers/net/kni/rte_eth_kni.c
 delete mode 100644 examples/flow_classify/Makefile
 delete mode 100644 examples/flow_classify/flow_classify.c
 delete mode 100644 examples/flow_classify/ipv4_rules_file.txt
 delete mode 100644 examples/flow_classify/meson.build
 delete mode 100644 examples/ip_pipeline/examples/kni.cli
 delete mode 100644 examples/ip_pipeline/kni.c
 delete mode 100644 examples/ip_pipeline/kni.h
 delete mode 100644 kernel/linux/kni/Kbuild
 delete mode 100644 kernel/linux/kni/compat.h
 delete mode 100644 kernel/linux/kni/kni_dev.h
 delete mode 100644 kernel/linux/kni/kni_fifo.h
 delete mode 100644 kernel/linux/kni/kni_misc.c
 delete mode 100644 kernel/linux/kni/kni_net.c
 delete mode 100644 kernel/linux/kni/meson.build
 delete mode 100644 lib/flow_classify/meson.build
 delete mode 100644 lib/flow_classify/rte_flow_classify.c
 delete mode 100644 lib/flow_classify/rte_flow_classify.h
 delete mode 100644 lib/flow_classify/rte_flow_classify_parse.c
 delete mode 100644 lib/flow_classify/rte_flow_classify_parse.h
 delete mode 100644 lib/flow_classify/version.map
 delete mode 100644 lib/kni/meson.build
 delete mode 100644 lib/kni/rte_kni.c
 delete mode 100644 lib/kni/rte_kni.h
 delete mode 100644 lib/kni/rte_kni_common.h
 delete mode 100644 lib/kni/rte_kni_fifo.h
 delete mode 100644 lib/kni/version.map
 delete mode 100644 lib/port/rte_port_kni.c
 delete mode 100644 lib/port/rte_port_kni.h

Comments

David Marchand Aug. 4, 2023, 1:02 p.m. UTC | #1 
On Tue, Aug 1, 2023 at 6:05 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The KNI and flow_classify library were already marked disabled
> in 23.11 release.
>
> Stephen Hemminger (2):
>   flow_classify: remove library
>   kni: remove deprecated kernel network interface
>
>  MAINTAINERS                                   |  17 -
>  app/test/meson.build                          |   6 -
>  app/test/test_flow_classify.c                 | 895 ------------------
>  app/test/test_flow_classify.h                 |  26 -
>  app/test/test_kni.c                           | 740 ---------------
>  doc/api/doxy-api-index.md                     |   3 -
>  doc/api/doxy-api.conf.in                      |   2 -
>  doc/guides/contributing/documentation.rst     |   4 +-
>  doc/guides/freebsd_gsg/build_sample_apps.rst  |   2 +-
>  doc/guides/freebsd_gsg/install_from_ports.rst |   2 +-
>  doc/guides/howto/flow_bifurcation.rst         |   3 +-
>  doc/guides/nics/index.rst                     |   1 -
>  doc/guides/nics/kni.rst                       | 170 ----
>  doc/guides/nics/virtio.rst                    |  92 +-
>  .../prog_guide/env_abstraction_layer.rst      |   2 -
>  doc/guides/prog_guide/flow_classify_lib.rst   | 424 ---------
>  doc/guides/prog_guide/glossary.rst            |   3 -
>  doc/guides/prog_guide/index.rst               |   2 -
>  .../prog_guide/kernel_nic_interface.rst       | 423 ---------
>  doc/guides/prog_guide/packet_framework.rst    |   9 +-
>  doc/guides/rel_notes/deprecation.rst          |  15 +-
>  doc/guides/rel_notes/release_23_11.rst        |   4 +
>  doc/guides/sample_app_ug/flow_classify.rst    | 242 -----
>  doc/guides/sample_app_ug/index.rst            |   1 -
>  doc/guides/sample_app_ug/ip_pipeline.rst      |  22 -
>  drivers/net/cnxk/cnxk_ethdev.c                |   2 +-
>  drivers/net/kni/meson.build                   |  11 -
>  drivers/net/kni/rte_eth_kni.c                 | 524 ----------
>  drivers/net/meson.build                       |   1 -
>  examples/flow_classify/Makefile               |  51 -
>  examples/flow_classify/flow_classify.c        | 878 -----------------
>  examples/flow_classify/ipv4_rules_file.txt    |  14 -
>  examples/flow_classify/meson.build            |  13 -
>  examples/ip_pipeline/Makefile                 |   1 -
>  examples/ip_pipeline/cli.c                    |  95 --
>  examples/ip_pipeline/examples/kni.cli         |  69 --
>  examples/ip_pipeline/kni.c                    | 168 ----
>  examples/ip_pipeline/kni.h                    |  46 -
>  examples/ip_pipeline/main.c                   |  10 -
>  examples/ip_pipeline/meson.build              |   1 -
>  examples/ip_pipeline/pipeline.c               |  57 --
>  examples/ip_pipeline/pipeline.h               |   2 -
>  examples/meson.build                          |   1 -
>  kernel/linux/kni/Kbuild                       |   6 -
>  kernel/linux/kni/compat.h                     | 157 ---
>  kernel/linux/kni/kni_dev.h                    | 137 ---
>  kernel/linux/kni/kni_fifo.h                   |  87 --
>  kernel/linux/kni/kni_misc.c                   | 719 --------------
>  kernel/linux/kni/kni_net.c                    | 878 -----------------
>  kernel/linux/kni/meson.build                  |  41 -
>  kernel/linux/meson.build                      |   2 +-
>  lib/eal/common/eal_common_log.c               |   1 -
>  lib/eal/include/rte_log.h                     |   2 +-
>  lib/eal/linux/eal.c                           |  19 -
>  lib/flow_classify/meson.build                 |  12 -
>  lib/flow_classify/rte_flow_classify.c         | 670 -------------
>  lib/flow_classify/rte_flow_classify.h         | 284 ------
>  lib/flow_classify/rte_flow_classify_parse.c   | 532 -----------
>  lib/flow_classify/rte_flow_classify_parse.h   |  58 --
>  lib/flow_classify/version.map                 |  13 -
>  lib/kni/meson.build                           |  21 -
>  lib/kni/rte_kni.c                             | 843 -----------------
>  lib/kni/rte_kni.h                             | 269 ------
>  lib/kni/rte_kni_common.h                      | 147 ---
>  lib/kni/rte_kni_fifo.h                        | 117 ---
>  lib/kni/version.map                           |  24 -
>  lib/meson.build                               |   9 -
>  lib/port/meson.build                          |   6 -
>  lib/port/rte_port_kni.c                       | 515 ----------
>  lib/port/rte_port_kni.h                       |  63 --
>  lib/port/version.map                          |   3 -
>  meson_options.txt                             |   2 +-
>  72 files changed, 18 insertions(+), 10673 deletions(-)
>  delete mode 100644 app/test/test_flow_classify.c
>  delete mode 100644 app/test/test_flow_classify.h
>  delete mode 100644 app/test/test_kni.c
>  delete mode 100644 doc/guides/nics/kni.rst
>  delete mode 100644 doc/guides/prog_guide/flow_classify_lib.rst
>  delete mode 100644 doc/guides/prog_guide/kernel_nic_interface.rst
>  delete mode 100644 doc/guides/sample_app_ug/flow_classify.rst
>  delete mode 100644 drivers/net/kni/meson.build
>  delete mode 100644 drivers/net/kni/rte_eth_kni.c
>  delete mode 100644 examples/flow_classify/Makefile
>  delete mode 100644 examples/flow_classify/flow_classify.c
>  delete mode 100644 examples/flow_classify/ipv4_rules_file.txt
>  delete mode 100644 examples/flow_classify/meson.build
>  delete mode 100644 examples/ip_pipeline/examples/kni.cli
>  delete mode 100644 examples/ip_pipeline/kni.c
>  delete mode 100644 examples/ip_pipeline/kni.h
>  delete mode 100644 kernel/linux/kni/Kbuild
>  delete mode 100644 kernel/linux/kni/compat.h
>  delete mode 100644 kernel/linux/kni/kni_dev.h
>  delete mode 100644 kernel/linux/kni/kni_fifo.h
>  delete mode 100644 kernel/linux/kni/kni_misc.c
>  delete mode 100644 kernel/linux/kni/kni_net.c
>  delete mode 100644 kernel/linux/kni/meson.build
>  delete mode 100644 lib/flow_classify/meson.build
>  delete mode 100644 lib/flow_classify/rte_flow_classify.c
>  delete mode 100644 lib/flow_classify/rte_flow_classify.h
>  delete mode 100644 lib/flow_classify/rte_flow_classify_parse.c
>  delete mode 100644 lib/flow_classify/rte_flow_classify_parse.h
>  delete mode 100644 lib/flow_classify/version.map
>  delete mode 100644 lib/kni/meson.build
>  delete mode 100644 lib/kni/rte_kni.c
>  delete mode 100644 lib/kni/rte_kni.h
>  delete mode 100644 lib/kni/rte_kni_common.h
>  delete mode 100644 lib/kni/rte_kni_fifo.h
>  delete mode 100644 lib/kni/version.map
>  delete mode 100644 lib/port/rte_port_kni.c
>  delete mode 100644 lib/port/rte_port_kni.h

It took some time to remove this code (especially the KNI bits).
Thanks to all who contributed to the effort.

Series applied, thanks.
Stephen Hemminger Aug. 4, 2023, 4:05 p.m. UTC | #2 
On Fri, 4 Aug 2023 15:02:23 +0200
David Marchand <david.marchand@redhat.com> wrote:

> It took some time to remove this code (especially the KNI bits).
> Thanks to all who contributed to the effort.
> 
> Series applied, thanks.

Thanks, still waiting for the first user complaints about this.
No one ever reads the release notes.