From patchwork Tue Aug 15 14:50:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 59 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE28943073; Tue, 15 Aug 2023 16:50:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B05D14114B; Tue, 15 Aug 2023 16:50:32 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mails.dpdk.org (Postfix) with ESMTP id 48A5740F17 for ; Tue, 15 Aug 2023 16:50:31 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B594F61F16 for ; Tue, 15 Aug 2023 14:50:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5780CC433C8; Tue, 15 Aug 2023 14:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692111030; bh=ISt9AaivIU2OGgByyi9DS3bCAIIl7seXP4YgXUlYF6g=; h=From:To:Cc:Subject:Date:From; b=nen1opy8xZBeBrKDfvZll4w43Ki8rT8W48w35zefh8guKPYMk3apxRwsLPn+hCFPg UXAzg28ECJhltExYf0/Q9Hq0YUGoomWTyaRhVIudXvwlLSVMucXbyUHelovCbsgtHa nccNpnpZPdiY5BmXHoWn6vdZlxz7aEWJkn6WL7jAT1mPvjLQ+gHG93M7iGM5QdxUy5 +vIheNHUfmOb5LF7ZaVA3fCuI1NmPWnPceMnpEWyvm85NcgoqLz8g62/fg5Z2HXqQg PotkJ+LMUn1uwrb9CrxrjGiQuJ3XubPs8cotYW6UJ33L6UwAAaKqNBPN9XDOczNmmA 5lRXbc09n/wBg== From: okaya@kernel.org To: Cc: dev@dpdk.org, Sinan Kaya Subject: [PATCH v4 0/8] support reinit flow Date: Tue, 15 Aug 2023 10:50:15 -0400 Message-Id: <20230815145023.1386003-1-okaya@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sinan Kaya We want to be able to call rte_eal_init() and rte_eal_cleanup() APIs back to back for maintanance reasons. Here is a summary of the code we have seen so far: 1. some code support getting called multiple times by keeping a static variable. 2. some code initializes once but never clean up after them and don't have a cleanup API. 3. some code assumes that they only get called once during the lifecycle of the process. Most changes in this patch center around following the #1 design principle. Why? It is not always ideal to reinitialize a DPDK process. Memory needs to be reinitialized, hugetables need to warm up etc. Changed from v1: Fix checkpatch warnings v2: rebase to most recent DPDK. v3: pick up Stephen's "eal: cleanup plugins data" as a pre-requisite patch. Graham Whyte (1): eal: fixes for re-initialization issues Sinan Kaya (6): tailq: skip init if already initialized eal_memzone: bail out on initialized memseg: init once eal_memory: skip initialization eal_interrupts: don't reinitialize threads eal: initialize worker threads once Stephen Hemminger (1): eal: cleanup plugins data lib/eal/common/eal_common_memory.c | 5 +++ lib/eal/common/eal_common_memzone.c | 7 +++ lib/eal/common/eal_common_options.c | 20 +++++++++ lib/eal/common/eal_common_tailqs.c | 20 ++++++--- lib/eal/common/eal_options.h | 1 + lib/eal/common/malloc_heap.c | 7 +++ lib/eal/linux/eal.c | 66 ++++++++++++++++------------- lib/eal/linux/eal_interrupts.c | 7 +++ lib/eal/linux/eal_memory.c | 12 +++++- 9 files changed, 108 insertions(+), 37 deletions(-)