[0/3] fix some bug for hns3

Message ID 20231127133903.1138657-1-huangdengdui@huawei.com (mailing list archive)
Headers
Series fix some bug for hns3 |

Message

Dengdui Huang Nov. 27, 2023, 1:39 p.m. UTC
  Dengdui Huang (3):
  net/hns3: fix reset detect be ignored
  net/hns3: fix VF wrong clear reset status
  net/hns3: fix the VF reset interrupted possibly

 drivers/net/hns3/hns3_ethdev.c    |  5 ++++-
 drivers/net/hns3/hns3_ethdev.h    | 12 ++++++++++++
 drivers/net/hns3/hns3_ethdev_vf.c | 19 +++++++++++++++++--
 drivers/net/hns3/hns3_intr.c      |  4 ++--
 4 files changed, 35 insertions(+), 5 deletions(-)
  

Comments

Jie Hai Nov. 27, 2023, 1:55 p.m. UTC | #1
On 2023/11/27 21:39, Dengdui Huang wrote:
> Dengdui Huang (3):
>    net/hns3: fix reset detect be ignored
>    net/hns3: fix VF wrong clear reset status
>    net/hns3: fix the VF reset interrupted possibly
Hi, Dengdui,

Good fix.
For the patchset,
Acked-by: Jie Hai <haijie1@huawei.com>

Thank,
Jie Hai
> 
>   drivers/net/hns3/hns3_ethdev.c    |  5 ++++-
>   drivers/net/hns3/hns3_ethdev.h    | 12 ++++++++++++
>   drivers/net/hns3/hns3_ethdev_vf.c | 19 +++++++++++++++++--
>   drivers/net/hns3/hns3_intr.c      |  4 ++--
>   4 files changed, 35 insertions(+), 5 deletions(-)
>
  
Ferruh Yigit Nov. 27, 2023, 6:33 p.m. UTC | #2
On 11/27/2023 1:55 PM, Jie Hai wrote:
> On 2023/11/27 21:39, Dengdui Huang wrote:
>> Dengdui Huang (3):
>>    net/hns3: fix reset detect be ignored
>>    net/hns3: fix VF wrong clear reset status
>>    net/hns3: fix the VF reset interrupted possibly
> Hi, Dengdui,
> 
> Good fix.
> For the patchset,
> Acked-by: Jie Hai <haijie1@huawei.com>
> 


Hi Jie, Dengdui, is this set for this release, which is a few days away?
My suggestion is to wait next version as issues doesn't look critical.


I applied set to next-net, but leaving decision to pull it for the
release or not to Thomas/David.

Applied to dpdk-next-net/main, thanks.
  
Jie Hai Nov. 28, 2023, 3:33 a.m. UTC | #3
On 2023/11/28 2:33, Ferruh Yigit wrote:
> On 11/27/2023 1:55 PM, Jie Hai wrote:
>> On 2023/11/27 21:39, Dengdui Huang wrote:
>>> Dengdui Huang (3):
>>>     net/hns3: fix reset detect be ignored
>>>     net/hns3: fix VF wrong clear reset status
>>>     net/hns3: fix the VF reset interrupted possibly
>> Hi, Dengdui,
>>
>> Good fix.
>> For the patchset,
>> Acked-by: Jie Hai <haijie1@huawei.com>
>>
> 
> 
> Hi Jie, Dengdui, is this set for this release, which is a few days away?
> My suggestion is to wait next version as issues doesn't look critical.
> 
> 
> I applied set to next-net, but leaving decision to pull it for the
> release or not to Thomas/David.
> 
> Applied to dpdk-next-net/main, thanks.
> 
Hi, Ferruh, Thomas and David,

I'm sorry that this problem is a little serious.

a) Without [PATCH 2/3], when the VF executes the 
hns3_clear_reset_event(), unexpected memory is written.
As a result, unexpected errors occur in the program or even the app may 
crash.
b) Without [PATCH 3/3], there is a low probability that the app is 
unavailable after the FLR reset is done.
c) In addition, some LTS versions have the same problem.

Therefore, we hope that the problem can be solved in the current version.

Thanks,
Jie Hai
> .
  
Thomas Monjalon Nov. 28, 2023, 10:31 a.m. UTC | #4
28/11/2023 04:33, Jie Hai:
> On 2023/11/28 2:33, Ferruh Yigit wrote:
> > On 11/27/2023 1:55 PM, Jie Hai wrote:
> >> On 2023/11/27 21:39, Dengdui Huang wrote:
> >>> Dengdui Huang (3):
> >>>     net/hns3: fix reset detect be ignored
> >>>     net/hns3: fix VF wrong clear reset status
> >>>     net/hns3: fix the VF reset interrupted possibly
> >> Hi, Dengdui,
> >>
> >> Good fix.
> >> For the patchset,
> >> Acked-by: Jie Hai <haijie1@huawei.com>
> >>
> > 
> > 
> > Hi Jie, Dengdui, is this set for this release, which is a few days away?
> > My suggestion is to wait next version as issues doesn't look critical.
> > 
> > 
> > I applied set to next-net, but leaving decision to pull it for the
> > release or not to Thomas/David.
> > 
> > Applied to dpdk-next-net/main, thanks.
> > 
> Hi, Ferruh, Thomas and David,
> 
> I'm sorry that this problem is a little serious.
> 
> a) Without [PATCH 2/3], when the VF executes the 
> hns3_clear_reset_event(), unexpected memory is written.
> As a result, unexpected errors occur in the program or even the app may 
> crash.
> b) Without [PATCH 3/3], there is a low probability that the app is 
> unavailable after the FLR reset is done.
> c) In addition, some LTS versions have the same problem.
> 
> Therefore, we hope that the problem can be solved in the current version.

OK applied, thanks.