mbox series

[24.03,v2,0/5] add new command line argument parsing library

Message ID 20231128140745.595481-1-euan.bourke@intel.com (mailing list archive)
Headers
Series add new command line argument parsing library |

Message

Euan Bourke Nov. 28, 2023, 2:07 p.m. UTC 
  A recent thread on the mailing list[1] discussed corelist and coremask
parsing and the idea of a new library dedicated to command line parsing
was mentioned[2]. This patchset adds the library, along with the new
APIs, edits to EAL functions to call the API instead of implementing
their own, and changes to the dlb2 driver to call the API.

The new APIs work similar to existing functions in EAL, however instead
of filling a core array like this:
[1, -1, -1, 2, 3] (a non -1 refers to an 'active core' at that index)
It fills it like this:
[0, 3, 4] (with the value at each index being an 'active core').

The new APIs will also return the number of cores contained in the
passed corelist/coremask, so in the above example, 3 would be returned.

Planned future work for the library contains more parsing functions such
as a "core string parser" which would take a string and return whether
its a corelist or coremask based on heuristics. This could then be
passed into the appropriate function.

There are also several example applications that implement their own
version of a corelist/coremask parser, so the plan is to rework those in
future versions of this patch.

[1] https://mails.dpdk.org/archives/dev/2023-November/280957.html
[2] https://mails.dpdk.org/archives/dev/2023-November/280966.html


v2:
* changes to EAL service core related parsers to call API.
* various optimisations in core_bit related functions in arg_parser.c.
* add lib to list for windows build.
* minor changes for issues flagged during review.

Euan Bourke (5):
  arg_parser: new library for command line parsing
  arg_parser: add new coremask parsing API
  eal: add support for new arg parsing library
  eal: update to service core related parsers
  event/dlb2: add new arg parsing library API support

 .mailmap                                   |   1 +
 MAINTAINERS                                |   4 +
 doc/api/doxy-api-index.md                  |   3 +-
 doc/api/doxy-api.conf.in                   |   1 +
 drivers/event/dlb2/dlb2_priv.h             |   4 +-
 drivers/event/dlb2/pf/base/dlb2_resource.c |  51 ++--
 lib/arg_parser/arg_parser.c                | 170 ++++++++++++
 lib/arg_parser/meson.build                 |   7 +
 lib/arg_parser/rte_arg_parser.h            |  98 +++++++
 lib/arg_parser/version.map                 |  11 +
 lib/eal/common/eal_common_options.c        | 291 +++++----------------
 lib/eal/meson.build                        |   2 +-
 lib/meson.build                            |   2 +
 13 files changed, 378 insertions(+), 267 deletions(-)
 create mode 100644 lib/arg_parser/arg_parser.c
 create mode 100644 lib/arg_parser/meson.build
 create mode 100644 lib/arg_parser/rte_arg_parser.h
 create mode 100644 lib/arg_parser/version.map