From patchwork Tue Jan 23 11:40:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 578 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F752439A7; Tue, 23 Jan 2024 12:41:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D0B7410E3; Tue, 23 Jan 2024 12:41:15 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 26FB2402B0 for ; Tue, 23 Jan 2024 12:41:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706010074; x=1737546074; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=h+VCozXtdhAZD2nrjxIp0YmY3N09fqTeTuaBV1gdOWM=; b=cKIWcPrY69pqIb9uDlrPlDjfj4fswRodrsvqcFztM+DCe4mMl60PYT3+ kpGHY5jDUHxi8Qs1aG8sVo6n7DmbaKtie80Nj/yolUtxQacEj7P0q/k4b diAK2YAADYw4319ImQPlLJc7cUUA594THBEHhhD7UsP1LVHkBaEs7l0gQ qPbpHKYbWYlhp5eM/h13GQvKADMOKeADAoNg0ZZOwHgVXxhVkrL3Bub8n wjTMMWRObAD1nhlzRJiyFD6HrOUFYsM4MXQ11LraibcQUJpFfRMKKPuDC Hfz/86PxFZgRxu+FDgQXsI2yg+NOujfdVMtqR41UQuOj82Mh9NfNh+HXu A==; X-IronPort-AV: E=McAfee;i="6600,9927,10961"; a="22965748" X-IronPort-AV: E=Sophos;i="6.05,214,1701158400"; d="scan'208";a="22965748" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 03:41:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,214,1701158400"; d="scan'208";a="27722305" Received: from silpixa00400957.ir.intel.com (HELO silpixa00401385.ir.intel.com) ([10.237.214.26]) by orviesa002.jf.intel.com with ESMTP; 23 Jan 2024 03:41:13 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Subject: [PATCH 0/6] remove incorrect code for loading 16B descriptors Date: Tue, 23 Jan 2024 11:40:47 +0000 Message-Id: <20240123114053.172189-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Inside the AVX2 code paths, there was special case code for loading two 16-byte descriptors simultaneously, if that build-time feature was enabled. As well as not being enabled by default, these code blocks also were incorrect as there is no guarantee of the two descriptors being loaded either atomically or in a defined order. If they were loaded in an unexpected order the driver logic would break. Therefore we remove these blocks, and do come cleanup of the following code to remove indentation. NOTE: I've split out the removal and subsequent cleanup into separate patches for ease of review. These can be merged into a single patch on merge, if so desired. Bruce Richardson (6): net/i40e: remove incorrect 16B descriptor read block net/i40e: reduce code indentation net/iavf: remove incorrect 16B descriptor read block net/ice: remove incorrect 16B descriptor read block net/ice: reduce code indent net/iavf: reduce code indent drivers/net/i40e/i40e_rxtx_vec_avx2.c | 64 ++++++++------------- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 80 ++++++++------------------- drivers/net/ice/ice_rxtx_vec_avx2.c | 80 ++++++++------------------- 3 files changed, 72 insertions(+), 152 deletions(-) --- 2.40.1