Message ID | 20240419195310.21432-1-andrew.boyer@amd.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C327A43EB5; Fri, 19 Apr 2024 21:53:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EACF40698; Fri, 19 Apr 2024 21:53:33 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2068.outbound.protection.outlook.com [40.107.244.68]) by mails.dpdk.org (Postfix) with ESMTP id B75CD40696 for <dev@dpdk.org>; Fri, 19 Apr 2024 21:53:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPrKJaAV2R8w/RofyB/XjYa8fLQB0vUYkwdDTWaub0myPaM8bXoTGdyIikOGRrlTKkQwtMhY4X6e4ejarYxG7OqaF8BrXXM4qEyLaoIB32GTfLZrzx0vdGIt2AGptpVxzNSLwbZRN3somXPJyr2ufBj6xwQn3OJVZeYWJ76GPvfW+hnGJAUs4OaAhfWCMchpnpSqNAjtJGx79uPhqQk4tQYnOl84Vt1qnm9tgWLsfPZ36oA5KzWFCG2xwLw+k2QTfdDzBK/fyNTEROWoLSBibZXjVMomjRAZXVHvlj0SeuzGx8+HYf9j/s6WWjXeIQpj5jy7Uj80j62FCSkp5PBz4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SGbULiGrQJX2cSbY+jBV9AlArqz6ieTktDAsYrdMBYs=; b=RBLTX+FJJCWvPJkiw4Q1H+KvAx/9Q6PBcfUoFBtOL8HaXKJh4hNIeeJERgZ8jkDYz7oYcoXYOOt8cPrxTkMt+K7Cd+3wh0gCzf49YvNxLZh4zVSpN1imWx1dpbT6YDxEIGgFhyNALCPRWAbiMDbutEr0TyRtLtn5eXIp2+uJSgZUsLw9RCW7+xoLF8MxJP+RFRUJDrVXNBLpig84WbDmjm/1i5muWdOZDve98MFgjj5Zad5/WIB0r6U6jiiSCPChBUHK2dZZmGWjHX5iHNPTmD5Dd1TNRgMNQIxHRD77TRcLZxztivuNszIUliyQb04Ho17NXnPdpU1GoGdxhkdrUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SGbULiGrQJX2cSbY+jBV9AlArqz6ieTktDAsYrdMBYs=; b=DFVyNyb3vpIGkQT2i0O/0CvkJXV3q/X8LIsiVLwzanc54h2wQTekolDRdWNEu7G6h9owDJVwa2oYTch1rvMjFtDNByzM23qvp5ULzcfwXWQsywz6S1kNupiad84eJ++VMKQYNjc+2buexIRZa201Z1prjVW2qgcZCfjB6t7rBUI= Received: from PA7P264CA0456.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:398::26) by CYXPR12MB9317.namprd12.prod.outlook.com (2603:10b6:930:e2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.43; Fri, 19 Apr 2024 19:53:29 +0000 Received: from SA2PEPF00001507.namprd04.prod.outlook.com (2603:10a6:102:398:cafe::ce) by PA7P264CA0456.outlook.office365.com (2603:10a6:102:398::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.34 via Frontend Transport; Fri, 19 Apr 2024 19:53:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001507.mail.protection.outlook.com (10.167.242.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 19 Apr 2024 19:53:28 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Apr 2024 14:53:27 -0500 From: Andrew Boyer <andrew.boyer@amd.com> To: <dev@dpdk.org> CC: Akhil Goyal <gakhil@marvell.com>, Andrew Boyer <andrew.boyer@amd.com> Subject: [PATCH 0/6] crypto/ionic: introduce AMD Pensando ionic crypto driver Date: Fri, 19 Apr 2024 12:53:04 -0700 Message-ID: <20240419195310.21432-1-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001507:EE_|CYXPR12MB9317:EE_ X-MS-Office365-Filtering-Correlation-Id: afe1c5f7-0b83-4afa-611b-08dc60aa61ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: illw1t5DntLkZDYMEnOE902u4Ak1Aab9CNHtzoxgZGg/BOnWHDxp7m9NonoDLfJqKlQmgY0pnh/HnVfv9HJggq1lxnwRW6aYT1lWLjGrjrGw7ikREuhw39r8uDA0Orr19f7TlcWc9/0yL3Eo+8fosMB1IPF3u9OBDPKU7ObB4pw3bDdjPJctjhPOj1YATsZ1BM3i6fLW7HB+PXlozZWj+W13XDMI/7xZ1Wayzs/jhgZhsg9EkcyYBL6uQhXrtP3kcvWnCssMX49r5rNSFKjkYFlqCjSy//tvVRzRtSARNKPU+TiZ3HM5DykGa/vG6PVokniSIWxTVmjGnZufkeE6ZxyiQSqg/aRLQ9DAl2gtxZsgh+DmchK2mBmnTjIQl81CMi3YlV1fei22tLyh7P6z3LZ26Mk6SHBZSP9Kzlr2zcaw+++wLRkteX0aWCrf6pKYPbdlwPeEnWBiAB+HwKqCw/MzfqVeOuT0NTgQr/cjAd7jjge1ECNlLFz/ftcCHVPRibBiFsGcW9l6uC9wU8s06Baj2afD23aubrxJo7amctli5h8dbqkuJz/JaGdol84pY39AclG5mnWkoQTeNZmd91AL6yofhfcMCcKybjtzWc5KArbcC6qkD84IuP220mIe56J5lKwkuvHjwFgz26hwSmrQC5yi7d4nj4NBGJbY9b9G0LZNyKhyEXAn2t+expYynR/DnWTtmN8eKOdWSPkIPTBYelGIy1KmeLDz9NU5ci1Sh0iPzJo/aOoF5bCjH/Ee X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(1800799015)(82310400014)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 19:53:28.2574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afe1c5f7-0b83-4afa-611b-08dc60aa61ec X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001507.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9317 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
crypto/ionic: introduce AMD Pensando ionic crypto driver
|
|
Message
Andrew Boyer
April 19, 2024, 7:53 p.m. UTC
This patchset introduces a new crypto PMD for AMD Pensando hardware accelerators. It allows applications running directly on the AMD Pensando DSC to offload cryptographic operations to hardware cryptographic blocks. Andrew Boyer (6): crypto/ionic: introduce AMD Pensando ionic crypto driver crypto/ionic: add device and admin command handlers common/ionic: add crypto vdev support crypto/ionic: add device object and vdev support crypto/ionic: add datapath and capabilities support crypto/ionic: add documentation and connect to build MAINTAINERS | 7 + doc/guides/cryptodevs/features/ionic.ini | 40 + doc/guides/cryptodevs/index.rst | 1 + doc/guides/cryptodevs/ionic.rst | 39 + drivers/common/ionic/ionic_common.h | 2 + drivers/common/ionic/ionic_common_uio.c | 48 +- drivers/common/ionic/version.map | 1 + drivers/crypto/ionic/ionic_crypto.h | 361 ++++++++ drivers/crypto/ionic/ionic_crypto_caps.c | 55 ++ drivers/crypto/ionic/ionic_crypto_cmds.c | 651 ++++++++++++++ drivers/crypto/ionic/ionic_crypto_if.h | 1021 ++++++++++++++++++++++ drivers/crypto/ionic/ionic_crypto_main.c | 993 +++++++++++++++++++++ drivers/crypto/ionic/ionic_crypto_ops.c | 606 +++++++++++++ drivers/crypto/ionic/ionic_crypto_vdev.c | 128 +++ drivers/crypto/ionic/meson.build | 16 + drivers/crypto/meson.build | 1 + 16 files changed, 3969 insertions(+), 1 deletion(-) create mode 100644 doc/guides/cryptodevs/features/ionic.ini create mode 100644 doc/guides/cryptodevs/ionic.rst create mode 100644 drivers/crypto/ionic/ionic_crypto.h create mode 100644 drivers/crypto/ionic/ionic_crypto_caps.c create mode 100644 drivers/crypto/ionic/ionic_crypto_cmds.c create mode 100644 drivers/crypto/ionic/ionic_crypto_if.h create mode 100644 drivers/crypto/ionic/ionic_crypto_main.c create mode 100644 drivers/crypto/ionic/ionic_crypto_ops.c create mode 100644 drivers/crypto/ionic/ionic_crypto_vdev.c create mode 100644 drivers/crypto/ionic/meson.build
Comments
Hi Andrew, > This patchset introduces a new crypto PMD for AMD Pensando hardware > accelerators. It allows applications running directly on the AMD Pensando > DSC to offload cryptographic operations to hardware cryptographic blocks. > > Andrew Boyer (6): > crypto/ionic: introduce AMD Pensando ionic crypto driver > crypto/ionic: add device and admin command handlers > common/ionic: add crypto vdev support > crypto/ionic: add device object and vdev support > crypto/ionic: add datapath and capabilities support > crypto/ionic: add documentation and connect to build I did not review the patches completely yet, but the patches are not organized properly. Your 1st patch says introduce the new driver, But it is just adding a hardware specific header file. Your 1st patch should add the base framework of the PMD Which is compiled in the DPDK build system. You can also add some part of documentation for introducing the new driver. MAINTAINERS file should also be updated for every new directory where it is introduced. Once you have the base probe and remove added in your first patch, You can add each of the driver ops in subsequent patches. You can break queue pair related stuff in a single patch and session related stuff in another one. Capabilities can be a separate patch. enqueue/dequeue can also be separate patches as well if they are big. Add documentation changes in each of the patches wherever needed. You may refer https://patches.dpdk.org/project/dpdk/list/?series=17483&state=%2A&archive=both > > MAINTAINERS | 7 + > doc/guides/cryptodevs/features/ionic.ini | 40 + > doc/guides/cryptodevs/index.rst | 1 + > doc/guides/cryptodevs/ionic.rst | 39 + > drivers/common/ionic/ionic_common.h | 2 + > drivers/common/ionic/ionic_common_uio.c | 48 +- > drivers/common/ionic/version.map | 1 + > drivers/crypto/ionic/ionic_crypto.h | 361 ++++++++ > drivers/crypto/ionic/ionic_crypto_caps.c | 55 ++ > drivers/crypto/ionic/ionic_crypto_cmds.c | 651 ++++++++++++++ > drivers/crypto/ionic/ionic_crypto_if.h | 1021 ++++++++++++++++++++++ > drivers/crypto/ionic/ionic_crypto_main.c | 993 +++++++++++++++++++++ > drivers/crypto/ionic/ionic_crypto_ops.c | 606 +++++++++++++ > drivers/crypto/ionic/ionic_crypto_vdev.c | 128 +++ > drivers/crypto/ionic/meson.build | 16 + > drivers/crypto/meson.build | 1 + > 16 files changed, 3969 insertions(+), 1 deletion(-) > create mode 100644 doc/guides/cryptodevs/features/ionic.ini > create mode 100644 doc/guides/cryptodevs/ionic.rst > create mode 100644 drivers/crypto/ionic/ionic_crypto.h > create mode 100644 drivers/crypto/ionic/ionic_crypto_caps.c > create mode 100644 drivers/crypto/ionic/ionic_crypto_cmds.c > create mode 100644 drivers/crypto/ionic/ionic_crypto_if.h > create mode 100644 drivers/crypto/ionic/ionic_crypto_main.c > create mode 100644 drivers/crypto/ionic/ionic_crypto_ops.c > create mode 100644 drivers/crypto/ionic/ionic_crypto_vdev.c > create mode 100644 drivers/crypto/ionic/meson.build > > -- > 2.17.1