From patchwork Tue Apr 30 18:45:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Pratte X-Patchwork-Id: 898 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D1CD43F32; Tue, 30 Apr 2024 20:48:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84034402C7; Tue, 30 Apr 2024 20:48:00 +0200 (CEST) Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by mails.dpdk.org (Postfix) with ESMTP id 0857F402C0 for ; Tue, 30 Apr 2024 20:47:59 +0200 (CEST) Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6a0d274e631so3389826d6.1 for ; Tue, 30 Apr 2024 11:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1714502878; x=1715107678; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PEosgovwpCzEWBzbGzfaahlDTKIYXedTUTkpimZty1g=; b=UOniwwCVJq42BI6wPtGU4I+3K3iHCv4rjpQqeDL3xXSgfSs6wrqw9f7yQspNJqfDj3 i2LyDVQYFrUMGuT2APMtLnbDE7NUPOIuAliP8ftoaful02i0mFDxlvRgSndmZL/GDqNl EEAhVT0Tr/EwiOliAbwRmZz3KTDqBLJXpDZ/Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714502878; x=1715107678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PEosgovwpCzEWBzbGzfaahlDTKIYXedTUTkpimZty1g=; b=hJsV8kt6wW2uPpxuXMfdNbLD1N3EUQHpDxol02dCcdlhHdhFYBk4hEHlMDq4+wofUw nvWZzXvpRjFbsqNFMM+H79fnwCHmWk4BHxtvLoi4qEassoyjVkol8F7JVCvGoG9m/y/n PN+YQ7gmt6rg0KUndiqVhR6Kf2fBNNTBcgZHlJUc6eHbeETvL3EWIjh+TUBIzmeJ5faf dKLJ+b7ksjdxe2rPn/FsGoRGpjVW0uRKTECMwL244OYd1MHJdIWA0y2uWGFdSBB5iICx oHqkrS2nRpllLYeL44UndcaGhywis3YEq8ETouiFnTBMJ7IwsNDB3aAjNKSJRs7jKMpA cwOA== X-Gm-Message-State: AOJu0YzmhwjtDpCTKWBuKkr7mNvwEZCtHX9K81CUc+cDNKJx6bMsYjKC 4g48PXhMxzR3F/zyFq+ZjH/t5Aefpdg/8zRITkIba/gP8IXskDwb2iPSevOAyVs= X-Google-Smtp-Source: AGHT+IHEeE3In8OHNMYdhS+owNHGanYQVXnmq1M0qI0WMKhWvaB+luWLzzMFhMAoJYDgsgPH/lj0bQ== X-Received: by 2002:a05:622a:1910:b0:439:ecc6:cdff with SMTP id w16-20020a05622a191000b00439ecc6cdffmr173405qtc.1.1714502878432; Tue, 30 Apr 2024 11:47:58 -0700 (PDT) Received: from d121012.iol.unh.edu ([2606:4100:3880:1271:e2f8:4ec3:8bf3:864c]) by smtp.gmail.com with ESMTPSA id dj14-20020a05622a4e8e00b0043ae234c0f2sm2182479qtb.36.2024.04.30.11.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 11:47:58 -0700 (PDT) From: Nicholas Pratte To: "jspewock@iol.unh.edumb@smartsharesystems.combruce.richardson"@intel.com, yoan.picchi@foss.arm.com, juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, wathsala.vithanage@arm.com, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu Cc: dev@dpdk.org, Nicholas Pratte Subject: [PATCH v5 0/2] Methodology change for hugepage configuration Date: Tue, 30 Apr 2024 14:45:34 -0400 Message-ID: <20240430184533.29247-4-npratte@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240430184533.29247-2-npratte@iol.unh.edu> References: <20240430184533.29247-2-npratte@iol.unh.edu> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In order to prevent accidental misconfiguration of hugepages at runtime, the following changes are made to only allow for configuration of 2MB hugepages within the DTS config.yaml. In the previous implementation, a default hugepage size was selected via the size listed in /proc/meminfo. The problem with this implementation is that, assuming the end-user has made prior modifications to the system, /proc/meminfo may default to hugepage sizes that are not recommended to be configured at runtime (i.e. 1GB hugepages). This can lead to two problems: overallocation of hugepages (which may crash the remote host) configuration of hugepages sizes that are not recommended during runtime. In this new implementation, we stipulate that any runtime hugepage configuration size that is not 2MB is considered an outlier. If the end-user would like to configure either 1GB hugepages or any unique hugepage size outside of 2MB, then they should make these configurations either at startup (in the case of 1GB hugepages) or runtime outside of DTS configuration (if a user would like hugepages that are not 2MB). In either case, the expectation is that, if wish to use hugepage sizes that are not 2MB, you will make these changes outside and prior to the initialization of DTS. The end-user has two options: remove the option for hugepage configuration in the conf.yaml, or keep the option and specify the amount of 2MB hugepages desired. In the case of the former, then we assume that hugepages are already configured prior to DTS initialization. In the latter case, the user must define the amount of 2MB hugepages to be configured at runtime. If the amount of 2MB hugepages requested exceeds the amount of 2MB hugepages already configured on the system, then the system will remount hugepages to cover the difference. If the amount of hugepages requested is either greater than or equal to the amount already configured on the system, then nothing is done. Nicholas Pratte (2): dts: Change hugepage runtime config to 2MB Exclusively dts: Change hugepage 'amount' to a different term doc/guides/tools/dts.rst | 6 ++++- dts/conf.yaml | 8 +++--- dts/framework/config/__init__.py | 8 +++--- dts/framework/config/conf_yaml_schema.json | 12 ++++----- dts/framework/config/types.py | 4 +-- dts/framework/testbed_model/linux_session.py | 28 +++++++++++--------- dts/framework/testbed_model/node.py | 4 ++- dts/framework/testbed_model/os_session.py | 7 ++++- 8 files changed, 45 insertions(+), 32 deletions(-)