From patchwork Wed May 1 16:16:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Spewock X-Patchwork-Id: 901 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A689A43F5D; Wed, 1 May 2024 18:17:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 816C0402A8; Wed, 1 May 2024 18:17:21 +0200 (CEST) Received: from mail-io1-f98.google.com (mail-io1-f98.google.com [209.85.166.98]) by mails.dpdk.org (Postfix) with ESMTP id B1309402A7 for ; Wed, 1 May 2024 18:17:20 +0200 (CEST) Received: by mail-io1-f98.google.com with SMTP id ca18e2360f4ac-7dec7c2a03eso150537639f.0 for ; Wed, 01 May 2024 09:17:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1714580240; x=1715185040; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C//OstbBdm+u3G0E6iEstWKuYiPFVrO3Lv2R+64n0dA=; b=f4Zkl0tqmyj0WO+GZoajptUJW6AsvTv8sZcAUqWdm9Rc/0+6GCUcu6CiCuiDBC4Ee0 35GwFAmbYewZrZUGQ9AsmynAQuL1417zsRc6t++P27vmLVkk6Hu1MlRpRFCa+YMPIGiv KqH5Sjw1wYEPrI+0X4abBV/ESUU2ESRyWnhjA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714580240; x=1715185040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C//OstbBdm+u3G0E6iEstWKuYiPFVrO3Lv2R+64n0dA=; b=kG8/XLMz+vw+DyeAS3USsvT6+URnaoyiLCOEWXfoYud0ePfbw++7ZpF5uuny0hdMxi dW7/5DG+TkUvHxFX5CKCVYgPX+Qo6EdwDhP6TFKLPMdrjMtvWlNeaAKkxKxV7gS+GXGh wNx2RwEbWBHRdNPxzBA4qp84af+zWe+kQQ5cfoX7hckT0RVJmDT7DLqksdrI5dJPG6do ByMa+UfpDtXv+XLKfwuGnopAByiNyzJydTzzn6LtdnJvv9x9HVgYDUA+14Q8XMhAMfeY RfUVivzbBXW7g7m3qowbxYyPsa9Dn4N5cn/7uJgFhme/oqPk0FryGOf+I1ujTr/yVwts xx2g== X-Gm-Message-State: AOJu0Yymr86T+diP6AmM9e1Jv2Y2Z1w20dI602pgIhBtggw+fw2QsgQ2 1LpbCItRH9QkVC23MXGJVMsznAABQFCV3C7a1yR8EZbrljJWP33SQwdYrNKFfH17vqZWeHfSDQb z2pTYQuqrz6o9AINe+IUvBu1E826+phhw6dLQZ37nQcCdGUN+ X-Google-Smtp-Source: AGHT+IF4tzLM+rrKIr/FpUCFz4hRq7GYupHwxfajnybu+mGnRurBLsmipLsu/XJJ2HDWW5gPeBq3pXK0AQiU X-Received: by 2002:a05:6e02:17c9:b0:36c:3249:bfe8 with SMTP id z9-20020a056e0217c900b0036c3249bfe8mr3617160ilu.32.1714580240012; Wed, 01 May 2024 09:17:20 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id u14-20020a056e02170e00b0036c60e5c549sm122544ill.52.2024.05.01.09.17.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 May 2024 09:17:19 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1271:90f9:1b64:f6e6:867f]) by postal.iol.unh.edu (Postfix) with ESMTP id 33B106052514; Wed, 1 May 2024 12:17:19 -0400 (EDT) From: jspewock@iol.unh.edu To: Luca.Vizzarro@arm.com, wathsala.vithanage@arm.com, yoan.picchi@foss.arm.com, juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, probb@iol.unh.edu, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com Cc: dev@dpdk.org, Jeremy Spewock Subject: [PATCH v2 0/3] Improve interactive shell output gathering and logging Date: Wed, 1 May 2024 12:16:20 -0400 Message-ID: <20240501161623.26672-1-jspewock@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240312172558.11844-1-jspewock@iol.unh.edu> References: <20240312172558.11844-1-jspewock@iol.unh.edu> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jeremy Spewock This version addresses comments from the last and adds an additional improvement to the logging output that comes from interactive shells. The new way of handling logging allows for not only specification of the host that the command is being sent to like before, but also the type of shell that you are addressing. This is beneficial for 2 reasons: 1. Less ambiguity on if a command is being sent to the host directly or into an interactive shell 2. Ability to name shells so that there is distinction in the logs between two different interactive shells of the same type that serve a different purpose (e.g. a python shell and a python shell that is serving and XML-RPC server for scapy interactions) Jeremy Spewock (3): dts: Improve output gathering in interactive shells dts: Add missing docstring from XML-RPC server dts: Improve logging for interactive shells dts/framework/exception.py | 66 ++++++++++++------- .../remote_session/interactive_shell.py | 54 ++++++++++----- dts/framework/testbed_model/node.py | 7 ++ dts/framework/testbed_model/os_session.py | 6 +- dts/framework/testbed_model/sut_node.py | 7 +- .../testbed_model/traffic_generator/scapy.py | 48 +++++++++++++- 6 files changed, 145 insertions(+), 43 deletions(-)