mbox series

[v4,0/5] vhost: FD manager improvements

Message ID 20240611133957.72032-1-maxime.coquelin@redhat.com (mailing list archive)
Headers
Series vhost: FD manager improvements |

Message

Maxime Coquelin June 11, 2024, 1:39 p.m. UTC
This series aims at improving the Vhost FD manager.
The fdset internals is hidden from its callers, the
notification/synchronization is made systematic for
every FD add/del operations and finally the code is
reworked to make use of epoll insteal of poll which
reduces the complexity (less locks involved,
synchrnoization no more necessary).

The series has been tested with both Vhost-user/Virtio-user
and with VDUSE.

Changes in v4:
==============
- Remove useless parameter check (Stephen)
- Error handling in dset_add (Chenbo)
- Destroy support fixup in even dispatcher (Chenbo)
- Refactor fdentry insertion/removal
- Rebased on top of next-virtio/staging

David Marchand (1):
  vhost: manage FD with epoll

Maxime Coquelin (4):
  vhost: rename polling mutex
  vhost: make use of FD manager init function
  vhost: hide synchronization within FD manager
  vhost: improve fdset initialization

 lib/vhost/fd_man.c | 456 ++++++++++++++++++++++-----------------------
 lib/vhost/fd_man.h |  48 +----
 lib/vhost/socket.c |  38 +---
 lib/vhost/vduse.c  |  52 ++----
 4 files changed, 252 insertions(+), 342 deletions(-)
  

Comments

David Marchand June 11, 2024, 2:52 p.m. UTC | #1
On Tue, Jun 11, 2024 at 3:40 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
>
> This series aims at improving the Vhost FD manager.
> The fdset internals is hidden from its callers, the
> notification/synchronization is made systematic for
> every FD add/del operations and finally the code is
> reworked to make use of epoll insteal of poll which
> reduces the complexity (less locks involved,
> synchrnoization no more necessary).
>
> The series has been tested with both Vhost-user/Virtio-user
> and with VDUSE.
>
> Changes in v4:
> ==============
> - Remove useless parameter check (Stephen)
> - Error handling in dset_add (Chenbo)
> - Destroy support fixup in even dispatcher (Chenbo)
> - Refactor fdentry insertion/removal
> - Rebased on top of next-virtio/staging

For the series,
Acked-by: David Marchand <david.marchand@redhat.com>
  
Maxime Coquelin June 12, 2024, 8:41 a.m. UTC | #2
On 6/11/24 15:39, Maxime Coquelin wrote:
> 
> This series aims at improving the Vhost FD manager.
> The fdset internals is hidden from its callers, the
> notification/synchronization is made systematic for
> every FD add/del operations and finally the code is
> reworked to make use of epoll insteal of poll which
> reduces the complexity (less locks involved,
> synchrnoization no more necessary).
> 
> The series has been tested with both Vhost-user/Virtio-user
> and with VDUSE.
> 
> Changes in v4:
> ==============
> - Remove useless parameter check (Stephen)
> - Error handling in dset_add (Chenbo)
> - Destroy support fixup in even dispatcher (Chenbo)
> - Refactor fdentry insertion/removal
> - Rebased on top of next-virtio/staging
> 
> David Marchand (1):
>    vhost: manage FD with epoll
> 
> Maxime Coquelin (4):
>    vhost: rename polling mutex
>    vhost: make use of FD manager init function
>    vhost: hide synchronization within FD manager
>    vhost: improve fdset initialization
> 
>   lib/vhost/fd_man.c | 456 ++++++++++++++++++++++-----------------------
>   lib/vhost/fd_man.h |  48 +----
>   lib/vhost/socket.c |  38 +---
>   lib/vhost/vduse.c  |  52 ++----
>   4 files changed, 252 insertions(+), 342 deletions(-)
> 

Applied to next-virtio/for-next-net.

Thanks,
Maxime