From patchwork Sat Sep 7 14:54:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 1325 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DA2D4592F; Sat, 7 Sep 2024 16:54:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A3E24026F; Sat, 7 Sep 2024 16:54:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6A60940269 for ; Sat, 7 Sep 2024 16:54:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725720882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=COjliTN80z/hRzrDO0HGFd/OjSoRR1rjfii9mTmUEn4=; b=ExQc9+IJ84OsGcG8uZ7nyPIhxe+8JNICylCshy0FaZ5FkMgxUdcJ1agKwHbDkn8bGLFRD7 jCjRrLMcooFxzM7vDx940O/SrioSaFeqwHNn/jQ8UGog/tZozmk6oUUiWXQ1k+1MfTRig3 AajDkmUxVHDf2wzz9wFRChDenxrq6vg= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-ULwZSzRVOQiqrt3S-LX2iA-1; Sat, 07 Sep 2024 10:54:41 -0400 X-MC-Unique: ULwZSzRVOQiqrt3S-LX2iA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 62AC71956096 for ; Sat, 7 Sep 2024 14:54:40 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.226.65]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 32DFC1956086 for ; Sat, 7 Sep 2024 14:54:38 +0000 (UTC) From: David Marchand To: dev@dpdk.org Subject: [PATCH 00/11] Use RTE_LOG_LINE in drivers Date: Sat, 7 Sep 2024 16:54:20 +0200 Message-ID: <20240907145433.1479091-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a continuation of the cleanup effort in logging macros. As a reminder of what this series is about, RTE_LOG_LINE() has been introduced to check that the format string does not contain a trailing \n. The goal was to prevent from: - introducing multilines log messages (ugly and unhelpful for lambda users), - introducing double \n in logs, - introducing missing \n in logs, I have built/maintained this series for fixing drivers/ since the beginning of the year and I hope we can merge this series early in 24.11. Some drivers are not converted because of multiple inconsistencies (like event/dlb2 where the _INFO/_ERR macros add an internal \n but the _DBG macros does not). Those may be fixed later. As for the changes on lib/, new macros have been introduced so that backports trigger a build error and force the backport to adjust the patches containing logs accordingly. Most of the changes have been done with some scripting, but it is likely there are some errors and I hope driver maintainers will review in depth. A check is added for drivers/ in the hope that new drivers don't introduce more mess. Yet, sometimes it is not possible to fix macros (a good example is base/ drivers code...), so the check skips *osdep.h headers where calls to RTE_LOG() may be accepted.