From patchwork Tue Jun 26 16:56:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ga=C3=ABtan_Rivet?= X-Patchwork-Id: 41586 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96C911BDE0; Tue, 26 Jun 2018 18:56:48 +0200 (CEST) Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 5BCB91BDDE for ; Tue, 26 Jun 2018 18:56:47 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id c13-v6so8019867wrq.2 for ; Tue, 26 Jun 2018 09:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n81ySnrENv3bBVJgCIv8h3DnTXL+P+NJKQQ+oTJclaU=; b=ZdWgXXPOzmALqvaTMofJRoQXZHCRPdr3IQCPJrwpuhNfFwPsIeCw44jpe//dt5qJlY NVpf1QHnErMmwiquowPamFED6MwgqporlfYAyugsyBevOFwQbpoIaQJPVDTC5ZmKxxEo 4mg5OZeNrnwx7C53uH8bmfljjzXauRmCP09GJ+H6cwMNGA8rmGLTOI6tZCGo2aZHiRrw JQBPNJSvqBmROM/4007mEfCOepum5s+ro1bPjc0P1akDueiuFr8Jsa/G1S+dhVn0UcpA Sked+vH4auqVgsYnet3tks+Sk1TDCQJ7ORJODW/oBsdI7oh1mplpl7xLmkXyrvCQ4bMb lWTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=n81ySnrENv3bBVJgCIv8h3DnTXL+P+NJKQQ+oTJclaU=; b=gKb+LonTFh6KaLPMhw2gEXRoNGBvRZ5qxbsQZoXhLIf0Tx1Zj5gCSq+rsWFs/0zRpA 6URMijFY9rf5DS0zKh8ualc8YfWOrSN99DYAR4xwDNEvY0xDrq8IT3niSkkmFJ+Rn1m4 dZ09QcaYhK2D/i5UDsDUjAwEvDcJs/G91rE4ssskkk7Gu+kvH+ndkbrgvCES/YMix7g1 99y5B7krJeQT2/rHA1Afil1+P6dlfTgtWmgtrgp++aN6BIs9xHiEJj8RSM972eXS/nRf qBQNMUlOb0LCTwx4gWOVre7U0Zfcskxuj6gMkVPIsCR2h5UgUux3eWrH3rv0lXsITtlg wlwQ== X-Gm-Message-State: APt69E0zWC95rU4MmGYZe/l35jAsCV/DEgTgjc0rdU+dcr2g3OmccTcT 1exigA/eYVcKMb0AVuhIPlhyWcC1 X-Google-Smtp-Source: AAOMgpegI+iQyHPo9qWLkn+LcS03ecDAxKc9ut0WhJ/Fk09BqA5BtIKdU46AmdHANg3QQaJ4gyEGGQ== X-Received: by 2002:adf:bd89:: with SMTP id l9-v6mr2228519wrh.266.1530032206490; Tue, 26 Jun 2018 09:56:46 -0700 (PDT) Received: from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p5-v6sm2680880wre.83.2018.06.26.09.56.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Jun 2018 09:56:45 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet , Neil Horman , Keith Wiles , Matan Azrad , Shreyansh Jain Date: Tue, 26 Jun 2018 18:56:03 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v8 00/21] Device querying X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patchset introduces a new EAL API for querying devices, filtered by arbitrary properties. The following elements are introduced to this end: * A new object, "rte_class", is used to describe the device class abstraction layer (eth, crypto, ...). * Both rte_bus and rte_class now offer a way to list their devices and filter the result using locally defined properties. * The rte_dev API now has an rte_dev_iterator, which is the way for the user to define the device filter and iterate upon the resulting set. As an example, the "eth" device class is implemented. Additionally, the device filters for + rte_bus_pci + rte_bus_vdev + rte_class_eth are implemented and can be used with some properties each, to show how to extend those. Some example of filters: "bus=pci/class=eth" "bus=pci" "class=eth" "class=eth,name=net_ring0" "bus=pci,id=00:00.0" "bus=vdev,driver=net_ring" --- v2: * Reworked the dev_iterate callback to simplify its implementation. Now dev_iterate implementation do not need to learn about the intricacies of the rte_dev_iterator. The rte_dev_iterator is managed purely by the rte_dev_iterator_next function. Buses and classes then do not have to care about settings things right. Additionally, dev_iterate implementations do not have to sanitize their dev string anymore, they are prepared by the rte_dev layer prior, which also reduces the number of dynamic allocations. v3: * Introduced central constructor priority list. * Removed lightweight kvarg parsing utility, using librte_kvargs instead. * Reversed dependencies of librte_kvargs and librte_eal. * Fixed a few bugs. * @Bruce: I have noted the request for meson support. I will install it and attempt it once the bulk of the work is done. v4: * Fixed a few bugs, added relevant acks, fixed some typos. * Made each matching functions actually check for a proper list of accepted properties. * rte_kvargs now includes rte_eal directly and keeps rte_log. * added generic string comparison function to rte_kvargs, as some kind of comparison should probably be shared by many layers. v5: * Rebased on master * Use strcspn instead of custom function. * Introduce private generic rte_eth_dev iterator. This could be generalized to other iterators (port_next, owner_id-aware, etc). * Attempted to support meson.build. Got lost in the implicit variables declared when inversing dependencies between kvargs and EAL. Removed anything related to meson. * Postponed genericization of work from device query to device declaration. Much bigger than anticipated, will let this part get in first and iterate over it. v6: * Rebased on master * Introduce RTE_PRIORITY_LAST, to explicitly set the lowest constructor priority. * Fix copyright notice for eth_privage.* files. v7: * Rebased on master * Fix rte_kvargs_strcmp return value. * Fix layer parsing error devstr "bus=pci/onemorelayer" now tells that the additional layer is not recognized. v8: * Rebased on master * Cleaned kvargs use: introduced a new parser function, that simplifies using the library for DPDK devargs. * Refactored devargs parsing in a single function within rte_devargs. This function is useful both for rte_dev parsing its iterator, and for rte_devargs parsing --dev parameters (not yet implemented). * A few small bugfixes. Gaetan Rivet (21): devargs: add non-variadic parsing function kvargs: build before EAL kvargs: introduce a more flexible parsing function eal: introduce dtor macros eal: introduce device class abstraction eal/class: register destructor devargs: add function to parse device layers eal/dev: add device iterator interface eal/class: add device iteration eal/bus: add device iteration eal/dev: implement device iteration initialization eal/dev: implement device iteration kvargs: add generic string matching callback bus/pci: implement device iteration and comparison bus/pci: add device matching field id bus/vdev: implement device iteration bus/vdev: add device matching field driver ethdev: add private generic device iterator ethdev: register ether layer as a class ethdev: add device matching field name app/testpmd: add show device command app/test-pmd/cmdline.c | 51 +++++++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 24 +++ drivers/bus/pci/Makefile | 3 +- drivers/bus/pci/pci_common.c | 3 +- drivers/bus/pci/pci_params.c | 78 ++++++++++ drivers/bus/pci/private.h | 25 +++ drivers/bus/vdev/Makefile | 3 +- drivers/bus/vdev/vdev.c | 10 +- drivers/bus/vdev/vdev_params.c | 62 ++++++++ drivers/bus/vdev/vdev_private.h | 26 ++++ drivers/net/failsafe/failsafe_args.c | 2 +- drivers/net/failsafe/failsafe_eal.c | 2 +- lib/Makefile | 5 +- lib/librte_eal/bsdapp/eal/Makefile | 2 + lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/eal_common_class.c | 62 ++++++++ lib/librte_eal/common/eal_common_dev.c | 227 +++++++++++++++++++++++++++- lib/librte_eal/common/eal_common_devargs.c | 186 +++++++++++++++++++++-- lib/librte_eal/common/eal_private.h | 27 ++++ lib/librte_eal/common/include/rte_bus.h | 1 + lib/librte_eal/common/include/rte_class.h | 127 ++++++++++++++++ lib/librte_eal/common/include/rte_common.h | 24 +++ lib/librte_eal/common/include/rte_dev.h | 97 ++++++++++++ lib/librte_eal/common/include/rte_devargs.h | 53 ++++++- lib/librte_eal/linuxapp/eal/Makefile | 2 + lib/librte_eal/rte_eal_version.map | 5 + lib/librte_ethdev/Makefile | 4 +- lib/librte_ethdev/eth_private.c | 31 ++++ lib/librte_ethdev/eth_private.h | 26 ++++ lib/librte_ethdev/rte_class_eth.c | 86 +++++++++++ lib/librte_ethdev/rte_ethdev.c | 2 +- lib/librte_kvargs/Makefile | 2 +- lib/librte_kvargs/rte_kvargs.c | 35 +++++ lib/librte_kvargs/rte_kvargs.h | 58 +++++++ lib/librte_kvargs/rte_kvargs_version.map | 8 + 35 files changed, 1328 insertions(+), 33 deletions(-) create mode 100644 drivers/bus/pci/pci_params.c create mode 100644 drivers/bus/vdev/vdev_params.c create mode 100644 drivers/bus/vdev/vdev_private.h create mode 100644 lib/librte_eal/common/eal_common_class.c create mode 100644 lib/librte_eal/common/include/rte_class.h create mode 100644 lib/librte_ethdev/eth_private.c create mode 100644 lib/librte_ethdev/eth_private.h create mode 100644 lib/librte_ethdev/rte_class_eth.c