From patchwork Wed Jul 24 15:34:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anatoly Burakov X-Patchwork-Id: 57037 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C1A241C219; Wed, 24 Jul 2019 17:34:49 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id DD68C1C218 for ; Wed, 24 Jul 2019 17:34:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 08:34:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,303,1559545200"; d="scan'208";a="163880260" Received: from silpixa00399498.ir.intel.com (HELO silpixa00399498.ger.corp.intel.com) ([10.237.223.125]) by orsmga008.jf.intel.com with ESMTP; 24 Jul 2019 08:34:45 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: john.mcnamara@intel.com, thomas@monjalon.net Date: Wed, 24 Jul 2019 16:34:42 +0100 Message-Id: X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 0/2] Small usability improvements for devbind X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Over the course of using devbind, i find myself frequently bumping up against two common errors (with the assumption being that i'm not the only person who hits these errors). First happens when i forget to specify the driver. The error message in this case looks something like the following: anatoly@xxxx:~$ sudo DPDK/usertools/dpdk-devbind.py -b 08:00.0 08:00.1 Error: bind failed for 0000:08:00.1 - Cannot open /sys/bus/pci/drivers/08:00.0/bind Error: unbind failed for 0000:08:00.1 - Cannot open /sys/bus/pci/drivers//unbind This is confusing to anyone who isn't intimately familiar with how driver binding through sysfs works. The first patch in this series changes the error message to instead look like the following: anatoly@xxxx:~$ sudo DPDK/usertools/dpdk-devbind.py -b 08:00.0 08:00.1 ERROR: Driver '08:00.0' does not look like a valid driver. Did you forget to specify the driver to bind devices to? We do that by assuming that no one in their right mind will name their PCI driver with something that looks like a PCI address, so we check if the driver string is actually a valid device string. If it is, we error out. The second error i often come across is forgetting to load the driver. This error looks something like this: anatoly@xxxx:~$ sudo DPDK/usertools/dpdk-devbind.py -b vfio-pci 08:00.1 Error: bind failed for 0000:08:00.1 - Cannot open /sys/bus/pci/drivers/vfio-pci/bind This too isn't very informative. The second patch in this patchset changes this error to look like this instead: anatoly@xxxx:~$ sudo DPDK/usertools/dpdk-devbind.py -b vfio-pci 08:00.1 ERROR: Driver 'vfio-pci' is not loaded. Nice and informative! Anatoly Burakov (2): usertools/devbind: add error on forgetting to specify driver usertools/devbind: check if module is loaded before binding usertools/dpdk-devbind.py | 81 ++++++++++++++++++++++++++------------- 1 file changed, 55 insertions(+), 26 deletions(-)