Message ID | 000001d1f793$b93a8b90$2bafa2b0$@linux.vnet.ibm.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E9E8066DA; Tue, 16 Aug 2016 09:56:26 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 8E5625AB8 for <dev@dpdk.org>; Tue, 16 Aug 2016 09:56:25 +0200 (CEST) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7G7rqiQ089676 for <dev@dpdk.org>; Tue, 16 Aug 2016 03:56:24 -0400 Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) by mx0a-001b2d01.pphosted.com with ESMTP id 24syq3e0dg-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for <dev@dpdk.org>; Tue, 16 Aug 2016 03:56:24 -0400 Received: from localhost by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for <dev@dpdk.org> from <chaozhu@linux.vnet.ibm.com>; Tue, 16 Aug 2016 17:56:22 +1000 Received: from d23dlp01.au.ibm.com (202.81.31.203) by e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 16 Aug 2016 17:56:18 +1000 X-IBM-Helo: d23dlp01.au.ibm.com X-IBM-MailFrom: chaozhu@linux.vnet.ibm.com X-IBM-RcptTo: dev@dpdk.org Received: from d23relay10.au.ibm.com (d23relay10.au.ibm.com [9.190.26.77]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 908732CE8046 for <dev@dpdk.org>; Tue, 16 Aug 2016 17:56:17 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7G7uH5D27918546 for <dev@dpdk.org>; Tue, 16 Aug 2016 17:56:17 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u7G7uHvm030895 for <dev@dpdk.org>; Tue, 16 Aug 2016 17:56:17 +1000 Received: from ADMINIB2M8Q79C ([9.186.50.151]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u7G7uFP3030758; Tue, 16 Aug 2016 17:56:15 +1000 From: "Chao Zhu" <chaozhu@linux.vnet.ibm.com> To: "'Gowrishankar Muthukrishnan'" <gowrishankar.m@linux.vnet.ibm.com>, <dev@dpdk.org> Cc: "'Bruce Richardson'" <bruce.richardson@intel.com>, "'Konstantin Ananyev'" <konstantin.ananyev@intel.com>, "'Thomas Monjalon'" <thomas.monjalon@6wind.com>, "'Cristian Dumitrescu'" <cristian.dumitrescu@intel.com>, "'Pradeep'" <pradeep@us.ibm.com> References: <1471003413-20685-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> <1471003413-20685-5-git-send-email-gowrishankar.m@linux.vnet.ibm.com> In-Reply-To: <1471003413-20685-5-git-send-email-gowrishankar.m@linux.vnet.ibm.com> Date: Tue, 16 Aug 2016 15:56:33 +0800 MIME-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQGS7ObTbX+sJ/7LI+Ld+f31BEKMCwEofjd2oMAH6kA= Content-Language: zh-cn X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081607-0048-0000-0000-000001ACF3B0 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081607-0049-0000-0000-000046576AEA Message-Id: <000001d1f793$b93a8b90$2bafa2b0$@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-16_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608160094 Subject: Re: [dpdk-dev] [PATCH v5 4/8] table: enable table library for ppc64le X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Chao Zhu
Aug. 16, 2016, 7:56 a.m. UTC
Gowrishankar, The unit test of table got failed. When I took a look at the code, it failed on this line in file lib/librte_table/rte_table_hash_key8.c , lib/librte_table/rte_table_hash_key16.c, lib/librte_table/rte_table_hash_key32.c: if ((check_params_create_lru(p) != 0) || ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) || ((sizeof(struct rte_bucket_4_8) % RTE_CACHE_LINE_SIZE) != 0)) { return NULL; } if ((check_params_create_lru(p) != 0) || ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) || ((sizeof(struct rte_bucket_4_16) % RTE_CACHE_LINE_SIZE) != 0)) { return NULL; } if ((check_params_create_lru(p) != 0) || ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) || ((sizeof(struct rte_bucket_4_32) % RTE_CACHE_LINE_SIZE) != 0)) { return NULL; } The size of rte_bucket_4_8/16/32 is not aligned to cache line size. This is normal, because POWER has different cache line size. The change of struct rte_bucket_4_8/16/32 may solve this problem. I didn't do further investigation. Can you help to double check this patch? -----Original Message----- From: Gowrishankar Muthukrishnan [mailto:gowrishankar.m@linux.vnet.ibm.com] Sent: 2016年8月12日 20:03 To: dev@dpdk.org Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>; Bruce Richardson <bruce.richardson@intel.com>; Konstantin Ananyev <konstantin.ananyev@intel.com>; Thomas Monjalon <thomas.monjalon@6wind.com>; Cristian Dumitrescu <cristian.dumitrescu@intel.com>; Pradeep <pradeep@us.ibm.com>; gowrishankar <gowrishankar.m@linux.vnet.ibm.com> Subject: [PATCH v5 4/8] table: enable table library for ppc64le From: gowrishankar <gowrishankar.m@linux.vnet.ibm.com> This patch enables librte_table in ppc64le. Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com> --- config/defconfig_ppc_64-power8-linuxapp-gcc | 1 - 1 file changed, 1 deletion(-) -- 1.9.1
Comments
Thanks Chao for bringing up. I had fixed one of .c earlier before rebasing to master. I then dropped the patch while decoupling ppc enablement and bug fixes. Now I realize on why we need this fix as part of enabling table in ppc completely. So, added one additional patch separately fixing this in v6. After this patch, a ltable lib unit test fail as in Intel case currently and it is not related to powerpc changes. If some one already looking into broken unit test failure for table lib, that is helpful. Regards, Gowrishankar On Tuesday 16 August 2016 01:26 PM, Chao Zhu wrote: > Gowrishankar, > > The unit test of table got failed. > When I took a look at the code, it failed on this line in file > lib/librte_table/rte_table_hash_key8.c , > lib/librte_table/rte_table_hash_key16.c, > lib/librte_table/rte_table_hash_key32.c: > > if ((check_params_create_lru(p) != 0) || > ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) > || > ((sizeof(struct rte_bucket_4_8) % RTE_CACHE_LINE_SIZE) != > 0)) { > return NULL; > } > > if ((check_params_create_lru(p) != 0) || > ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) > || > ((sizeof(struct rte_bucket_4_16) % RTE_CACHE_LINE_SIZE) != > 0)) { > return NULL; > } > > if ((check_params_create_lru(p) != 0) || > ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) > || > ((sizeof(struct rte_bucket_4_32) % RTE_CACHE_LINE_SIZE) != > 0)) { > return NULL; > } > > The size of rte_bucket_4_8/16/32 is not aligned to cache line size. This is > normal, because POWER has different cache line size. The change of struct > rte_bucket_4_8/16/32 may solve this problem. I didn't do further > investigation. Can you help to double check this patch? > > > -----Original Message----- > From: Gowrishankar Muthukrishnan [mailto:gowrishankar.m@linux.vnet.ibm.com] > Sent: 2016年8月12日 20:03 > To: dev@dpdk.org > Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>; Bruce Richardson > <bruce.richardson@intel.com>; Konstantin Ananyev > <konstantin.ananyev@intel.com>; Thomas Monjalon <thomas.monjalon@6wind.com>; > Cristian Dumitrescu <cristian.dumitrescu@intel.com>; Pradeep > <pradeep@us.ibm.com>; gowrishankar <gowrishankar.m@linux.vnet.ibm.com> > Subject: [PATCH v5 4/8] table: enable table library for ppc64le > > From: gowrishankar <gowrishankar.m@linux.vnet.ibm.com> > > This patch enables librte_table in ppc64le. > > Signed-off-by: Gowrishankar Muthukrishnan > <gowrishankar.m@linux.vnet.ibm.com> > --- > config/defconfig_ppc_64-power8-linuxapp-gcc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc > b/config/defconfig_ppc_64-power8-linuxapp-gcc > index dede34f..41f67d5 100644 > --- a/config/defconfig_ppc_64-power8-linuxapp-gcc > +++ b/config/defconfig_ppc_64-power8-linuxapp-gcc > @@ -59,5 +59,4 @@ CONFIG_RTE_LIBRTE_FM10K_PMD=n # This following libraries > are not available on Power. So they're turned off. > CONFIG_RTE_LIBRTE_SCHED=n > CONFIG_RTE_LIBRTE_PORT=n > -CONFIG_RTE_LIBRTE_TABLE=n > CONFIG_RTE_LIBRTE_PIPELINE=n > -- > 1.9.1 > > >
diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/config/defconfig_ppc_64-power8-linuxapp-gcc index dede34f..41f67d5 100644 --- a/config/defconfig_ppc_64-power8-linuxapp-gcc +++ b/config/defconfig_ppc_64-power8-linuxapp-gcc @@ -59,5 +59,4 @@ CONFIG_RTE_LIBRTE_FM10K_PMD=n # This following libraries are not available on Power. So they're turned off. CONFIG_RTE_LIBRTE_SCHED=n CONFIG_RTE_LIBRTE_PORT=n -CONFIG_RTE_LIBRTE_TABLE=n CONFIG_RTE_LIBRTE_PIPELINE=n