[dpdk-dev] i40e: warnings should include i40e in some example applications
Commit Message
As i40e introduced recently in DPDK, the warnings should include
i40e when no supported NIC port found during initialization at
least in below example applications.
* app/testpmd
* exception_path
* kni
Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
app/test-pmd/testpmd.c | 3 ++-
examples/exception_path/main.c | 5 +++--
examples/kni/main.c | 5 +++--
3 files changed, 8 insertions(+), 5 deletions(-)
Comments
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Helin Zhang
> Sent: Thursday, July 3, 2014 3:55 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: warnings should include i40e in some example applications
>
> As i40e introduced recently in DPDK, the warnings should include
> i40e when no supported NIC port found during initialization at
> least in below example applications.
> * app/testpmd
> * exception_path
> * kni
>
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
> app/test-pmd/testpmd.c | 3 ++-
> examples/exception_path/main.c | 5 +++--
> examples/kni/main.c | 5 +++--
> 3 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index e8a4b45..0c0ac77 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1859,7 +1859,8 @@ main(int argc, char** argv)
> "check that "
> "CONFIG_RTE_LIBRTE_IGB_PMD=y and that "
> "CONFIG_RTE_LIBRTE_EM_PMD=y and that "
> - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in your "
> + "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and that "
> + "CONFIG_RTE_LIBRTE_I40E_PMD=y in your "
> "configuration file\n");
>
> set_def_fwd_config();
> diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c
> index 0204116..c4245a3 100644
> --- a/examples/exception_path/main.c
> +++ b/examples/exception_path/main.c
> @@ -575,8 +575,9 @@ main(int argc, char** argv)
> nb_sys_ports = rte_eth_dev_count();
> if (nb_sys_ports == 0)
> FATAL_ERROR("No supported Ethernet devices found - check that "
> - "CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
> - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file");
> + "CONFIG_RTE_LIBRTE_IGB_PMD=y, "
> + "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or "
> + "CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file");
> /* Find highest port set in portmask */
> for (high_port = (sizeof(ports_mask) * 8) - 1;
> (high_port != 0) && !(ports_mask & (1 << high_port));
> diff --git a/examples/kni/main.c b/examples/kni/main.c
> index 7df1b36..f3666e2 100644
> --- a/examples/kni/main.c
> +++ b/examples/kni/main.c
> @@ -898,8 +898,9 @@ main(int argc, char** argv)
> nb_sys_ports = rte_eth_dev_count();
> if (nb_sys_ports == 0)
> rte_exit(EXIT_FAILURE, "No supported Ethernet devices found - "
> - "check that CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
> - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file\n");
> + "check that CONFIG_RTE_LIBRTE_IGB_PMD=y, "
> + "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or "
> + "CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file\n");
>
> /* Check if the configured port ID is valid */
> for (i = 0; i < RTE_MAX_ETHPORTS; i++)
> --
> 1.8.1.4
2014-07-03 15:54, Helin Zhang:
> As i40e introduced recently in DPDK, the warnings should include
> i40e when no supported NIC port found during initialization at
> least in below example applications.
> * app/testpmd
> * exception_path
> * kni
>
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
I think it's better to remove these warnings.
I am going to send a patch. Please ack if you agree.
@@ -1859,7 +1859,8 @@ main(int argc, char** argv)
"check that "
"CONFIG_RTE_LIBRTE_IGB_PMD=y and that "
"CONFIG_RTE_LIBRTE_EM_PMD=y and that "
- "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in your "
+ "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and that "
+ "CONFIG_RTE_LIBRTE_I40E_PMD=y in your "
"configuration file\n");
set_def_fwd_config();
@@ -575,8 +575,9 @@ main(int argc, char** argv)
nb_sys_ports = rte_eth_dev_count();
if (nb_sys_ports == 0)
FATAL_ERROR("No supported Ethernet devices found - check that "
- "CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
- "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file");
+ "CONFIG_RTE_LIBRTE_IGB_PMD=y, "
+ "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or "
+ "CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file");
/* Find highest port set in portmask */
for (high_port = (sizeof(ports_mask) * 8) - 1;
(high_port != 0) && !(ports_mask & (1 << high_port));
@@ -898,8 +898,9 @@ main(int argc, char** argv)
nb_sys_ports = rte_eth_dev_count();
if (nb_sys_ports == 0)
rte_exit(EXIT_FAILURE, "No supported Ethernet devices found - "
- "check that CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
- "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file\n");
+ "check that CONFIG_RTE_LIBRTE_IGB_PMD=y, "
+ "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or "
+ "CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file\n");
/* Check if the configured port ID is valid */
for (i = 0; i < RTE_MAX_ETHPORTS; i++)